scroll for typeahead #1195
Closed
scroll for typeahead #1195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into development
…into development
Current coverage is 88.78% (diff: 94.95%)
@@ development #1195 diff @@
=============================================
Files 35 35
Lines 1280 1347 +67
Methods 228 239 +11
Messages 0 0
Branches 213 228 +15
=============================================
+ Hits 1096 1196 +100
+ Misses 184 151 -33
Partials 0 0
|
valorkin
reviewed
Nov 2, 2016
| @@ -126,6 +127,14 @@ export class PositionService { | |||
| return (nativeEl.style as KeyAttribute)[cssProp]; | |||
| } | |||
|
|
|||
| private get window():Window { | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| @@ -8,20 +8,20 @@ import { TypeaheadDirective } from './typeahead.directive'; | |||
| import { TypeaheadMatch } from './typeahead-match.class'; | |||
|
|
|||
| const bs4 = ` | |||
| <div class="dropdown-menu" | |||
| [ngStyle]="{top: top, left: left, display: 'block'}" | |||
| <div #ulElement class="dropdown-menu" | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1168 Fixed scroll for typeahead.