chore: publish automatically to NPM #23
Conversation
| "name": "@valora/plugins", | ||
| "version": "0.0.0-semantic-release", | ||
| "main": "dist/index.js", | ||
| "repository": "git@github.com:valora-inc/typescript-starter.git", | ||
| "typings": "dist/index.d.ts", | ||
| "repository": "https://github.com/valora-inc/plugins.git", |
There was a problem hiding this comment.
Should we try to find a more creative name instead?
- @valora/fuse
- @valora/boost
- @valora/mod
- @valora/connect (😅)
- @valora/link
- @valora/flex
- ?
There was a problem hiding this comment.
@valora/asset-plugins? 🙈 idk if you had a strong preference for a very broad name but it can be harder to understand at first glance what something like "@valora/boost" does...
There was a problem hiding this comment.
Is the intent to have a mono-repo of all the plugins?
There was a problem hiding this comment.
monorepo sounds good for now, but i don't want to open source this repo (and advertise this plug-in model) until we can reconsider splitting it out. I have vague concerns from an open source encouragement and maintainership perspective.
There was a problem hiding this comment.
Yes we're not there yet.
One thing is pricing calculations have dependencies between plugins. We'll need to think what's the best route to take with this constraint. If plugins are in a central location some things are easier.
| "name": "@valora/plugins", | ||
| "version": "0.0.0-semantic-release", | ||
| "main": "dist/index.js", | ||
| "repository": "git@github.com:valora-inc/typescript-starter.git", | ||
| "typings": "dist/index.d.ts", | ||
| "repository": "https://github.com/valora-inc/plugins.git", |
There was a problem hiding this comment.
@valora/asset-plugins? 🙈 idk if you had a strong preference for a very broad name but it can be harder to understand at first glance what something like "@valora/boost" does...
jeanregisser
force-pushed
the
jeanregisser/autopublish-npm
branch
from
b9d0da5
to
68397d3
Compare
This reverts commit e6629c5.
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Publish automatically to NPM so we can consume plugins from https://github.com/valora-inc/plugins-api
Copied from valora-inc/logging#5