chore: publish automatically to NPM #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanregisser
force-pushed
the
jeanregisser/semantic-release
branch
6 times, most recently
from
dfee717
to
187e4b1
Compare
jeanregisser
force-pushed
the
jeanregisser/semantic-release
branch
from
187e4b1
to
0d83dcb
Compare
jeanregisser
added a commit
to valora-inc/renovate-config
that referenced
this pull request
Oct 26, 2022
Now that we're [automatically publishing some valora packages](valora-inc/logging#5), we don't want to wait for them to be pulled in by Renovate.
jeanregisser
added a commit
that referenced
this pull request
Oct 26, 2022
Now that's we're using [semantic-release](#5) it's important PR titles follow the convention. https://github.com/marketplace/actions/semantic-pull-request is a simple solution for this. We should probably add it to https://github.com/valora-inc/typescript-app-starter too.
cajubelt
approved these changes
Oct 26, 2022
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@valora/logging", | |||
| "version": "1.0.0", | |||
| "version": "0.0.0-semantic-release", | |||
.github/workflows/workflow.yaml
Outdated
| uses: google-github-actions/get-secretmanager-secrets@v0 | ||
| with: | ||
| secrets: |- | ||
| NPM_TOKEN:projects/1027349420744/secrets/NPM_TOKEN |
There was a problem hiding this comment.
this is cool. does it need a version?
There was a problem hiding this comment.
The version is optional, I now realize there's an even shorter form:
# Long form
projects/<project-id>/secrets/<secret-id>/versions/<version-id>
# Long form - "latest" version
projects/<project-id>/secrets/<secret-id>
# Short form
<project-id>/<secret-id>/<version-id>
# Short form - "latest" version
<project-id>/<secret-id>
|
🎉 This PR is included in version 1.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
jeanregisser
added a commit
to valora-inc/hooks
that referenced
this pull request
Mar 30, 2023
Publish automatically to NPM so we can consume plugins from https://github.com/valora-inc/plugins-api Copied from valora-inc/logging#5
jeanregisser
added a commit
to valora-inc/viem-account-hsm-gcp
that referenced
this pull request
Apr 19, 2024
Publish automatically to NPM using [semantic-release](https://github.com/semantic-release/semantic-release) Similar to what we did in valora-inc/logging#5 Fixes RET-1037
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This publishes the lib automatically when changes land on main.
It uses semantic-release for this.
A tag is created automatically and a GitHub release with a changelog.
See first successful publish: https://www.npmjs.com/package/@valora/logging
GitHub actions run: https://github.com/valora-inc/logging/actions/runs/3327458719/jobs/5502307846
And release: https://github.com/valora-inc/logging/releases/tag/v1.0.0
Note: I had temporary enabled publishing from this branch to ensure it's working end-to-end.
semantic-release can also update the package version and changelog committed in the repo, but it requires bypassing branch protection and giving more permission to the repo. I felt this wasn't really needed.