chore: publish automatically to NPM #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanregisser
commented
Apr 17, 2024
.github/workflows/workflow.yaml
Outdated
Comment on lines
86
to
87
| NPM_TOKEN:valora-viem-hsm-test/NPM_TOKEN | ||
| SLACK_WEBHOOK_URL:valora-viem-hsm-test/SLACK_ONCALL_WEBHOOK_URL |
There was a problem hiding this comment.
For now I've copied these secrets from celo-mobile-mainnet to the new GCP project valora-viem-hsm-test.
But to limit duplication, we could grant access to the service account I created for the new project.
There was a problem hiding this comment.
Ok I've updated it to access the specific secrets needed and avoid duplication.
jeanregisser
force-pushed
the
jeanregisser/readme
branch
from
d344859
to
111e123
Compare
jeanregisser
force-pushed
the
jeanregisser/semantic-release
branch
from
042f120
to
8bd1d3b
Compare
kathaypacific
approved these changes
Apr 19, 2024
| "main": "dist/index.js", | ||
| "repository": "git@github.com:valora-inc/typescript-starter.git", | ||
| "name": "@valora/viem-account-hsm-gcp", | ||
| "version": "0.0.0-semantic-release", |
There was a problem hiding this comment.
woah, is this a special version number for the initial release?
There was a problem hiding this comment.
No it's just to denote that the version is managed by semantic-release. And hopefully avoid confusion.
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Publish automatically to NPM using semantic-release
Similar to what we did in valora-inc/logging#5
Fixes RET-1037