chore: enforce semantic PR title #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 This PR is included in version 1.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
jeanregisser
added a commit
to valora-inc/typescript-app-starter
that referenced
this pull request
Dec 5, 2022
We decided to use semantic PR title as it can help with automated releases and changelog generation. This helps ensure new repos will enforce that rule too. Already used in valora-inc/logging#7 See also: https://valora-app.slack.com/archives/C025V1D6F3J/p1669991436336709
jeanregisser
added a commit
to valora-inc/wallet
that referenced
this pull request
Jan 3, 2023
### Description We decided to use semantic PR title as it can help with automated releases and changelog generation. Already used in valora-inc/logging#7 and valora-inc/typescript-app-starter#51 ### Test plan N/A ### Related issues Discussed on [Slack](https://valora-app.slack.com/archives/C025V1D6F3J/p1669991436336709). ### Backwards compatibility N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we're using semantic-release it's important PR titles follow the convention.
https://github.com/marketplace/actions/semantic-pull-request is a simple solution for this.
We should probably add it to https://github.com/valora-inc/typescript-app-starter too.