addressed a Dart 2 analysis issue #70
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devoncarew
commented
Apr 13, 2018
devoncarew
commented
- addressed a Dart 2 analysis issue
6 tasks
|
Thanks a lot for the PR. I'll try to have a look at it. It looks like older versions are complaining at the moment, so maybe I will need to create a new major to address all the Dart 2 issues |
valotas
reviewed
Apr 14, 2018
| @@ -0,0 +1,2 @@ | |||
| analyzer: | |||
There was a problem hiding this comment.
Why is this file needed? Isn't --strong in the build.sh enough?
There was a problem hiding this comment.
I think we generally prefer using strong in the analysis options file - all clients that get it, instead of people knowing to pass in as a cli flag.
But they do end of being the same thing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.