-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .jenkins file for new CI #232
Conversation
Codecov Report
@@ Coverage Diff @@
## master #232 +/- ##
=======================================
Coverage 87.76% 87.76%
=======================================
Files 46 46
Lines 1381 1381
=======================================
Hits 1212 1212
Misses 169 169 Continue to review full report at Codecov.
|
ffdf20d
to
597e280
Compare
After getting hung up on a bunch of really tiny things, I think this is pretty much good. I tested the 'publish edge image', 'draft github release', and 'publish release images' by temporarily setting the there is definitely room for improvement/simplification of things (e.g. if there is a jenkins plugin for github releasing, that would probably be better than the tooling we use now), but with this we should at least have parity with the circleci config. there are two parts that are not quite all the way there:
|
6662289
to
b3e02d4
Compare
This should be ready for review. This PR adds the Jenkins config which has feature parity with the CircleCI config. It also removes the Circle config. Project settings have been updated to no longer use Circle. |
It looks like codecov isn't working just yet
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few things of point, but otherwise this look phenominal
@@ -17,6 +17,32 @@ pipeline { | |||
steps { | |||
sh 'make lint' | |||
} | |||
post { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will happen automatically, shouldn't need to call it out explicitly. There's a problem with our Jenkins after a plug-in update that isn't working
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking back now, I think this is fine - it's a bit verbose but it'll help show why pull requests fail
.jenkins
Outdated
status: 'failure', | ||
context: 'vio-build/lint', | ||
description: 'Source code linting failed', | ||
targetUrl: "${env.JOB_URL}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of ${env.JOB_URL}
use ${env.RUN_DISPLAY_URL}
which will take you to the Blue Ocean page and not the broke ass Jenkins legacy page
the tests that are failing here should be fixed in #233. Those changes will be merged into this branch, at which point this should be good to go into master. |
WIP