Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update temporary directory usage in tests #233

Merged
merged 2 commits into from
Dec 3, 2018

Conversation

edaniszewski
Copy link
Contributor

Instead of using the custom temporary directory fixtures set up long ago, this updates tests to use pytest's tmpdir. Since socket names have a character limit (I think something like 100 chars), and tmpdir tends to make long/nested directories (good for isolation, bad for this use case), a tmpsocket fixture was created to manage sockets for tests.

@codecov
Copy link

codecov bot commented Dec 3, 2018

Codecov Report

Merging #233 into jenkins-ci will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           jenkins-ci     #233      +/-   ##
==============================================
+ Coverage       87.76%   87.83%   +0.07%     
==============================================
  Files              46       46              
  Lines            1381     1381              
==============================================
+ Hits             1212     1213       +1     
+ Misses            169      168       -1
Impacted Files Coverage Δ
synse/plugin.py 88.59% <0%> (+0.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc722d0...d0268d1. Read the comment docs.

@marcoceppi marcoceppi merged commit 8a3868f into jenkins-ci Dec 3, 2018
@edaniszewski edaniszewski deleted the update-test-dir-fixtures branch December 3, 2018 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants