Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend ModelCredentialsAuthenticatable with async authenticator #743

Closed
petralli opened this issue Aug 11, 2022 · 0 comments · Fixed by #744
Closed

Extend ModelCredentialsAuthenticatable with async authenticator #743

petralli opened this issue Aug 11, 2022 · 0 comments · Fixed by #744
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@petralli
Copy link

Actually, the ModelCredentialsAuthenticatable protocol only expose the credentialsAuthenticator (future).

To allow to easy override the authenticate function with async code, it should also expose an asyncCredentialsAuthenticator (async).
@petralli petralli added the enhancement New feature or request label Aug 11, 2022
@0xTim 0xTim added good first issue Good for newcomers help wanted Extra attention is needed labels Aug 11, 2022
@0xTim 0xTim linked a pull request Aug 16, 2022 that will close this issue
Add asyncCredentialsAuthenticator to ModelCredentialsAuthenticatable #744
Merged
0xTim pushed a commit that referenced this issue Aug 16, 2022
@fatto
Add asyncCredentialsAuthenticator to `ModelCredentialsAuthenticatab…
26c4460 
…le` (#744)

* Extend ModelCredentialsAuthenticatable with asyncCredentialsAuthenticator #743

* compiler guards for test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add asyncCredentialsAuthenticator to ModelCredentialsAuthenticatable
2 participants
@0xTim @petralli