Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add asyncCredentialsAuthenticator to ModelCredentialsAuthenticatable #744

Merged
merged 2 commits into from
Aug 16, 2022
Merged

Add asyncCredentialsAuthenticator to ModelCredentialsAuthenticatable #744

merged 2 commits into from
Aug 16, 2022

Conversation

fatto
Copy link
Contributor

@fatto fatto commented Aug 16, 2022 •
edited by 0xTim
Loading

Adds asyncCredentialsAuthenticator to ModelCredentialsAuthenticatable to allow it to be overridden if needs be

0xTim
0xTim approved these changes Aug 16, 2022
View reviewed changes
Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@0xTim 0xTim added the semver-minor Contains new APIs label Aug 16, 2022
@0xTim 0xTim changed the title Extend ModelCredentialsAuthenticatable with asyncCredentialsAuthenticator #743 Add asyncCredentialsAuthenticator to ModelCredentialsAuthenticatable Aug 16, 2022
@0xTim 0xTim linked an issue Aug 16, 2022 that may be closed by this pull request
Extend ModelCredentialsAuthenticatable with async authenticator #743
Closed
@0xTim 0xTim merged commit 26c4460 into vapor:main Aug 16, 2022
@VaporBot
Copy link

These changes are now available in 4.5.0

@fatto fatto deleted the async-ModelCredentialsAuthenticatable branch August 16, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xTim 0xTim 0xTim approved these changes

Assignees
No one assigned
Labels
semver-minor Contains new APIs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend ModelCredentialsAuthenticatable with async authenticator
3 participants
@fatto @VaporBot @0xTim