feat(xo-server,xo-web): disable Load Balancer during Rolling Pool Update

Fixes #5711
Follow-up of #6057

CHANGELOG.unreleased.md

@@ -9,6 +9,7 @@
 
 - Limit number of concurrent VM migrations per pool to `3` [#6065](https://github.com/vatesfr/xen-orchestra/issues/6065) (PR [#6076](https://github.com/vatesfr/xen-orchestra/pull/6076))
   Can be changed in `xo-server`'s configuration file: `xapiOptions.vmMigrationConcurrency`
+- [Rolling Pool Update] Automatically pause load balancer plugin during the update [#5711](https://github.com/vatesfr/xen-orchestra/issues/5711)
 
 ### Bug fixes
 
@@ -34,4 +35,5 @@
 - @xen-orchestra/backups patch
 - @xen-orchestra/backups-cli patch
 - @xen-orchestra/proxy patch
-- xo-server patch
+- xo-server minor
+- xo-web minor

packages/xo-server/src/api/pool.mjs

@@ -132,7 +132,17 @@ installPatches.description = 'Install patches on hosts'
 // -------------------------------------------------------------------
 
 export async function rollingUpdate({ pool }) {
+  const loadBalancerPlugin = (await this.getPlugins()).find(plugin => plugin.name === 'load-balancer')
+  const pauseLoadBalancer = loadBalancerPlugin?.loaded
+  if (pauseLoadBalancer) {
+    await this.unloadPlugin('load-balancer')
+  }
+
   await this.getXapi(pool).rollingPoolUpdate()
+
+  if (pauseLoadBalancer) {
+    await this.loadPlugin('load-balancer')
+  }
 }
 
 rollingUpdate.params = {

packages/xo-web/src/common/intl/messages.js

@@ -1004,6 +1004,8 @@ const messages = {
   rollingPoolUpdateMessage:
     'Are you sure you want to start a rolling pool update? Running VMs will be migrated back and forth and this can take a while.',
   rollingPoolUpdateHaWarning: 'High Availability is enabled. This will automatically disable it during the update.',
+  rollingPoolUpdateLoadBalancerWarning:
+    'Load Balancer plugin is running. This will automatically pause it during the update.',
   poolNeedsDefaultSr: 'The pool needs a default SR to install the patches.',
   vmsHaveCds: '{nVms, number} VM{nVms, plural, one {} other {s}} {nVms, plural, one {has} other {have}} CDs',
   ejectCds: 'Eject CDs',

packages/xo-web/src/common/xo/rolling-pool-updates-modal/index.js

@@ -1,10 +1,16 @@
 import _ from 'intl'
+import addSubscriptions from 'add-subscriptions'
 import BaseComponent from 'base-component'
 import Icon from 'icon'
 import React from 'react'
 import { connectStore } from 'utils'
 import { createGetObjectsOfType } from 'selectors'
 
+import { subscribePlugins } from '../'
+
+@addSubscriptions(() => ({
+  plugins: subscribePlugins,
+}))
 @connectStore(
   {
     pools: createGetObjectsOfType('pool'),
@@ -14,6 +20,7 @@ import { createGetObjectsOfType } from 'selectors'
 export default class RollingPoolUpdateModal extends BaseComponent {
   render() {
     const pool = this.props.pools[this.props.pool]
+    const loadBalancerPlugin = this.props.plugins && this.props.plugins.find(plugin => plugin.name === 'load-balancer')
 
     return (
       <div>
@@ -25,6 +32,13 @@ export default class RollingPoolUpdateModal extends BaseComponent {
             </em>
           </p>
         )}
+        {loadBalancerPlugin && loadBalancerPlugin.loaded && (
+          <p>
+            <em className='text-warning'>
+              <Icon icon='alarm' /> {_('rollingPoolUpdateLoadBalancerWarning')}
+            </em>
+          </p>
+        )}
       </div>
     )
   }