fix: fieldMappingTime data error when clear inputvalue

[DesignHhuang]

Description

fixed #4892

#4904 的方式可能引起别的bug , 这边重新修改提了 PR

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)

Summary by CodeRabbit

• Bug Fixes

  • Improved handling of time values by clearing associated fields when the main field is not populated.

• Refactor

  • Enhanced logic within the component to maintain responsiveness and functionality without altering the overall structure or interface.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 0d53fa5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Walkthrough

The changes in the form-actions.vue component focus on the handleRangeTimeValue function, where a new condition was added to clear the startTimeKey and endTimeKey values when both are defined and the main field value is null. The component's overall structure, interface, and core logic, including computed properties and form handling functions, remain unchanged. The watch function for the collapsed state continues to function as before, ensuring responsiveness.

Changes

File Path	Change Summary
packages/@core/ui-kit/form-ui/src/components/form-actions.vue	Modified handleRangeTimeValue to clear startTimeKey and endTimeKey if both are defined and the main field is null. No changes to overall structure or public entity declarations.

Possibly related PRs

• feat: add fieldMapToTime prop to FormRenderProps #4838: This PR modifies the handleRangeTimeValue function in form-actions.vue, which is directly related to the changes made in the main PR that also involves modifications to the same function, specifically adding a condition for clearing time values.

Suggested reviewers

• vince292007
• anncwb

🐇 In the meadow, time does play,
With fields of values, bright and gay.
When the main field's empty, oh so clear,
We tidy up, bring time fields near.
A hop, a skip, all's in line,
In our form's dance, everything's fine! 🌼

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

packages/@core/ui-kit/form-ui/src/components/form-actions.vue

Oops! Something went wrong! :(

ESLint: 9.14.0

Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/node_modules/@vben/eslint-config/dist/index.mjs' imported from /eslint.config.mjs
at finalizeResolution (node:internal/modules/esm/resolve:257:11)
at moduleResolve (node:internal/modules/esm/resolve:914:10)
at defaultResolve (node:internal/modules/esm/resolve:1038:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:557:12)
at ModuleLoader.resolve (node:internal/modules/esm/loader:525:25)
at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:246:38)
at ModuleJob._link (node:internal/modules/esm/module_job:126:49)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

packages/@core/ui-kit/form-ui/src/components/form-actions.vue (1)

94-97: Consider adding test coverage for this edge case.

To prevent regression, it would be valuable to add test cases that verify:

1. Time fields are properly cleared when the main field is set to null
2. Time fields retain values when main field has valid data

Would you like me to help create test cases for this scenario?

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between b87d41b and 0d53fa5.

📒 Files selected for processing (1)

• packages/@core/ui-kit/form-ui/src/components/form-actions.vue (1 hunks)

🔇 Additional comments (1)

packages/@core/ui-kit/form-ui/src/components/form-actions.vue (1)

94-97: LGTM! The fix properly handles time field cleanup.

The added condition correctly ensures that when a field value is null, its associated start and end time values are also cleared, preventing inconsistent form state.

Let's verify this doesn't affect other form scenarios: