-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update modal.vue #4987
chore: update modal.vue #4987
Conversation
loading时候 子组件禁用点击事件
|
WalkthroughThe changes in the Changes
Possibly related PRs
Suggested reviewers
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 eslint
packages/@core/ui-kit/popup-ui/src/modal/modal.vueOops! Something went wrong! :( ESLint: 9.15.0 Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/node_modules/@vben/eslint-config/dist/index.mjs' imported from /eslint.config.mjs Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (3)
packages/@core/ui-kit/popup-ui/src/modal/modal.vue (3)
239-239
: LGTM! Consider enhancing the loading state feedback.The implementation correctly prevents form interaction during loading using
pointer-events-none
. This aligns well with the PR objective.Consider adding a transition for smoother state changes:
- 'pointer-events-none overflow-hidden': showLoading, + 'pointer-events-none overflow-hidden transition-opacity duration-200': showLoading,
Line range hint
89-99
: Consider improving scroll behavior during loading state changes.The scroll reset implementation could be enhanced for better user experience.
Consider these improvements:
watch( () => showLoading.value, (v) => { if (v && wrapperRef.value) { wrapperRef.value.scrollTo({ - // behavior: 'smooth', + behavior: 'smooth', top: 0, }); } }, );
Line range hint
242-247
: Consider improving loading spinner visibility.The loading spinner implementation could be enhanced to ensure it's always visible above the content.
Consider adding z-index management:
<VbenLoading v-if="showLoading" - class="size-full h-auto min-h-full" + class="size-full h-auto min-h-full relative z-10" spinning />
modal 加入 表单时候! loading时候 表单应该为不可以操作状态!
Summary by CodeRabbit
New Features
Bug Fixes
Improvements