Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update modal.vue #4987

Merged
merged 2 commits into from
Nov 30, 2024
Merged

chore: update modal.vue #4987

merged 2 commits into from
Nov 30, 2024

Conversation

huangfe1
Copy link
Contributor

@huangfe1 huangfe1 commented Nov 29, 2024

modal 加入 表单时候! loading时候 表单应该为不可以操作状态!

Summary by CodeRabbit

  • New Features

    • Enhanced modal functionality with improved loading state handling.
    • Added fullscreen toggle capability without resetting position.
  • Bug Fixes

    • Refined interaction handling for dismissable modals and outside clicks.
  • Improvements

    • Adjusted user interaction controls for better responsiveness, especially on mobile devices.

loading时候 子组件禁用点击事件
Copy link

changeset-bot bot commented Nov 29, 2024

⚠️ No Changeset found

Latest commit: 476c652

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented Nov 29, 2024

Walkthrough

The changes in the modal.vue file focus on enhancing the modal component's properties and rendering logic. Key updates include the conditional application of the pointer-events-none class during loading states, improvements to the fullscreen handling function, and refinements to the interaction functions to ensure correct behavior based on modal configuration. The interface for modal properties has also been updated to include an optional modalApi. These modifications aim to improve the usability and responsiveness of the modal, especially in mobile contexts.

Changes

File Path Change Summary
packages/@core/ui-kit/popup-ui/src/modal/modal.vue - Updated showLoading to apply pointer-events-none class during loading.
- Refined handleFullscreen to toggle fullscreen without resetting position.
- Enhanced pointerDownOutside to check for dismissable modal ID.
- Adjusted interactOutside and escapeKeyDown to prevent default actions based on modal properties.
- Updated interface to include optional modalApi.

Possibly related PRs

Suggested reviewers

  • vince292007
  • anncwb

🐰 "In the modal's cozy space,
Loading's kept at bay,
With fullscreen toggles in their place,
And clicks that won't betray.
A hop, a skip, a joyful cheer,
Usability's drawing near!" 🐇

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

packages/@core/ui-kit/popup-ui/src/modal/modal.vue

Oops! Something went wrong! :(

ESLint: 9.15.0

Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/node_modules/@vben/eslint-config/dist/index.mjs' imported from /eslint.config.mjs
at finalizeResolution (node:internal/modules/esm/resolve:257:11)
at moduleResolve (node:internal/modules/esm/resolve:914:10)
at defaultResolve (node:internal/modules/esm/resolve:1038:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:557:12)
at ModuleLoader.resolve (node:internal/modules/esm/loader:525:25)
at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:246:38)
at ModuleJob._link (node:internal/modules/esm/module_job:126:49)


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (3)
packages/@core/ui-kit/popup-ui/src/modal/modal.vue (3)

239-239: LGTM! Consider enhancing the loading state feedback.

The implementation correctly prevents form interaction during loading using pointer-events-none. This aligns well with the PR objective.

Consider adding a transition for smoother state changes:

-            'pointer-events-none overflow-hidden': showLoading,
+            'pointer-events-none overflow-hidden transition-opacity duration-200': showLoading,

Line range hint 89-99: Consider improving scroll behavior during loading state changes.

The scroll reset implementation could be enhanced for better user experience.

Consider these improvements:

 watch(
   () => showLoading.value,
   (v) => {
     if (v && wrapperRef.value) {
       wrapperRef.value.scrollTo({
-        // behavior: 'smooth',
+        behavior: 'smooth',
         top: 0,
       });
     }
   },
 );

Line range hint 242-247: Consider improving loading spinner visibility.

The loading spinner implementation could be enhanced to ensure it's always visible above the content.

Consider adding z-index management:

 <VbenLoading
   v-if="showLoading"
-  class="size-full h-auto min-h-full"
+  class="size-full h-auto min-h-full relative z-10"
   spinning
 />
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 253abc5 and 87cdabb.

📒 Files selected for processing (1)
  • packages/@core/ui-kit/popup-ui/src/modal/modal.vue (1 hunks)

@anncwb anncwb changed the title Update modal.vue chore: update modal.vue Nov 30, 2024
@anncwb anncwb merged commit e8992a1 into vbenjs:main Nov 30, 2024
5 checks passed
@anncwb anncwb added the chore label Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants