Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(video): add support for webcodec video #761

Merged
merged 11 commits into from
Mar 15, 2023
Merged

feat(video): add support for webcodec video #761

merged 11 commits into from
Mar 15, 2023

Conversation

2xAA
Copy link
Member

@2xAA 2xAA commented Aug 28, 2022

fix #521

To-do:

  • Style playback controls
  • Fix texture controls (currently duplicates assets in memory when focused)
  • Store playback settings on texture

@2xAA 2xAA requested a review from TimPietrusky August 28, 2022 22:33
@2xAA 2xAA self-assigned this Aug 29, 2022
@2xAA 2xAA marked this pull request as ready for review August 30, 2022 22:10
@radiodario
Copy link
Contributor

FXERdL9WQAAHthM-1

@TimPietrusky
Copy link
Member

@radiodario checking it now!

@TimPietrusky
Copy link
Member

@2xAA I tested this again and what is not working is to load the video from a preset:

  1. Add module Texture 2D
  2. Select texture type video
  3. Choose a video
  4. Save the preset
  5. Reload modV
  6. Load the preset
  7. See that nothing is playing and there is no error in the dev console when the preset is loaded
  8. See that you can't use any controls in the module inspector for the video, as there are errors (different for each control that is used):
Cannot read properties of undefined (reading 'getElapsedTime')
Cannot read properties of undefined (reading 'playbackrate')
Cannot read properties of undefined (reading 'paused')
Cannot set properties of undefined (setting 'currentTime')

@radiodario so sadly we can't merge this yet, but hopefully soon!

@2xAA
Copy link
Member Author

2xAA commented Feb 16, 2023

Thanks @TimPietrusky. The latest commit should fix this.

@2xAA 2xAA merged commit 0ec7ca4 into next Mar 15, 2023
@2xAA 2xAA deleted the feat/521/video branch March 15, 2023 20:21
github-actions bot pushed a commit that referenced this pull request Apr 5, 2023
# [3.27.0](3.26.1...3.27.0) (2023-04-05)

### Bug Fixes

* conform path paths for crossplatform compatibility ([#835](#835)) ([0f66f55](0f66f55))

### Features

* **video:** add support for webcodec video ([#761](#761)) ([0ec7ca4](0ec7ca4)), closes [#695](#695) [#695](#695)
@github-actions
Copy link

github-actions bot commented Apr 5, 2023

🎉 This PR is included in version 3.27.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Video support
3 participants