Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: conform path paths for crossplatform compatibility #835

Merged
merged 1 commit into from
Apr 1, 2023
Merged

fix: conform path paths for crossplatform compatibility #835

merged 1 commit into from
Apr 1, 2023

Conversation

2xAA
Copy link
Member

@2xAA 2xAA commented Mar 31, 2023

Also fixes bad import for uuid in video.js.

@2xAA 2xAA requested a review from TimPietrusky March 31, 2023 14:54
@TimPietrusky
Copy link
Member

TimPietrusky commented Apr 1, 2023 •
edited
Loading

@2xAA for real? The path separator? 🙈
Super strange that we have never encountered this so far.

Thanks for the fix!

TimPietrusky
TimPietrusky approved these changes Apr 1, 2023
View reviewed changes
Copy link
Member

@TimPietrusky TimPietrusky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TimPietrusky TimPietrusky merged commit 0f66f55 into next Apr 1, 2023
@TimPietrusky TimPietrusky deleted the fix/texturePathResolution branch April 1, 2023 10:37
@2xAA
Copy link
Member Author

2xAA commented Apr 1, 2023 via email

@TimPietrusky
Copy link
Member

Oh I see, thanks!

github-actions bot pushed a commit that referenced this pull request Apr 5, 2023
@semantic-release-bot
chore(release): 3.27.0
a026a12 
# [3.27.0](3.26.1...3.27.0) (2023-04-05)

### Bug Fixes

* conform path paths for crossplatform compatibility ([#835](#835)) ([0f66f55](0f66f55))

### Features

* **video:** add support for webcodec video ([#761](#761)) ([0ec7ca4](0ec7ca4)), closes [#695](#695) [#695](#695)
@github-actions
Copy link

github-actions bot commented Apr 5, 2023

🎉 This PR is included in version 3.27.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimPietrusky TimPietrusky TimPietrusky approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@2xAA @TimPietrusky