✅ internal/cache/cacher test (#553)

* add test and comment * fix * Apply suggestions from code review Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com> Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
vdaas · Jul 7, 2020 · 0a1afea · 0a1afea
1 parent 94e4c6f
commit 0a1afea
Show file tree

Hide file tree

Showing 2 changed files with 69 additions and 44 deletions.
diff --git a/internal/cache/cacher/cacher.go b/internal/cache/cacher/cacher.go
@@ -19,13 +19,15 @@ package cacher
 
 import "strings"
 
+// Type represents the cacher type. Currently it support GACHE only.
 type Type uint8
 
 const (
 	Unknown Type = iota
 	GACHE
 )
 
+// String returns the type name.
 func (m Type) String() string {
 	switch m {
 	case GACHE:
@@ -34,6 +36,7 @@ func (m Type) String() string {
 	return "unknown"
 }
 
+// ToType returns the type based on the string.
 func ToType(str string) Type {
 	switch strings.ToLower(str) {
 	case "gache":

diff --git a/internal/cache/cacher/cacher_test.go b/internal/cache/cacher/cacher_test.go
@@ -43,25 +43,27 @@ func TestType_String(t *testing.T) {
 		return nil
 	}
 	tests := []test{
-		// TODO test cases
-		/*
-		   {
-		       name: "test_case_1",
-		       want: want{},
-		       checkFunc: defaultCheckFunc,
-		   },
-		*/
-
-		// TODO test cases
-		/*
-		   func() test {
-		       return test {
-		           name: "test_case_2",
-		           want: want{},
-		           checkFunc: defaultCheckFunc,
-		       }
-		   }(),
-		*/
+		{
+			name: "return `gache` when type is gache",
+			m:    GACHE,
+			want: want{
+				want: "gache",
+			},
+		},
+		{
+			name: "return `unknown` when type is unknown",
+			m:    Unknown,
+			want: want{
+				want: "unknown",
+			},
+		},
+		{
+			name: "return `unknown` when the type is invalid",
+			m:    Type(100),
+			want: want{
+				want: "unknown",
+			},
+		},
 	}
 
 	for _, test := range tests {
@@ -107,31 +109,51 @@ func TestToType(t *testing.T) {
 		return nil
 	}
 	tests := []test{
-		// TODO test cases
-		/*
-		   {
-		       name: "test_case_1",
-		       args: args {
-		           str: "",
-		       },
-		       want: want{},
-		       checkFunc: defaultCheckFunc,
-		   },
-		*/
-
-		// TODO test cases
-		/*
-		   func() test {
-		       return test {
-		           name: "test_case_2",
-		           args: args {
-		           str: "",
-		           },
-		           want: want{},
-		           checkFunc: defaultCheckFunc,
-		       }
-		   }(),
-		*/
+		{
+			name: "return GACHE type when the string is `gache`",
+			args: args{
+				str: "gache",
+			},
+			want: want{
+				want: GACHE,
+			},
+		},
+		{
+			name: "return GACHE type when the string is `Gache`",
+			args: args{
+				str: "Gache",
+			},
+			want: want{
+				want: GACHE,
+			},
+		},
+		{
+			name: "return GACHE type when the string is `GACHE`",
+			args: args{
+				str: "GACHE",
+			},
+			want: want{
+				want: GACHE,
+			},
+		},
+		{
+			name: "return Unknown type when the string is invalid",
+			args: args{
+				str: "invalid",
+			},
+			want: want{
+				want: Unknown,
+			},
+		},
+		{
+			name: "return Unknown type when the string is empty",
+			args: args{
+				str: "",
+			},
+			want: want{
+				want: Unknown,
+			},
+		},
 	}
 
 	for _, test := range tests {