Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/cache/cacher test #553

Merged
merged 3 commits into from
Jul 7, 2020
Merged

internal/cache/cacher test #553

merged 3 commits into from
Jul 7, 2020

Conversation

kevindiu
Copy link
Contributor

@kevindiu kevindiu commented Jul 6, 2020 •
edited
Loading

Description:

This PR implements internal/cache/cacher test case.

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.14.3
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.11.5

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@pull-assistant
Copy link

pull-assistant bot commented Jul 6, 2020 •
edited
Loading

Score: 0.99

Best reviewed: commit by commit

Optimal code review plan

     add test and comment

     fix

     Apply suggestions from code review

Powered by Pull Assistant. Last update b674614 ... d620242. Read the comment docs.

@kevindiu kevindiu requested a review from hlts2 July 6, 2020 09:44
@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jul 6, 2020

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - add changelog comment
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • ⏪ /rebase - rebase master

@codecov
Copy link

codecov bot commented Jul 6, 2020 •
edited
Loading

Codecov Report

Merging #553 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #553      +/-   ##
=========================================
+ Coverage    9.70%   9.75%   +0.04%     
=========================================
  Files         402     402              
  Lines       20859   20859              
=========================================
+ Hits         2025    2035      +10     
+ Misses      18577   18567      -10     
  Partials      257     257
Impacted Files Coverage Δ
internal/cache/cacher/cacher.go 100.00% <ø> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94e4c6f...d620242. Read the comment docs.

@kevindiu kevindiu requested a review from hlts2 July 7, 2020 01:05
@kevindiu
Copy link
Contributor Author

kevindiu commented Jul 7, 2020

/rebase

@github-actions github-actions bot added size/L and removed size/M labels Jul 7, 2020
@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jul 7, 2020

[REBASE] Rebase triggered by kevindiu for branch: test/internal/cache/cacher

@vdaas-ci vdaas-ci force-pushed the test/internal/cache/cacher branch from e7fc1cb to ec2aaf5 Compare July 7, 2020 01:11
hlts2
hlts2 previously approved these changes Jul 7, 2020
View reviewed changes
Copy link
Collaborator

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevindiu kevindiu changed the title [Draft] internal/cache/cacher test internal/cache/cacher test Jul 7, 2020
@kevindiu kevindiu marked this pull request as ready for review July 7, 2020 01:23
@kevindiu kevindiu requested a review from vankichi July 7, 2020 01:24
vankichi
vankichi reviewed Jul 7, 2020
View reviewed changes
Copy link
Contributor

@vankichi vankichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevindiu almost LGTM.
Could you fix comment?

internal/cache/cacher/cacher.go Outdated Show resolved Hide resolved
vankichi
vankichi previously approved these changes Jul 7, 2020
View reviewed changes
Copy link
Contributor

@vankichi vankichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vankichi
Copy link
Contributor

vankichi commented Jul 7, 2020

/rebase
/format
/approve

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jul 7, 2020

[REBASE] Rebase triggered by vankichi for branch: test/internal/cache/cacher

kevindiu and others added 3 commits July 7, 2020 08:52
@kevindiu @actions-user
add test and comment
b674614
@kevindiu @actions-user
fix
a074ba2
@kevindiu @vankichi @actions-user
Apply suggestions from code review
d620242 
Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
@vdaas-ci vdaas-ci force-pushed the test/internal/cache/cacher branch from 4d4fa5b to d620242 Compare July 7, 2020 08:52
@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jul 7, 2020

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

vdaas-ci
vdaas-ci approved these changes Jul 7, 2020
View reviewed changes
Copy link
Collaborator

@vdaas-ci vdaas-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[APPROVED] This PR is approved by vankichi.

@vankichi vankichi merged commit 0a1afea into master Jul 7, 2020
@vankichi vankichi deleted the test/internal/cache/cacher branch July 7, 2020 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdaas-ci vdaas-ci vdaas-ci approved these changes

@hlts2 hlts2 hlts2 left review comments

@vankichi vankichi vankichi left review comments

Assignees
No one assigned
Labels
area/internal priority/low size/L team/set SET team type/test Adding tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kevindiu @vdaas-ci @vankichi @hlts2