-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for pkg/agent/core/ngt/service/vqueue/option #1233
Add test for pkg/agent/core/ngt/service/vqueue/option #1233
Conversation
[CHATOPS:HELP] ChatOps commands.
|
Codecov Report
@@ Coverage Diff @@
## master #1233 +/- ##
==========================================
+ Coverage 17.47% 17.53% +0.06%
==========================================
Files 498 498
Lines 30835 30845 +10
==========================================
+ Hits 5387 5409 +22
+ Misses 25164 25157 -7
+ Partials 284 279 -5
Continue to review full report at Codecov.
|
Please also refactor https://github.com/vdaas/vald/blob/master/pkg/agent/core/ngt/service/vqueue/queue.go#L85 to handle option error, otherwise if the option is invalid, the ngt may not work due to your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/rebase |
[REBASE] Rebase triggered by kevindiu for branch: test/pkg/add-agent-core-ngt-service-vqueue-option-test |
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
1fb52d4
to
59c8071
Compare
[FORMAT] Updating license headers and formatting go codes triggered by kevindiu. |
/approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[APPROVED] This PR is approved by kevindiu.
Signed-off-by: hlts2 hiroto.funakoshi.hiroto@gmail.com
Description:
I added test code for
pkg/agent/core/ngt/serice/vqueue/option.go
and godoc comment.And I refactored based on a document of option error handling and fixed ci fails error.
gramer check passed
Related Issue:
How Has This Been Tested?:
Environment:
Types of changes:
Changes to Core Features:
Checklist: