Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for pkg/agent/core/ngt/service/vqueue/option #1233

Merged
merged 6 commits into from
May 24, 2021
Merged

Add test for pkg/agent/core/ngt/service/vqueue/option #1233

merged 6 commits into from
May 24, 2021

Commits on May 24, 2021

  1. feat: add option test and godoc comment 

    Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
    @hlts2 @kevindiu
    hlts2 authored and kevindiu committed May 24, 2021
    Configuration menu
    Copy the full SHA
    f82eb1f View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review

    @hlts2 @kevindiu
    hlts2 authored and kevindiu committed May 24, 2021
    Configuration menu
    Copy the full SHA
    dbc120f View commit details
    Browse the repository at this point in the history

  3. fix: ci fails error 

    Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
    @hlts2 @kevindiu
    hlts2 authored and kevindiu committed May 24, 2021
    Configuration menu
    Copy the full SHA
    726e4b5 View commit details
    Browse the repository at this point in the history

  4. fix: edge case 

    Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
    @hlts2 @kevindiu
    hlts2 authored and kevindiu committed May 24, 2021
    Configuration menu
    Copy the full SHA
    7e9686f View commit details
    Browse the repository at this point in the history

  5. fix: add edge case and boundary 

    Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
    @hlts2 @kevindiu
    hlts2 authored and kevindiu committed May 24, 2021
    Configuration menu
    Copy the full SHA
    26e360b View commit details
    Browse the repository at this point in the history

  6. fix: option error handling 

    Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
    @hlts2 @kevindiu
    hlts2 authored and kevindiu committed May 24, 2021
    Configuration menu
    Copy the full SHA
    59c8071 View commit details
    Browse the repository at this point in the history