Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor pkg test helper functions #1678

Merged
merged 29 commits into from
Jun 2, 2022
Merged

Refactor pkg test helper functions #1678

Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
829b460
refactor charset helper func
kevindiu May 25, 2022
743b8b6
refactor vector helper func
kevindiu May 25, 2022
05f872a
refactor request helper func
kevindiu May 25, 2022
7e374aa
add missing files
kevindiu May 25, 2022
847bbe2
move charset to conv
kevindiu May 26, 2022
a3dc388
return error from helper func
kevindiu May 26, 2022
7691ea4
refactor conv helper func
kevindiu May 30, 2022
1cddad7
refactor fill() and implement buildIndex()
kevindiu May 31, 2022
90be937
fix comment
kevindiu May 31, 2022
0796dc5
refactor convertXXX
kevindiu May 31, 2022
b5759bd
refactor search test func
kevindiu May 31, 2022
6964a0e
refactor beforeFunc test func to use buildIndex
kevindiu Jun 1, 2022
9cd164c
:robot: Update license headers / Format go codes and yaml files
vdaas-ci Jun 1, 2022
7037415
Revert ":robot: Update license headers / Format go codes and yaml files"
kevindiu Jun 1, 2022
15ea532
format code
kevindiu Jun 1, 2022
1343782
fix comment
kevindiu Jun 1, 2022
b6a9057
implement test for helper functions
kevindiu Jun 1, 2022
61d76d5
add comments to helper functions
kevindiu Jun 1, 2022
928b4c8
implement conv test
kevindiu Jun 1, 2022
9eb32fc
fix golangci warning
kevindiu Jun 1, 2022
c203493
fix comment
kevindiu Jun 1, 2022
c85b54c
fix golangci warning
kevindiu Jun 2, 2022
5ad9c5a
split encode()
kevindiu Jun 2, 2022
b6591a4
implement boundary value test for vector/gen
kevindiu Jun 2, 2022
f60334a
use io instead of ioutil package
kevindiu Jun 2, 2022
dd4d4f7
Update internal/conv/conv_test.go
kevindiu Jun 2, 2022
be8dd0b
add boundary tests
kevindiu Jun 2, 2022
082ac19
fix test error
kevindiu Jun 2, 2022
c477b85
add more boundary tests
kevindiu Jun 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions internal/conv/conv.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ package conv

import (
"io"
vankichi marked this conversation as resolved.
Show resolved Hide resolved
"io/ioutil"
"reflect"
"strings"
"unsafe"
Expand Down Expand Up @@ -66,7 +65,7 @@ func Utf8ToEucjp(s string) (string, error) {
}

func encode(r io.Reader, t transform.Transformer) (string, error) {
b, err := ioutil.ReadAll(transform.NewReader(r, t))
b, err := io.ReadAll(transform.NewReader(r, t))
if err != nil {
return "", err
}
Expand Down