Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement agent handler getObject test case #1707

Merged
merged 3 commits into from
Jun 30, 2022
Merged

Implement agent handler getObject test case #1707

merged 3 commits into from
Jun 30, 2022

Conversation

kevindiu
Copy link
Contributor

@kevindiu kevindiu commented Jun 21, 2022 •
edited
Loading

Signed-off-by: kevindiu kevindiujp@gmail.com

Description:

Same as title

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.18.3
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.6

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • ⏪ /rebase - rebase master
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@codecov
Copy link

codecov bot commented Jun 21, 2022 •
edited
Loading

Codecov Report

Merging #1707 (125a944) into master (75e578f) will increase coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1707      +/-   ##
==========================================
+ Coverage   31.57%   31.69%   +0.11%     
==========================================
  Files         385      385              
  Lines       32713    32713              
==========================================
+ Hits        10328    10367      +39     
+ Misses      21991    21948      -43     
- Partials      394      398       +4
Impacted Files Coverage Δ
...nt/core/ngt/service/vqueue/uninserted_index_map.go 70.49% <0.00%> (-2.74%) ⬇️
internal/worker/worker.go 84.37% <0.00%> (+0.78%) ⬆️
internal/worker/queue.go 100.00% <0.00%> (+1.26%) ⬆️
pkg/agent/core/ngt/handler/grpc/object.go 58.99% <0.00%> (+30.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecbca98...125a944. Read the comment docs.

@kevindiu kevindiu requested a review from vankichi June 21, 2022 01:05
vankichi
vankichi reviewed Jun 23, 2022
View reviewed changes
Copy link
Contributor

@vankichi vankichi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any case for checking dimension size?

@kevindiu
Copy link
Contributor Author

If dimension size is different, the vector cannot be inserted hence cannot be returned from getObject.
Is there any other thing that you are concerning?

@kevindiu kevindiu mentioned this pull request Jun 23, 2022
Merged
18 tasks
@kevindiu kevindiu requested a review from vankichi June 23, 2022 04:13
@kevindiu
draft get object test case
706a45f 
Signed-off-by: kevindiu <kevindiujp@gmail.com>
@kevindiu
implement get object tests
e266ed9 
Signed-off-by: kevindiu <kevindiujp@gmail.com>
@kevindiu kevindiu force-pushed the test/pkg/add-pkg-agent-handler-get-object-test branch from 0e42684 to e266ed9 Compare June 29, 2022 07:57
@github-actions github-actions bot removed the size/S label Jun 29, 2022
@kevindiu
fix incorrect test impl
125a944 
Signed-off-by: kevindiu <kevindiujp@gmail.com>
@kevindiu kevindiu requested review from a team and datelier and removed request for a team June 29, 2022 08:15
@kevindiu kevindiu marked this pull request as ready for review June 29, 2022 08:32
@kevindiu kevindiu changed the title [WIP] Implement agent handler getObject test case Implement agent handler getObject test case Jun 29, 2022
@kevindiu kevindiu merged commit 9ea85a3 into master Jun 30, 2022
@kevindiu kevindiu deleted the test/pkg/add-pkg-agent-handler-get-object-test branch June 30, 2022 05:45
kevindiu added a commit that referenced this pull request Jul 4, 2022
@kevindiu
Implement agent handler getObject test case (#1707)
3bd7262 
* draft get object test case

Signed-off-by: kevindiu <kevindiujp@gmail.com>

* implement get object tests

Signed-off-by: kevindiu <kevindiujp@gmail.com>

* fix incorrect test impl

Signed-off-by: kevindiu <kevindiujp@gmail.com>
@kevindiu kevindiu mentioned this pull request Jul 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datelier datelier datelier approved these changes

@vankichi vankichi vankichi approved these changes

Assignees
No one assigned
Labels
area/agent/core priority/low size/XL team/set SET team type/test Adding tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kevindiu @vdaas-ci @vankichi @datelier