Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement agent handler indexInfo test case #1708

Merged
merged 22 commits into from
Jul 21, 2022

Conversation

kevindiu
Copy link
Contributor

@kevindiu kevindiu commented Jun 21, 2022

Signed-off-by: kevindiu kevindiujp@gmail.com

Description:

Same as title/

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.18.3
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.6

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #1708 (9f5c647) into master (3227058) will increase coverage by 0.40%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1708      +/-   ##
==========================================
+ Coverage   31.25%   31.65%   +0.40%     
==========================================
  Files         346      372      +26     
  Lines       27657    32313    +4656     
==========================================
+ Hits         8644    10230    +1586     
- Misses      18749    21691    +2942     
- Partials      264      392     +128     
Impacted Files Coverage Δ
internal/test/data/request/insert.go 92.10% <ø> (ø)
internal/test/data/request/remove.go 100.00% <100.00%> (ø)
internal/worker/queue.go 96.20% <0.00%> (-3.80%) ⬇️
...nt/core/ngt/service/vqueue/uninserted_index_map.go 70.49% <0.00%> (-2.74%) ⬇️
internal/worker/worker.go 83.59% <0.00%> (ø)
pkg/agent/core/ngt/handler/grpc/index.go 17.21% <0.00%> (ø)
pkg/agent/core/ngt/handler/grpc/upsert.go 31.06% <0.00%> (ø)
pkg/agent/core/ngt/handler/grpc/option.go 92.68% <0.00%> (ø)
pkg/agent/core/ngt/usecase/agentd.go 0.00% <0.00%> (ø)
pkg/agent/core/ngt/router/router.go 100.00% <0.00%> (ø)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 003f80d...9f5c647. Read the comment docs.

@kevindiu kevindiu requested a review from vankichi June 21, 2022 08:57
Copy link
Contributor

@vankichi vankichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any case for checking dimension size?

@kevindiu
Copy link
Contributor Author

same as
#1707 (comment)

pkg/agent/core/ngt/handler/grpc/index_test.go Outdated Show resolved Hide resolved
pkg/agent/core/ngt/handler/grpc/index_test.go Outdated Show resolved Hide resolved
internal/client/v1/client/discoverer/discover.go Outdated Show resolved Hide resolved
internal/client/v1/client/discoverer/discover.go Outdated Show resolved Hide resolved
internal/client/v1/client/discoverer/discover.go Outdated Show resolved Hide resolved
internal/client/v1/client/discoverer/discover.go Outdated Show resolved Hide resolved
internal/client/v1/client/discoverer/discover.go Outdated Show resolved Hide resolved
internal/test/mock/server_stream.go Outdated Show resolved Hide resolved
internal/client/v1/client/discoverer/discover.go Outdated Show resolved Hide resolved
@kevindiu kevindiu force-pushed the test/pkg/add-pkg-agent-handler-index-info-test branch from 2303deb to 23175bb Compare July 6, 2022 04:45
@github-actions github-actions bot added size/XL and removed size/XL labels Jul 6, 2022
@kevindiu kevindiu force-pushed the test/pkg/add-pkg-agent-handler-index-info-test branch from d556161 to c143d89 Compare July 6, 2022 07:57
@github-actions github-actions bot added size/XL and removed size/XL labels Jul 6, 2022
@kevindiu kevindiu marked this pull request as ready for review July 6, 2022 08:30
@kevindiu kevindiu changed the title [WIP] Implement agent handler indexInfo test case Implement agent handler indexInfo test case Jul 6, 2022
Signed-off-by: kevindiu <kevindiujp@gmail.com>
Signed-off-by: kevindiu <kevindiujp@gmail.com>
Signed-off-by: kevindiu <kevindiujp@gmail.com>
@github-actions github-actions bot removed the size/XL label Jul 14, 2022
Signed-off-by: kevindiu <kevindiujp@gmail.com>
@github-actions github-actions bot added size/XL and removed size/XL labels Jul 14, 2022
Signed-off-by: kevindiu <kevindiujp@gmail.com>
@github-actions github-actions bot added size/XL and removed size/XL labels Jul 14, 2022
@github-actions github-actions bot added size/XL and removed size/XL labels Jul 14, 2022
Signed-off-by: kevindiu <kevindiujp@gmail.com>
@github-actions github-actions bot added size/XL and removed size/XL labels Jul 14, 2022
@kevindiu kevindiu requested a review from vankichi July 14, 2022 09:15
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jul 19, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9f5c647
Status: ✅  Deploy successful!
Preview URL: https://d604bfc3.vald.pages.dev
Branch Preview URL: https://test-pkg-add-pkg-agent-handl.vald.pages.dev

View logs

@github-actions github-actions bot added size/XL and removed size/XL labels Jul 19, 2022
@github-actions github-actions bot added size/XL and removed size/XL labels Jul 19, 2022
@github-actions github-actions bot added size/XL and removed size/XL labels Jul 21, 2022
@kevindiu kevindiu merged commit ed23300 into master Jul 21, 2022
@kevindiu kevindiu deleted the test/pkg/add-pkg-agent-handler-index-info-test branch July 21, 2022 05:03
@kevindiu kevindiu mentioned this pull request Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants