Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement agent handler createIndex test case #1710

Merged
merged 12 commits into from
Jul 28, 2022
Merged

Implement agent handler createIndex test case #1710

merged 12 commits into from
Jul 28, 2022

Conversation

kevindiu
Copy link
Contributor

@kevindiu kevindiu commented Jun 23, 2022 •
edited
Loading

Signed-off-by: kevindiu kevindiujp@gmail.com

Description:

SSIA

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.18.3
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.6

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • ⏪ /rebase - rebase master
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@codecov
Copy link

codecov bot commented Jun 23, 2022 •
edited
Loading

Codecov Report

Merging #1710 (3540b47) into master (020c573) will increase coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1710      +/-   ##
==========================================
+ Coverage   31.30%   31.38%   +0.08%     
==========================================
  Files         381      381              
  Lines       32698    32698              
==========================================
+ Hits        10235    10262      +27     
+ Misses      22063    22033      -30     
- Partials      400      403       +3
Impacted Files Coverage Δ
internal/worker/queue.go 98.73% <0.00%> (-1.27%) ⬇️
internal/worker/worker.go 83.59% <0.00%> (ø)
pkg/agent/core/ngt/handler/grpc/remove.go 26.94% <0.00%> (+4.66%) ⬆️
pkg/agent/core/ngt/handler/grpc/index.go 32.78% <0.00%> (+15.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 020c573...3540b47. Read the comment docs.

@kevindiu kevindiu requested a review from vankichi June 23, 2022 04:13
@kevindiu
draft create index test cases
e937239 
Signed-off-by: kevindiu <kevindiujp@gmail.com>
@kevindiu
Update pkg/agent/core/ngt/handler/grpc/index_test.go
32f65d0
@kevindiu
add invalid dimension test case
92ece01 
Signed-off-by: kevindiu <kevindiujp@gmail.com>
@kevindiu kevindiu force-pushed the test/pkg/add-pkg-agent-handler-create-index-test branch from 9c0d8ea to 92ece01 Compare July 6, 2022 08:58
@kevindiu
impl create index test
1c2c9de 
Signed-off-by: kevindiu <kevindiujp@gmail.com>
@github-actions github-actions bot added size/L and removed size/S labels Jul 7, 2022
@kevindiu
add missing file
66f6c00 
Signed-off-by: kevindiu <kevindiujp@gmail.com>
@kevindiu
impl invalid dim test
ff83c2a 
Signed-off-by: kevindiu <kevindiujp@gmail.com>
@github-actions github-actions bot added size/XL and removed size/L labels Jul 11, 2022
@kevindiu kevindiu changed the title [WIP] Implement agent handler createIndex test case Implement agent handler createIndex test case Jul 11, 2022
@kevindiu kevindiu marked this pull request as ready for review July 11, 2022 01:47
@kevindiu kevindiu requested review from a team and hlts2 and removed request for a team July 11, 2022 02:03
@github-actions github-actions bot removed the size/L label Jul 12, 2022
@kevindiu kevindiu requested a review from vankichi July 12, 2022 07:53
@vankichi vankichi mentioned this pull request Jul 13, 2022
Merged
18 tasks
vankichi
vankichi reviewed Jul 14, 2022
View reviewed changes
pkg/agent/core/ngt/handler/grpc/index_test.go Outdated Show resolved Hide resolved
pkg/agent/core/ngt/handler/grpc/index_test.go Outdated Show resolved Hide resolved
pkg/agent/core/ngt/handler/grpc/index_test.go Outdated Show resolved Hide resolved
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jul 21, 2022 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3540b47
Status: ✅  Deploy successful!
Preview URL: https://b90065ec.vald.pages.dev
Branch Preview URL: https://test-pkg-add-pkg-agent-handl-df8g.vald.pages.dev

View logs

@kevindiu
refactor
a1f7768 
Signed-off-by: kevindiu <kevindiujp@gmail.com>
@github-actions github-actions bot added size/L and removed size/L labels Jul 26, 2022
@github-actions github-actions bot added size/L and removed size/L labels Jul 26, 2022
@kevindiu kevindiu requested a review from vankichi July 26, 2022 02:38
@kevindiu kevindiu requested a review from vankichi July 27, 2022 07:08
@github-actions github-actions bot removed the size/L label Jul 27, 2022
@github-actions github-actions bot added size/L and removed size/L labels Jul 27, 2022
hlts2
hlts2 approved these changes Jul 28, 2022
View reviewed changes
Copy link
Collaborator

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevindiu kevindiu merged commit 428f81b into master Jul 28, 2022
@kevindiu kevindiu deleted the test/pkg/add-pkg-agent-handler-create-index-test branch July 28, 2022 03:07
@kevindiu kevindiu mentioned this pull request Oct 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@hlts2 hlts2 hlts2 approved these changes

@vankichi vankichi vankichi approved these changes

Assignees
No one assigned
Labels
area/agent/core priority/low size/XL team/set SET team type/test Adding tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kevindiu @vdaas-ci @vankichi @hlts2