[WIP] Add mirror gateway definition #1792
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
|
[CHATOPS:HELP] ChatOps commands.
|
github-actions
bot
added
area/gateway/filter
area/gateway/lb
area/manager/index
size/S
type/feature
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This reverts commit 1b1af8c.
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Deploying with
|
| Latest commit: |
2857f1a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b76bb9f9.vald.pages.dev |
| Branch Preview URL: | https://feature-add-mirror-gateway-d.vald.pages.dev |
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
kpango
reviewed
Sep 26, 2022
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
kpango
reviewed
Sep 29, 2022
vankichi
reviewed
Sep 29, 2022
vankichi
previously approved these changes
Dec 7, 2022
kpango
force-pushed
the
main
branch
2 times, most recently
from
9b3087a
to
4a659f2
Compare
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
apis/docs/v1/docs.md
Outdated
|
|
||
| ### Search.Config | ||
| ### Insert |
There was a problem hiding this comment.
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Insert
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
apis/docs/v1/docs.md
Outdated
|
|
||
| <a name="payload-v1-Remove"></a> | ||
|
|
||
| ### Remove |
There was a problem hiding this comment.
[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: Remove
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
|
[FOSSA] The scan result will be available at https://app.fossa.com/projects/custom%2B21465%2Fvald/refs/branch/feature%2Fadd-mirror-gateway-definition/f57d30ef9ce3394ed5b56894fb81350e5167e5e5 |
Profile Report
|
2 tasks
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
WHAT
Added proto definition for mirror gateway.
The following RPCs are added.
WHY
we need to support request mirroring for BCP
Although there are many differences, most of them are due to automatic generation.
The following is the main addition.
Related Issue:
How Has This Been Tested?:
Environment:
Types of changes:
Changes to Core Features:
Checklist: