-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merge pending] Add mirror gateway definition #1948
Conversation
[CHATOPS:HELP] ChatOps commands.
|
|
||
Copyright (C) 2019-2022 vdaas.org vald team <vald@vdaas.org> | ||
|
||
Licensed under the Apache License, Version 2.0 (the "License"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[LanguageTool] reported by reviewdog 🐶
Unpaired symbol: ‘)’ seems to be missing (EN_UNPAIRED_BRACKETS)
URL: https://languagetool.org/insights/post/punctuation-guide/#what-are-parentheses
Rule: https://community.languagetool.org/rule/show/EN_UNPAIRED_BRACKETS?lang=en-US
Category: PUNCTUATION
59a8a5f
to
568db0d
Compare
Deploying with
|
Latest commit: |
08c44fb
|
Status: | ✅ Deploy successful! |
Preview URL: | https://d80d7551.vald.pages.dev |
Branch Preview URL: | https://feature-mirror-gateway-defin.vald.pages.dev |
8ece068
to
2909af0
Compare
9fdc06b
to
9c1ef3f
Compare
bb05061
to
618cc97
Compare
11eec16
to
3496ac1
Compare
3496ac1
to
a54e74e
Compare
[WARNING:INTCFG] Changes in |
ENV APP_NAME mirror | ||
|
||
# skipcq: DOK-DL3008 | ||
RUN apt-get update && apt-get install -y --no-install-recommends \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This reverts commit 7ece16f.
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
This reverts commit 454eaf3.
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
* fix: returns all connection information in the registration rpc Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: lint warnning Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactor: deleted unnecessary parameter Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> --------- Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
* feat: add new crud logic Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactor code Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactor: error handling logic Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: bugfix error handling for rpc Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * feat: add test for RemoveByTimestamp Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: fails error test Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactor: test logic Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: add new condition and add test case Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactor code Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: error handling and comment Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: test case name and test case order Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: execute format Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: add new comment Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> --------- Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
* fix: update mirror document Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: format Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * feat: add removeByTimestamp section Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: grammar warning Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: grammar warning and refactor document Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: grammar warning Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * feat: add mirror gateway troubleshooting docs Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * style: format code with Gofumpt and Prettier This commit fixes the style issues introduced in 2c492f7 according to the output from Gofumpt and Prettier. Details: #2207 * feat: add contents of troubleshooting document Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: grammar warning Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: grammar Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: link path Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: invalid link path Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: refactor docs Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: deleted unnecessary contents Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: status handling logic document Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: document refactor Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: bugfix status handling document Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: refactor sentence Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> --------- Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
# gRPC client configuration (overrides defaults.grpc.client) | ||
client: {} | ||
# The duration to register other Mirror Gateways. | ||
register_duration: "1s" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[LanguageTool] reported by reviewdog 🐶
This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: Register
URL: https://languagetool.org/insights/post/spelling-capital-letters/
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING
ctx, cancel := context.WithCancel(context.Background()) | ||
eg, egctx := errgroup.New(ctx) | ||
|
||
uuid := "test" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci] reported by reviewdog 🐶
string test
has 26 occurrences, make it a constant (goconst)
// PodName represents the mirror gateway pod name. | ||
PodName string `json:"pod_name" yaml:"pod_name"` | ||
// RegisterDuration represents the duration to register Mirror Gateway. | ||
RegisterDuration string `json:"register_duration" yaml:"register_duration"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci] reported by reviewdog 🐶
tag is not aligned , should be: json:"register_duration" yaml:"register_duration" (tagalign)
UnimplementedValdServerWithMirror vald.UnimplementedValdServerWithMirror | ||
} | ||
type want struct { | ||
wantId *payload.Object_ID |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci] reported by reviewdog 🐶
ST1003: struct field wantId should be wantID (stylecheck)
UnimplementedValdServerWithMirror: test.fields.UnimplementedValdServerWithMirror, | ||
} | ||
|
||
gotId, err := s.Exists(test.args.ctx, test.args.meta) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci] reported by reviewdog 🐶
ST1003: var gotId should be gotID (stylecheck)
Description:
WHAT
Added proto definition for mirror gateway.
The following RPCs are added.
WHY
we need to support request mirroring for BCP
Although there are many differences, most of them are due to automatic generation.
The following is the main addition.
Related PR:
#1792
Versions:
Checklist:
Special notes for your reviewer:
How to deploy
Please execute the following command if you want to perform the e2e test.