Separate markdown check by reviewdog #1890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[CHATOPS:HELP] ChatOps commands.
|
github-actions
bot
added
team/sre
vankichi
force-pushed
the
refactor/ci/separate-markdown-check
branch
from
01a96eb
to
eee7809
Compare
Deploying with
|
| Latest commit: |
e98806f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://91cfed65.vald.pages.dev |
| Branch Preview URL: | https://refactor-ci-separate-markdow.vald.pages.dev |
vankichi
force-pushed
the
refactor/ci/separate-markdown-check
branch
4 times, most recently
from
1713c81
to
7b5a553
Compare
Signed-off-by: vankichi <kyukawa315@gmail.com>
vankichi
force-pushed
the
refactor/ci/separate-markdown-check
branch
from
7b5a553
to
e98806f
Compare
vankichi
commented
Dec 12, 2022
| @@ -35,7 +35,25 @@ jobs: | |||
| with: | |||
| github_token: ${{ secrets.GITHUB_TOKEN }} | |||
| reporter: github-pr-review | |||
| patterns: "**/*.md **/*.md.gotmpl !**/CHANGELOG.md" | |||
| patterns: "apis/**/*.md apis/**/*.md.gotmpl charts/**/*.md !charts/vald/README.md" | |||
There was a problem hiding this comment.
I have ignored charts/vald/README.md because of the args error.
reviewdog/actions-languagetool uses cat command when sending the request with file raw data.
When the file has more characters than the limit, it will be failed like chats/vald/README.md.
https://github.com/reviewdog/action-languagetool/blob/master/entrypoint.sh#L48
datelier
approved these changes
Dec 13, 2022
kpango
added a commit
that referenced
this pull request
Dec 16, 2022
* Format code with prettier and gofumpt This commit fixes the style issues introduced in 4e10e17 according to the output from prettier and gofumpt. Details: https://deepsource.io/gh/vdaas/vald/transform/3468f768-127e-425d-9457-42cc8d2ef2b2/ * Fix grammar (#1889) * Fix grammar Signed-off-by: vankichi <kyukawa315@gmail.com> * Format code with prettier and gofumpt * Fix grammar Signed-off-by: vankichi <kyukawa315@gmail.com> * Format code with prettier and gofumpt Signed-off-by: vankichi <kyukawa315@gmail.com> Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> * 💚 Separate language tool (#1890) Signed-off-by: vankichi <kyukawa315@gmail.com> Signed-off-by: vankichi <kyukawa315@gmail.com> Signed-off-by: vankichi <kyukawa315@gmail.com> Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> Co-authored-by: Yusuke Kato <kpango@vdaas.org> Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
takuyaymd
pushed a commit
to aknishid/vald
that referenced
this pull request
Dec 19, 2022
* Format code with prettier and gofumpt This commit fixes the style issues introduced in 4e10e17 according to the output from prettier and gofumpt. Details: https://deepsource.io/gh/vdaas/vald/transform/3468f768-127e-425d-9457-42cc8d2ef2b2/ * Fix grammar (vdaas#1889) * Fix grammar Signed-off-by: vankichi <kyukawa315@gmail.com> * Format code with prettier and gofumpt * Fix grammar Signed-off-by: vankichi <kyukawa315@gmail.com> * Format code with prettier and gofumpt Signed-off-by: vankichi <kyukawa315@gmail.com> Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> * 💚 Separate language tool (vdaas#1890) Signed-off-by: vankichi <kyukawa315@gmail.com> Signed-off-by: vankichi <kyukawa315@gmail.com> Signed-off-by: vankichi <kyukawa315@gmail.com> Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> Co-authored-by: Yusuke Kato <kpango@vdaas.org> Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
aknishid
pushed a commit
to aknishid/vald
that referenced
this pull request
Dec 19, 2022
* Format code with prettier and gofumpt This commit fixes the style issues introduced in 4e10e17 according to the output from prettier and gofumpt. Details: https://deepsource.io/gh/vdaas/vald/transform/3468f768-127e-425d-9457-42cc8d2ef2b2/ * Fix grammar (vdaas#1889) * Fix grammar Signed-off-by: vankichi <kyukawa315@gmail.com> * Format code with prettier and gofumpt * Fix grammar Signed-off-by: vankichi <kyukawa315@gmail.com> * Format code with prettier and gofumpt Signed-off-by: vankichi <kyukawa315@gmail.com> Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> * 💚 Separate language tool (vdaas#1890) Signed-off-by: vankichi <kyukawa315@gmail.com> Signed-off-by: vankichi <kyukawa315@gmail.com> Signed-off-by: vankichi <kyukawa315@gmail.com> Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> Co-authored-by: Yusuke Kato <kpango@vdaas.org> Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I have updated the workflow to check markdown files by language tools.
It is because the required checkpoint differs between document files and auto-generated markdown files.
I have changed the following:
mdfiles under theapis/andchats/: add ignore rulesCASINGRelated Issue:
Versions:
Checklist:
Special notes for your reviewer: