Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate markdown check by reviewdog #1890

Merged
merged 1 commit into from
Dec 13, 2022
Merged

Separate markdown check by reviewdog #1890

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 21 additions & 3 deletions .github/workflows/reviewdog-markdown.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ on:
- "CHANGELOG.md"

jobs:
languagetool:
name: runner / LanguageTool
languagetool_apis_charts:
name: runner / LanguageTool / apis & charts
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
Expand All @@ -35,7 +35,25 @@ jobs:
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
reporter: github-pr-review
patterns: "**/*.md **/*.md.gotmpl !**/CHANGELOG.md"
patterns: "apis/**/*.md apis/**/*.md.gotmpl charts/**/*.md !charts/vald/README.md"
Copy link
Contributor Author

@vankichi vankichi Dec 12, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have ignored charts/vald/README.md because of the args error.
reviewdog/actions-languagetool uses cat command when sending the request with file raw data.
When the file has more characters than the limit, it will be failed like chats/vald/README.md.
https://github.com/reviewdog/action-languagetool/blob/master/entrypoint.sh#L48

level: warning
language: en-US
disabled_rules: "DOUBLE_PUNCTUATION,WORD_CONTAINS_UNDERSCORE,ARROWS,CURRENCY,DASH_RULE,EN_QUOTES"
disabled_categories: "TYPOS,TYPOGRAPHY,STYLE,CASING"
languagetool_docs:
name: runner / LanguageTool / Docs
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: set git config
run: |
git config --global --add safe.directory ${GITHUB_WORKSPACE}
- name: LanguageTool
uses: reviewdog/action-languagetool@v1
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
reporter: github-pr-review
patterns: "**/*.md **/*.md.gotmpl !**/CHANGELOG.md !apis/** !charts/**"
level: warning
language: en-US
disabled_rules: "DOUBLE_PUNCTUATION,WORD_CONTAINS_UNDERSCORE,ARROWS,CURRENCY,DASH_RULE,EN_QUOTES"
Expand Down