Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Makefile bug and update deps for checking bugfix #2002

Merged
merged 1 commit into from
Apr 10, 2023
Merged

Conversation

kpango
Copy link
Collaborator

@kpango kpango commented Apr 10, 2023

Description:

SSIA

Related Issue:

Versions:

  • Go Version: 1.20.3
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 2.0.9

Checklist:

Special notes for your reviewer:

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Apr 10, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9bc05f4
Status: ✅  Deploy successful!
Preview URL: https://3b4e9a5d.vald.pages.dev
Branch Preview URL: https://refactor-makefile.vald.pages.dev

View logs

@vdaas-ci
Copy link
Collaborator

[GEN TEST] Failed to generate tests. Error: Object

internal/info/info.go Outdated Show resolved Hide resolved
hlts2
hlts2 previously approved these changes Apr 10, 2023
Copy link
Collaborator

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpango kpango force-pushed the refactor/makefile branch 3 times, most recently from d1f7c70 to 3531e98 Compare April 10, 2023 12:18
@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Patch coverage: 71.42% and no project coverage change.

Comparison is base (86cc8c8) 29.45% compared to head (d1f7c70) 29.46%.

❗ Current head d1f7c70 differs from pull request most recent head 9bc05f4. Consider uploading reports for the commit 9bc05f4 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2002   +/-   ##
=======================================
  Coverage   29.45%   29.46%           
=======================================
  Files         365      365           
  Lines       34429    34436    +7     
=======================================
+ Hits        10142    10145    +3     
- Misses      23869    23872    +3     
- Partials      418      419    +1     
Impacted Files Coverage Δ
internal/info/info.go 84.46% <71.42%> (-0.46%) ⬇️

... and 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

hlts2
hlts2 previously approved these changes Apr 10, 2023
Copy link
Collaborator

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vdaas-ci
Copy link
Collaborator

[GEN TEST] Failed to generate tests. Error: Object

Signed-off-by: kpango <kpango@vdaas.org>
Copy link
Collaborator

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpango kpango merged commit 9503588 into main Apr 10, 2023
@kpango kpango deleted the refactor/makefile branch April 10, 2023 12:38
switch i.detail.CGOEnabled {
case "0", "false":
i.detail.CGOEnabled = "false"
case "1", "true":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
string true has 4 occurrences, make it a constant (goconst)

@ykadowak ykadowak mentioned this pull request Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants