-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix Makefile bug and update deps for checking bugfix #2002
Conversation
[CHATOPS:HELP] ChatOps commands.
|
7ab2907
to
057e37e
Compare
Deploying with Cloudflare Pages
|
[GEN TEST] Failed to generate tests. Error: Object |
057e37e
to
bae2da7
Compare
bae2da7
to
094f4f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
d1f7c70
to
3531e98
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2002 +/- ##
=======================================
Coverage 29.45% 29.46%
=======================================
Files 365 365
Lines 34429 34436 +7
=======================================
+ Hits 10142 10145 +3
- Misses 23869 23872 +3
- Partials 418 419 +1
... and 5 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[GEN TEST] Failed to generate tests. Error: Object |
3531e98
to
bf90efd
Compare
Signed-off-by: kpango <kpango@vdaas.org>
bf90efd
to
9bc05f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
switch i.detail.CGOEnabled { | ||
case "0", "false": | ||
i.detail.CGOEnabled = "false" | ||
case "1", "true": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci] reported by reviewdog 🐶
string true
has 4 occurrences, make it a constant (goconst)
Description:
SSIA
Related Issue:
Versions:
Checklist:
Special notes for your reviewer: