Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update internal/info test and add new case for coverage #2003

Merged
merged 3 commits into from
Apr 11, 2023

Conversation

vankichi
Copy link
Contributor

Description:

I have updated the internal/info test cuz internal/info has been updated by #2002

Related Issue:

Versions:

  • Go Version: 1.20.3
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 2.0.9

Checklist:

Special notes for your reviewer:

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (9503588) 29.48% compared to head (4b60d95) 29.48%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2003   +/-   ##
=======================================
  Coverage   29.48%   29.48%           
=======================================
  Files         365      365           
  Lines       34436    34436           
=======================================
+ Hits        10153    10155    +2     
+ Misses      23865    23862    -3     
- Partials      418      419    +1     
Impacted Files Coverage Δ
internal/info/info.go 85.43% <100.00%> (+0.97%) ⬆️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vdaas-ci
Copy link
Collaborator

[GEN TEST] Failed to generate tests. Error: Object

kpango
kpango previously approved these changes Apr 10, 2023
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Apr 10, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4b60d95
Status: ✅  Deploy successful!
Preview URL: https://3c45c369.vald.pages.dev
Branch Preview URL: https://test-internal-fix-info-test.vald.pages.dev

View logs

@vankichi vankichi requested a review from kpango April 10, 2023 16:14
@github-actions github-actions bot added size/L and removed size/M labels Apr 10, 2023
@vdaas-ci
Copy link
Collaborator

[GEN TEST] Failed to generate tests. Error: Object

@vankichi vankichi force-pushed the test/internal/fix-info-test-and-add-new-case branch 4 times, most recently from b778833 to e99b9fe Compare April 11, 2023 06:10
Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: vankichi <kyukawa315@gmail.com>
@vankichi vankichi force-pushed the test/internal/fix-info-test-and-add-new-case branch 2 times, most recently from a1a195f to d2b2bf8 Compare April 11, 2023 08:30
Signed-off-by: vankichi <kyukawa315@gmail.com>
@vankichi vankichi force-pushed the test/internal/fix-info-test-and-add-new-case branch from d2b2bf8 to 4b60d95 Compare April 11, 2023 08:32
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpango kpango merged commit 88a417c into main Apr 11, 2023
@kpango kpango deleted the test/internal/fix-info-test-and-add-new-case branch April 11, 2023 09:51
@ykadowak ykadowak mentioned this pull request Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants