-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add e2e envs to devcontainer #2032
Conversation
Deploying with Cloudflare Pages
|
[CHATOPS:HELP] ChatOps commands.
|
dockers/dev/README.md
Outdated
@@ -4,13 +4,13 @@ | |||
|
|||
`vald-dev-container` is designed for the development of Vald on Docker. | |||
|
|||
This image includes some libraries required for implementation and is based on `ubuntu:devel` image. | |||
This image includes some libraries required to develop Vald and is based on `mcr.microsoft.com/vscode/devcontainers/go:1` image. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better to show the specific URL of mcr.microsoft.com/vscode/devcontainers/go:1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dockerfile
and devcontainer.json
seem to fine
Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
Others looks good to me. |
It works on my apple silicon mac including auto completion of cgo dependencies (e.g. internal/core/ngt tests) and e2e tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
By |
@ykadowak yes, directly on macos with docker desktop. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM 💯
Description:
This PR adds E2E environment to our VS Code devcontainer. With this devcontainer environment, we can just start k8s cluster with k3d, deploy vald, and run e2e without any additional operation.
Made the following changes:
Related Issue:
Versions:
Checklist:
Special notes for your reviewer: