Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for devcontiner #2042

Merged
merged 13 commits into from
May 31, 2023
Merged

Conversation

ykadowak
Copy link
Contributor

@ykadowak ykadowak commented May 26, 2023

Description:

With #2032, our development experience with devcontainer has improved. This PR updates the documentation to reflect those changes.

Related Issue:

Versions:

  • Go Version: 1.20.3
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 2.0.11

Checklist:

Special notes for your reviewer:

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented May 26, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 54279a6
Status: ✅  Deploy successful!
Preview URL: https://5a9b4c27.vald.pages.dev
Branch Preview URL: https://feature-documentation-devcon.vald.pages.dev

View logs

DEVELOPMENT.md Outdated Show resolved Hide resolved
DEVELOPMENT.md Outdated Show resolved Hide resolved
@ykadowak ykadowak changed the title [WIP] Add documentation for devcontiner Add documentation for devcontiner May 26, 2023
@ykadowak ykadowak requested review from a team, kpango and hlts2 and removed request for a team May 26, 2023 05:33
DEVELOPMENT.md Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
DEVELOPMENT.md Outdated Show resolved Hide resolved
@ykadowak ykadowak requested a review from vankichi May 29, 2023 06:32
docs/contributing/development.md Outdated Show resolved Hide resolved
docs/contributing/development.md Show resolved Hide resolved
Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
Copy link
Collaborator

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vankichi vankichi merged commit 665f20c into main May 31, 2023
@vankichi vankichi deleted the feature/documentation/devcontainer branch May 31, 2023 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants