add broken index backup #2034
Merged
add broken index backup #2034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
f866a3f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5865744b.vald.pages.dev |
| Branch Preview URL: | https://feature-agent-broken-index-b.vald.pages.dev |
|
[CHATOPS:HELP] ChatOps commands.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ykadowak
changed the title
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2034 +/- ##
==========================================
+ Coverage 29.50% 29.99% +0.48%
==========================================
Files 366 366
Lines 34664 34797 +133
==========================================
+ Hits 10228 10437 +209
+ Misses 24000 23879 -121
- Partials 436 481 +45
☔ View full report in Codecov by Sentry. |
2 tasks
ykadowak
force-pushed
the
feature/agent/broken-index-backup
branch
from
af53c44
to
e6e014b
Compare
Profile Report
|
kevindiu
reviewed
Jun 7, 2023
Profile Report
|
kpango
approved these changes
Jun 7, 2023
kevindiu
approved these changes
Jun 7, 2023
2 tasks
This was referenced Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The current behavior when loading broken indexes is to discard all of them and continue running with a clean state (remove continuous). This makes it impossible to investigate broken indexes later. To address this, this PR adds a feature to allow the configuration of the number of broken indexes to be saved, enabling the investigation of broken indexes later.
This PR also changes the path to store indexes when CoW is disabled, from
n.pathton.path/originto match with the path that's used when CoW is enabled.ngt.rebuildto migrate for the backup processmigratefunction to do the migrationTestNewcovers everything)agent.ngt.broken_index_history_limitparameterinternal/test/data/agent/ngt/validIndex/*as a test index dataagentstand alone in the devcontainerRelated Issue:
Versions:
Checklist:
Special notes for your reviewer: