Fix to create index_path when it does not exists #2060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[CHATOPS:HELP] ChatOps commands.
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2060 +/- ##
==========================================
- Coverage 29.93% 29.90% -0.03%
==========================================
Files 369 369
Lines 35090 35092 +2
==========================================
- Hits 10504 10495 -9
- Misses 24104 24115 +11
Partials 482 482
☔ View full report in Codecov by Sentry. |
Deploying with
|
| Latest commit: |
d9ff733
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4ed3c7a6.vald.pages.dev |
| Branch Preview URL: | https://fix-agent-broken-index.vald.pages.dev |
ykadowak
changed the title
ykadowak
requested review from
kpango,
a team and
kevindiu
and removed request for
a team
kpango
reviewed
Jun 14, 2023
pkg/agent/core/ngt/service/ngt.go
Outdated
| files, err := file.ListInDir(path) | ||
| if err != nil { | ||
| return err | ||
| return fmt.Errorf("failed to list in %v: %w", path, err) |
There was a problem hiding this comment.
In vald it would be better to define new error at internal/errors and use it.
This was referenced Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes the regression that introduced in #2034.
When
index_pathdoes not exist, it used to create the directory and #2034 made it an error. This PR reverts it.Related Issue:
Versions:
Checklist:
Special notes for your reviewer: