-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add owner reference to the resources made by rotator to delete them when read replica resources are deleted #2287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[CHATOPS:HELP] ChatOps commands.
|
ykadowak
changed the title
Feature/readreplica/add ownerref
[WIP] Feature/readreplica/add ownerref
Jan 5, 2024
github-actions
bot
added
team/sre
SRE team
area/makefile
size/M
type/feature
New feature
priority/medium
labels
Jan 5, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2287 +/- ##
==========================================
- Coverage 29.99% 29.98% -0.01%
==========================================
Files 371 371
Lines 36126 36152 +26
==========================================
+ Hits 10835 10840 +5
- Misses 24777 24799 +22
+ Partials 514 513 -1 ☔ View full report in Codecov by Sentry. |
Deploying with Cloudflare Pages
|
ykadowak
changed the title
[WIP] Feature/readreplica/add ownerref
Add owner reference to the resources made by rotator to delete them when read replica resources are deleted
Jan 5, 2024
ykadowak
requested review from
a team,
vankichi and
datelier
and removed request for
a team
January 10, 2024 05:37
datelier
approved these changes
Jan 10, 2024
vankichi
approved these changes
Jan 10, 2024
This was referenced Jan 28, 2024
This was referenced Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The resources created by rotator will not be removed with
helm delete
as is, so this PR attaches a reference with the read replica's Deployment as the owner.Related Issue:
Versions:
Checklist:
Special notes for your reviewer: