Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add owner reference to the resources made by rotator to delete them when read replica resources are deleted #2287

Merged
merged 5 commits into from
Jan 10, 2024

Merge branch 'main' into feature/readreplica/add-ownerref

8586c1a
Select commit
Failed to load commit list.
Merged

Add owner reference to the resources made by rotator to delete them when read replica resources are deleted #2287

Merge branch 'main' into feature/readreplica/add-ownerref
8586c1a
Select commit
Failed to load commit list.
Codecov / codecov/patch failed Jan 10, 2024 in 1s

0.00% of diff hit (target 29.99%)

View this Pull Request on Codecov

0.00% of diff hit (target 29.99%)

Annotations

Check warning on line 115 in pkg/index/job/readreplica/rotate/service/rotator.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/index/job/readreplica/rotate/service/rotator.go#L113-L115 

Added lines #L113 - L115 were not covered by tests

Check warning on line 117 in pkg/index/job/readreplica/rotate/service/rotator.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/index/job/readreplica/rotate/service/rotator.go#L117 

Added line #L117 was not covered by tests

Check warning on line 124 in pkg/index/job/readreplica/rotate/service/rotator.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/index/job/readreplica/rotate/service/rotator.go#L121-L124 

Added lines #L121 - L124 were not covered by tests

Check warning on line 126 in pkg/index/job/readreplica/rotate/service/rotator.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/index/job/readreplica/rotate/service/rotator.go#L126 

Added line #L126 was not covered by tests

Check warning on line 135 in pkg/index/job/readreplica/rotate/service/rotator.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/index/job/readreplica/rotate/service/rotator.go#L135 

Added line #L135 was not covered by tests

Check warning on line 160 in pkg/index/job/readreplica/rotate/service/rotator.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/index/job/readreplica/rotate/service/rotator.go#L160 

Added line #L160 was not covered by tests

Check warning on line 188 in pkg/index/job/readreplica/rotate/service/rotator.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/index/job/readreplica/rotate/service/rotator.go#L180-L188 

Added lines #L180 - L188 were not covered by tests

Check warning on line 204 in pkg/index/job/readreplica/rotate/service/rotator.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/index/job/readreplica/rotate/service/rotator.go#L204 

Added line #L204 was not covered by tests

Check warning on line 234 in pkg/index/job/readreplica/rotate/service/rotator.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/index/job/readreplica/rotate/service/rotator.go#L226-L234 

Added lines #L226 - L234 were not covered by tests

Check warning on line 257 in pkg/index/job/readreplica/rotate/service/rotator.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/index/job/readreplica/rotate/service/rotator.go#L257 

Added line #L257 was not covered by tests

Check warning on line 260 in pkg/index/job/readreplica/rotate/service/rotator.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/index/job/readreplica/rotate/service/rotator.go#L260 

Added line #L260 was not covered by tests

Check warning on line 263 in pkg/index/job/readreplica/rotate/service/rotator.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/index/job/readreplica/rotate/service/rotator.go#L263 

Added line #L263 was not covered by tests

Check warning on line 266 in pkg/index/job/readreplica/rotate/service/rotator.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/index/job/readreplica/rotate/service/rotator.go#L266 

Added line #L266 was not covered by tests

Check warning on line 269 in pkg/index/job/readreplica/rotate/service/rotator.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/index/job/readreplica/rotate/service/rotator.go#L269 

Added line #L269 was not covered by tests

Check warning on line 284 in pkg/index/job/readreplica/rotate/service/rotator.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/index/job/readreplica/rotate/service/rotator.go#L284 

Added line #L284 was not covered by tests
View more details on Codecov