Update license headers / Format codes #2346
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vdaas CI <vald@vdaas.org>
Deploying with
|
| Latest commit: |
2766373
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f4968bd4.vald.pages.dev |
| Branch Preview URL: | https://formatter-go-and-yaml-format-9lwx.vald.pages.dev |
|
[WARNING:INTCFG] Changes in |
|
[CHATOPS:HELP] ChatOps commands.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -39,7 +39,7 @@ type Servers struct { | |||
| MetricsServers []*Server `json:"metrics_servers" yaml:"metrics_servers"` | |||
|
|
|||
| // StartUpStrategy represent starting order of server name | |||
| StartUpStrategy []string `json:"startup_strategy" yaml:"startup_strategy"` | |||
| StartUpStrategy []string `json:"startup_strategy" yaml:"startup_strategy"` | |||
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
tag is not aligned , should be: json:"startup_strategy" yaml:"startup_strategy" (tagalign)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2346 +/- ##
=======================================
Coverage 18.70% 18.70%
=======================================
Files 548 548
Lines 73641 73641
=======================================
+ Hits 13771 13775 +4
+ Misses 59137 59133 -4
Partials 733 733 ☔ View full report in Codecov by Sentry. |
2 tasks
|
Fixed by #2347 |
This was referenced Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update license headers / Format Go codes and YAML files.