Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add newline between params to avoid false formatting #2347

Merged
merged 5 commits into from
Feb 13, 2024

Conversation

ykadowak
Copy link
Contributor

@ykadowak ykadowak commented Feb 13, 2024

Description

Fix #2346

Also fixed the error messages of the formatter job

Related Issue

Versions

  • Go Version: 1.22.0
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.29.1
  • NGT Version: 2.1.6

Checklist

Special notes for your reviewer

Copy link

cloudflare-workers-and-pages bot commented Feb 13, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3338784
Status: ✅  Deploy successful!
Preview URL: https://9a5c3102.vald.pages.dev
Branch Preview URL: https://fix-format-tagalign.vald.pages.dev

View logs

@ykadowak ykadowak marked this pull request as ready for review February 13, 2024 06:39
@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@vdaas-ci
Copy link
Collaborator

[WARNING:INTCFG] Changes in interal/config may require you to change Helm charts. Please check.

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b74f2a4) 18.70% compared to head (3338784) 18.69%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2347      +/-   ##
==========================================
- Coverage   18.70%   18.69%   -0.01%     
==========================================
  Files         548      548              
  Lines       73641    73641              
==========================================
- Hits        13771    13770       -1     
- Misses      59137    59138       +1     
  Partials      733      733              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot removed the size/S label Feb 13, 2024
@ykadowak ykadowak merged commit 82380d8 into main Feb 13, 2024
122 of 123 checks passed
@ykadowak ykadowak deleted the fix/format/tagalign branch February 13, 2024 07:57
This was referenced Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants