Add efficient search logic for large top-k users

[kpango]

Description

In the current Vald search architecture, each agent receives and processes queries broadcasted by the load balancer (LB) exactly as they are received. For example, with a configuration of Top-K=10 and Agent Replica=5, the LB reduces the results from 50 (produced collectively by the agents) down to the top 10.

However, when the Top-K value is extremely high, such as 100,000, it is inefficient to search across all K multiplied by the number of replicas. To address this, we have developed a feature that adjusts the number of requests forwarded to the agents based on a configurable ratio.

This pull request introduces a 'Ratio' setting within the Search Config. This setting allows for the dynamic adjustment of the proportion of the Top-K results that are propagated to the agents. If the 'Ratio' is not configured or set to 1, the system will maintain the current behavior of forwarding 100% of the Top-K results. If set to 0.5, only 50% of the Top-K will be searched. Conversely, setting the Ratio to 1.2 will result in 120% of the Top-K being searched, effectively increasing the breadth of the search under certain conditions.

Related Issue

Versions

• Go Version: 1.22.2
• Rust Version: 1.77.2
• Docker Version: 20.10.8
• Kubernetes Version: v1.29.3
• NGT Version: 2.2.1

Checklist

• I have read the CONTRIBUTING document and completed our CLA agreement.
• I have checked open Pull Requests for the similar feature or fixes?

Special notes for your reviewer

Summary by CodeRabbit

• New Features

  • Introduced a new Dockerfile and README for the core agent.
  • Updated Kubernetes version across various GitHub templates to v1.30.0.
  • Enhanced download commands with -fsS and -fsSL options across multiple Makefiles for improved security and reliability.
  • Added new documentation images and updated installation commands in tutorials for Helm using secure curl options.

• Bug Fixes

  • Fixed protocol issues in URLs for downloading tools like golangci-lint, reviewdog, kubectl, and buf.

• Documentation

  • Updated Go version in example client module from 1.22.2 to 1.22.3.
  • Enhanced existing documentation to reflect updated download commands and Kubernetes version changes.

• Refactor

  • Modified internal gRPC configuration to conditionally append health check durations, enhancing efficiency.

[coderabbitai]

Warning

Rate Limit Exceeded

@kpango has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 1 minutes and 1 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 91475b4 and 6dee899.

Walkthrough

The repository has undergone extensive updates, primarily focused on enhancing security and reliability in file downloads across various Makefiles, with the addition of -fsSL flags to curl commands. This update also includes Kubernetes version bumps in GitHub templates and the introduction of new Dockerfiles and Rust components. Changes in GRPC configurations and dependency updates in Go modules are also notable, alongside modifications to improve logging and error handling in script executions.

Changes

Files	Change Summary
.github/ISSUE_TEMPLATE/*, .github/PULL_REQUEST_TEMPLATE.md	Updated Kubernetes version from v1.29.3 to v1.30.0.
Makefile, Makefile.d/*	Added -fsSL options to curl commands for enhanced security and reliability. Introduced changes in version file logging and handling in scripts.
docs/tutorial/*, docs/user-guides/deployment.md	Updated curl commands in Helm installation instructions to use -fsSL.
example/client/go.mod.default, hack/go.mod.default	Updated Go and Kubernetes related dependencies to newer versions.
internal/config/*, internal/net/grpc/*	Adjustments in GRPC configuration methods and test cases, including error handling and ticker management for health checks.
dockers/*, rust/*	Added new Dockerfiles and initiated Rust components with necessary configurations and source files.
Various .md and .mk files	General enhancements in logging, error display, and download command options across documentation and Makefiles.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[vdaas-ci]

[CHATOPS:HELP] ChatOps commands.

• 🙆‍♀️ /approve - approve
• 🍱 /format - format codes and add licenses
• ✅ /gen-test - generate test codes
• 🏷️ /label - add labels
• 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

[vdaas-ci]

[WARNING:INTCFG] Changes in interal/config may require you to change Helm charts. Please check.

[codecov]

Codecov Report

Attention: Patch coverage is 14.81994% with 615 lines in your changes are missing coverage. Please review.

Project coverage is 18.91%. Comparing base (9e091b1) to head (6dee899).
Report is 7 commits behind head on main.

Files	Patch %	Lines
apis/grpc/v1/payload/payload.pb.json.go	6.97%	320 Missing ⚠️
pkg/gateway/lb/handler/grpc/aggregation.go	0.00%	71 Missing ⚠️
pkg/gateway/lb/handler/grpc/handler.go	0.00%	57 Missing ⚠️
...is/grpc/v1/rpc/errdetails/error_details.pb.json.go	0.00%	56 Missing ⚠️
internal/net/grpc/option.go	0.00%	41 Missing ⚠️
apis/grpc/v1/payload/payload_vtproto.pb.go	0.00%	40 Missing ⚠️
internal/net/grpc/client.go	0.00%	26 Missing ⚠️
apis/grpc/v1/payload/payload.pb.go	0.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2491      +/-   ##
==========================================
- Coverage   18.94%   18.91%   -0.03%     
==========================================
  Files         563      565       +2     
  Lines       64707    65223     +516     
==========================================
+ Hits        12256    12338      +82     
- Misses      51656    52087     +431     
- Partials      795      798       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[cloudflare-workers-and-pages]

Deploying vald with    Cloudflare Pages

Latest commit:	6dee899
Status:	✅  Deploy successful!
Preview URL:	https://e0d86aef.vald.pages.dev
Branch Preview URL:	https://feature-gateway-lb-add-effic.vald.pages.dev

View logs

[coderabbitai]

Actionable comments posted: 1

Out of diff range and nitpick comments (14)

docs/tutorial/vald-agent-standalone-on-k8s.md (6)

Line range hint 12-12: Add alternate text to the image for accessibility.

- <img src="../../assets/docs/tutorial/vald-agent-standalone-on-k8s.svg">
+ <img src="../../assets/docs/tutorial/vald-agent-standalone-on-k8s.svg" alt="Architecture of Vald Agent Standalone on Kubernetes">

---

Line range hint 20-20: Correct the link fragment to match the actual section ID.

- 1. [Check and Satisfy the Requirements](#Requirements)
+ 1. [Check and Satisfy the Requirements](#requirements)

---

Line range hint 21-21: Correct the link fragment to match the actual section ID.

- 1. [Prepare Kubernetes Cluster](#Prepare-the-Kubernetes-Cluster)
+ 1. [Prepare Kubernetes Cluster](#prepare-the-kubernetes-cluster)

---

Line range hint 22-22: Correct the link fragment to match the actual section ID.

- 1. [Deploy Vald Agent Standalone on Kubernetes cluster](#Deploy-Vald-Agent-Standalone-on-Kubernetes-Cluster)
+ 1. [Deploy Vald Agent Standalone on Kubernetes cluster](#deploy-vald-agent-standalone-on-kubernetes-cluster)

---

Line range hint 23-23: Correct the link fragment to match the actual section ID.

- 1. [Run Example Code](#Run-Example-Code)
+ 1. [Run Example Code](#run-example-code)

---

Line range hint 24-24: Correct the link fragment to match the actual section ID.

- 1. [Cleanup](#Cleanup)
+ 1. [Cleanup](#cleanup)

docs/tutorial/vald-multicluster-on-k8s.md (1)

Line range hint 15-15: Add alternate text to the image for accessibility.

- <img src="../../assets/docs/tutorial/vald-multicluster-on-k8s.png">
+ <img src="../../assets/docs/tutorial/vald-multicluster-on-k8s.png" alt="Architecture of Multiple Vald Clusters using Vald Mirror Gateway">

docs/tutorial/get-started.md (6)

Line range hint 15-15: Add alternate text to the image for accessibility.

- <img src="../../assets/docs/tutorial/getstarted.svg" />
+ <img src="../../assets/docs/tutorial/getstarted.svg" alt="Architecture of Vald Deployment for Getting Started" />

---

Line range hint 19-19: Correct the link fragment to match the actual section ID.

- 1. [Check and Satisfy the Requirements](#Requirements)
+ 1. [Check and Satisfy the Requirements](#requirements)

---

Line range hint 20-20: Correct the link fragment to match the actual section ID.

- 1. [Prepare Kubernetes Cluster](#Prepare-the-Kubernetes-Cluster)
+ 1. [Prepare Kubernetes Cluster](#prepare-the-kubernetes-cluster)

---

Line range hint 21-21: Correct the link fragment to match the actual section ID.

- 1. [Deploy Vald on Kubernetes Cluster](#Deploy-Vald-on-Kubernetes-Cluster)
+ 1. [Deploy Vald on Kubernetes Cluster](#deploy-vald-on-kubernetes-cluster)

---

Line range hint 22-22: Correct the link fragment to match the actual section ID.

- 1. [Run Example Code](#Run-Example-Code)
+ 1. [Run Example Code](#run-example-code)

---

Line range hint 23-23: Correct the link fragment to match the actual section ID.

- 1. [Cleanup](#Cleanup)
+ 1. [Cleanup](#cleanup)

pkg/gateway/lb/handler/grpc/handler.go (1)

Line range hint 468-494: Ensure comprehensive unit tests for doSearch.

This function is central to the search functionality and interacts with multiple components. It's crucial to have extensive unit tests covering various scenarios and configurations. Would you like assistance in setting up these tests?

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 41c002c and 91475b4.

Files ignored due to path filters (25)

• apis/grpc/v1/agent/core/agent.pb.go is excluded by !**/*.pb.go, !**/*.pb.go
• apis/grpc/v1/agent/sidecar/sidecar.pb.go is excluded by !**/*.pb.go, !**/*.pb.go
• apis/grpc/v1/discoverer/discoverer.pb.go is excluded by !**/*.pb.go, !**/*.pb.go
• apis/grpc/v1/filter/egress/egress_filter.pb.go is excluded by !**/*.pb.go, !**/*.pb.go
• apis/grpc/v1/filter/ingress/ingress_filter.pb.go is excluded by !**/*.pb.go, !**/*.pb.go
• apis/grpc/v1/manager/index/index_manager.pb.go is excluded by !**/*.pb.go, !**/*.pb.go
• apis/grpc/v1/mirror/mirror.pb.go is excluded by !**/*.pb.go, !**/*.pb.go
• apis/grpc/v1/payload/payload.pb.go is excluded by !**/*.pb.go, !**/*.pb.go
• apis/grpc/v1/payload/payload.pb.json.go is excluded by !**/*.pb.json.go
• apis/grpc/v1/payload/payload_vtproto.pb.go is excluded by !**/*.pb.go, !**/*.pb.go
• apis/grpc/v1/rpc/errdetails/error_details.pb.go is excluded by !**/*.pb.go, !**/*.pb.go
• apis/grpc/v1/rpc/errdetails/error_details.pb.json.go is excluded by !**/*.pb.json.go
• apis/grpc/v1/vald/filter.pb.go is excluded by !**/*.pb.go, !**/*.pb.go
• apis/grpc/v1/vald/flush.pb.go is excluded by !**/*.pb.go, !**/*.pb.go
• apis/grpc/v1/vald/insert.pb.go is excluded by !**/*.pb.go, !**/*.pb.go
• apis/grpc/v1/vald/object.pb.go is excluded by !**/*.pb.go, !**/*.pb.go
• apis/grpc/v1/vald/remove.pb.go is excluded by !**/*.pb.go, !**/*.pb.go
• apis/grpc/v1/vald/search.pb.go is excluded by !**/*.pb.go, !**/*.pb.go
• apis/grpc/v1/vald/update.pb.go is excluded by !**/*.pb.go, !**/*.pb.go
• apis/grpc/v1/vald/upsert.pb.go is excluded by !**/*.pb.go, !**/*.pb.go
• example/client/go.mod is excluded by !**/*.mod
• example/client/go.sum is excluded by !**/*.sum
• go.mod is excluded by !**/*.mod
• go.sum is excluded by !**/*.sum
• rust/Cargo.lock is excluded by !**/*.lock

Files selected for processing (57)

• .gitfiles (8 hunks)
• .github/ISSUE_TEMPLATE/bug_report.md (1 hunks)
• .github/ISSUE_TEMPLATE/security_issue_report.md (1 hunks)
• .github/PULL_REQUEST_TEMPLATE.md (1 hunks)
• Makefile (1 hunks)
• Makefile.d/client.mk (1 hunks)
• Makefile.d/dependencies.mk (2 hunks)
• Makefile.d/functions.mk (1 hunks)
• Makefile.d/helm.mk (3 hunks)
• Makefile.d/k3d.mk (1 hunks)
• Makefile.d/k8s.mk (1 hunks)
• Makefile.d/kind.mk (1 hunks)
• Makefile.d/minikube.mk (1 hunks)
• Makefile.d/proto.mk (1 hunks)
• Makefile.d/tools.mk (3 hunks)
• apis/docs/v1/docs.md (1 hunks)
• apis/proto/v1/payload/payload.proto (2 hunks)
• apis/swagger/v1/vald/filter.swagger.json (1 hunks)
• apis/swagger/v1/vald/search.swagger.json (1 hunks)
• buf.gen.yaml (1 hunks)
• charts/vald-benchmark-operator/values.schema.json (1 hunks)
• charts/vald-helm-operator/crds/valdrelease.yaml (52 hunks)
• charts/vald/values.schema.json (195 hunks)
• charts/vald/values.yaml (6 hunks)
• dockers/tools/benchmark/job/Dockerfile (2 hunks)
• docs/tutorial/get-started.md (2 hunks)
• docs/tutorial/vald-agent-standalone-on-k8s.md (1 hunks)
• docs/tutorial/vald-multicluster-on-k8s.md (1 hunks)
• docs/user-guides/deployment.md (1 hunks)
• example/client/go.mod.default (1 hunks)
• hack/go.mod.default (2 hunks)
• internal/config/grpc.go (1 hunks)
• internal/config/grpc_test.go (1 hunks)
• internal/net/grpc/client.go (2 hunks)
• internal/net/grpc/option.go (6 hunks)
• internal/net/http/metrics/pprof.go (1 hunks)
• internal/net/http/metrics/pprof_test.go (1 hunks)
• internal/safety/safety.go (2 hunks)
• k8s/agent/ngt/configmap.yaml (3 hunks)
• k8s/discoverer/configmap.yaml (3 hunks)
• k8s/discoverer/deployment.yaml (1 hunks)
• k8s/gateway/gateway/lb/configmap.yaml (3 hunks)
• k8s/gateway/gateway/lb/deployment.yaml (1 hunks)
• k8s/manager/index/configmap.yaml (3 hunks)
• k8s/manager/index/deployment.yaml (1 hunks)
• k8s/operator/helm/crds/valdrelease.yaml (52 hunks)
• pkg/gateway/lb/handler/grpc/aggregation.go (22 hunks)
• pkg/gateway/lb/handler/grpc/handler.go (15 hunks)
• pkg/gateway/lb/handler/grpc/search_benchmark_test.go (2 hunks)
• rust/libs/proto/src/payload.v1.rs (1 hunks)
• versions/GOLANGCILINT_VERSION (1 hunks)
• versions/GO_VERSION (1 hunks)
• versions/HELM_VERSION (1 hunks)
• versions/JAEGER_OPERATOR_VERSION (1 hunks)
• versions/K3S_VERSION (1 hunks)
• versions/KUBECTL_VERSION (1 hunks)
• versions/PROMETHEUS_STACK_VERSION (1 hunks)

Files not processed due to max files limit (16)

• versions/REVIEWDOG_VERSION
• versions/actions/ACTIONS_CHECKOUT
• versions/actions/ACTIONS_DOWNLOAD_ARTIFACT
• versions/actions/ACTIONS_SETUP_GO
• versions/actions/ACTIONS_UPLOAD_ARTIFACT
• versions/actions/AZURE_SETUP_HELM
• versions/actions/CODECOV_CODECOV_ACTION
• versions/actions/DOCKER_SETUP_BUILDX_ACTION
• versions/actions/GITHUB_CODEQL_ACTION_ANALYZE
• versions/actions/GITHUB_CODEQL_ACTION_AUTOBUILD
• versions/actions/GITHUB_CODEQL_ACTION_INIT
• versions/actions/GITHUB_CODEQL_ACTION_UPLOAD_SARIF
• versions/actions/GITHUB_ISSUE_METRICS
• versions/actions/REVIEWDOG_ACTION_HADOLINT
• versions/actions/REVIEWDOG_ACTION_LANGUAGETOOL
• versions/actions/SHOGO82148_ACTIONS_UPLOAD_RELEASE_ASSET

Files not summarized due to errors (1)

• charts/vald/values.schema.json: Error: Message exceeds token limit

Files not reviewed due to errors (1)

• pkg/gateway/lb/handler/grpc/aggregation.go (no review received)

Files skipped from review due to trivial changes (1)

• dockers/tools/benchmark/job/Dockerfile

Files skipped from review as they are similar to previous changes (49)

• .gitfiles
• .github/ISSUE_TEMPLATE/bug_report.md
• .github/ISSUE_TEMPLATE/security_issue_report.md
• .github/PULL_REQUEST_TEMPLATE.md
• Makefile
• Makefile.d/client.mk
• Makefile.d/dependencies.mk
• Makefile.d/functions.mk
• Makefile.d/helm.mk
• Makefile.d/k3d.mk
• Makefile.d/k8s.mk
• Makefile.d/kind.mk
• Makefile.d/minikube.mk
• Makefile.d/proto.mk
• Makefile.d/tools.mk
• apis/proto/v1/payload/payload.proto
• apis/swagger/v1/vald/filter.swagger.json
• apis/swagger/v1/vald/search.swagger.json
• buf.gen.yaml
• charts/vald-benchmark-operator/values.schema.json
• charts/vald-helm-operator/crds/valdrelease.yaml
• charts/vald/values.yaml
• docs/user-guides/deployment.md
• example/client/go.mod.default
• hack/go.mod.default
• internal/config/grpc.go
• internal/config/grpc_test.go
• internal/net/grpc/client.go
• internal/net/grpc/option.go
• internal/net/http/metrics/pprof.go
• internal/net/http/metrics/pprof_test.go
• internal/safety/safety.go
• k8s/agent/ngt/configmap.yaml
• k8s/discoverer/configmap.yaml
• k8s/discoverer/deployment.yaml
• k8s/gateway/gateway/lb/configmap.yaml
• k8s/gateway/gateway/lb/deployment.yaml
• k8s/manager/index/configmap.yaml
• k8s/manager/index/deployment.yaml
• k8s/operator/helm/crds/valdrelease.yaml
• pkg/gateway/lb/handler/grpc/search_benchmark_test.go
• rust/libs/proto/src/payload.v1.rs
• versions/GOLANGCILINT_VERSION
• versions/GO_VERSION
• versions/HELM_VERSION
• versions/JAEGER_OPERATOR_VERSION
• versions/K3S_VERSION
• versions/KUBECTL_VERSION
• versions/PROMETHEUS_STACK_VERSION

Additional Context Used

Learnings (1)

pkg/gateway/lb/handler/grpc/aggregation.go (4)

User: kpango
PR: vdaas/vald#2491
File: pkg/gateway/lb/handler/grpc/aggregation.go:500-505
Timestamp: 2024-05-08T02:19:58.067Z
Learning: User: kpango
PR: vdaas/vald#2491
File: pkg/gateway/lb/handler/grpc/aggregation.go:500-505
Timestamp: 2024-05-08T02:17:42.078Z
Learning: The `GetNum()` method in the `valdStdAggr` struct should include a nil check to prevent runtime panics when called on a nil instance. This is a defensive programming practice to enhance the robustness of the code.

User: kpango
PR: vdaas/vald#2491
File: pkg/gateway/lb/handler/grpc/aggregation.go:500-505
Timestamp: 2024-05-08T02:17:42.078Z
Learning: The `GetNum()` method in the `valdStdAggr` struct should include a nil check to prevent runtime panics when called on a nil instance. This is a defensive programming practice to enhance the robustness of the code.

User: kpango
PR: vdaas/vald#2491
File: pkg/gateway/lb/handler/grpc/aggregation.go:689-690
Timestamp: 2024-05-07T03:58:42.344Z
Learning: The direct slicing approach (`result = result[:v.fnum]`) is preferred over using `slices.Clip` for its simplicity and performance in the context of limiting the number of results in aggregation methods in `pkg/gateway/lb/handler/grpc/aggregation.go`.

User: kpango
PR: vdaas/vald#2491
File: pkg/gateway/lb/handler/grpc/handler.go:306-316
Timestamp: 2024-05-07T04:33:44.775Z
Learning: User: kpango
PR: vdaas/vald#2491
File: pkg/gateway/lb/handler/grpc/handler.go:306-316
Timestamp: 2024-05-07T04:15:11.886Z
Learning: In this project, vtprotobuf is used, which provides enhanced methods for protobuf objects: CloneVT (object cloning), EqualVT (object comparison), SizeVT (returns object size), MarshalVT (faster version of proto.Marshal), and UnmarshalVT (faster version of proto.Unmarshal). These methods offer better performance than usual protobuf usage.

Additional comments not posted (4)

apis/docs/v1/docs.md (1)

798-809: The addition of the ratio field in the search configuration is well-documented. Ensure that all services using this configuration are updated to handle this new field.

pkg/gateway/lb/handler/grpc/handler.go (3)

453-467: Optimize the calculation logic in calculateNum.

---

453-467: Optimize the calculation logic in calculateNum.

---

Line range hint 327-437: Verify comprehensive error handling in SearchByID.

This function includes multiple layers of error handling and status updates. It's crucial to verify through unit tests that all potential error scenarios are covered effectively. Here's a script to check the coverage of error handling paths:

[kmrmt]

LGTM

[coderabbitai]

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 91475b4 and 9da530e.

Files selected for processing (2)

• Makefile.d/k3d.mk (1 hunks)
• Makefile.d/tools.mk (3 hunks)

Files skipped from review as they are similar to previous changes (2)

• Makefile.d/k3d.mk
• Makefile.d/tools.mk

[coderabbitai]

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 91475b4 and 5cae30b.

Files selected for processing (3)

• Makefile.d/k3d.mk (1 hunks)
• Makefile.d/kind.mk (1 hunks)
• Makefile.d/tools.mk (3 hunks)

Files skipped from review as they are similar to previous changes (3)

• Makefile.d/k3d.mk
• Makefile.d/kind.mk
• Makefile.d/tools.mk