Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update continuous benchmark docs #2485

Merged
merged 4 commits into from
Apr 25, 2024
Merged

Conversation

vankichi
Copy link
Contributor

@vankichi vankichi commented Apr 25, 2024

Description

SSIA

Related Issue

Versions

  • Go Version: 1.22.2
  • Rust Version: 1.77.2
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.29.3
  • NGT Version: 2.2

Checklist

Special notes for your reviewer

Summary by CodeRabbit

  • Documentation
    • Updated the continuous benchmark configuration guide, including detailed settings for job images, network configurations, and monitoring metrics with enhanced observability features.

Signed-off-by: vankichi <kyukawa315@gmail.com>
Copy link
Contributor

coderabbitai bot commented Apr 25, 2024

Warning

Rate Limit Exceeded

@vankichi has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 47 minutes and 19 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between 91d301d and e141a9d.

Walkthrough

The latest changes focus on enhancing the YAML configuration for benchmark jobs in the ValdBenchmarkOperatorRelease, encompassing detailed settings for job images, gRPC clients, and network configurations. The update also provides improved guidance on monitoring and observability using OTLP and tracing configurations.

Changes

File Path Change Summary
docs/performance/.../continuous-benchmark.md Restructured YAML configurations for benchmark jobs, defining detailed settings for job image, gRPC client, and monitoring guidance.

🐇🌟
In the meadow of code, under the sky so blue,
A little rabbit hopped, with updates anew.
YAML lines like rows of carrots lay,
Fresh and crisp, improving benchmarks today.
Hop, hop, hooray, let's celebrate the change,
With every commit, our project we enhance!
🌟🐇


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@vankichi vankichi requested review from a team, kmrmt and hlts2 and removed request for a team April 25, 2024 07:52
@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

This commit fixes the style issues introduced in e3ab1d2 according to the output
from Gofumpt and Prettier.

Details: #2485
Copy link

cloudflare-workers-and-pages bot commented Apr 25, 2024

Deploying vald with  Cloudflare Pages  Cloudflare Pages

Latest commit: e141a9d
Status: ✅  Deploy successful!
Preview URL: https://e2bd77f5.vald.pages.dev
Branch Preview URL: https://documentation-docs-update-co-k9ci.vald.pages.dev

View logs

docs/performance/continuous-benchmark.md Show resolved Hide resolved
docs/performance/continuous-benchmark.md Show resolved Hide resolved
docs/performance/continuous-benchmark.md Show resolved Hide resolved
docs/performance/continuous-benchmark.md Show resolved Hide resolved
docs/performance/continuous-benchmark.md Show resolved Hide resolved
docs/performance/continuous-benchmark.md Show resolved Hide resolved
docs/performance/continuous-benchmark.md Show resolved Hide resolved
docs/performance/continuous-benchmark.md Show resolved Hide resolved
docs/performance/continuous-benchmark.md Show resolved Hide resolved
docs/performance/continuous-benchmark.md Show resolved Hide resolved
docs/performance/continuous-benchmark.md Show resolved Hide resolved
docs/performance/continuous-benchmark.md Show resolved Hide resolved
docs/performance/continuous-benchmark.md Show resolved Hide resolved
docs/performance/continuous-benchmark.md Show resolved Hide resolved
docs/performance/continuous-benchmark.md Show resolved Hide resolved
docs/performance/continuous-benchmark.md Show resolved Hide resolved
docs/performance/continuous-benchmark.md Show resolved Hide resolved
docs/performance/continuous-benchmark.md Show resolved Hide resolved
docs/performance/continuous-benchmark.md Show resolved Hide resolved
docs/performance/continuous-benchmark.md Show resolved Hide resolved
kmrmt
kmrmt previously approved these changes Apr 25, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Out of diff range and nitpick comments (9)
docs/performance/continuous-benchmark.md (9)

Line range hint 5-5: Consider revising the phrase "get benchmark of Vald cluster in 24/7" to "continuously benchmark the Vald cluster".


Line range hint 10-10: Consider revising "Vald version up" to "upgrading Vald".


Line range hint 14-14: Consider revising "has following" to "has the following".


Line range hint 17-17: Consider revising "Executes CRUDs request" to "Executes CRUD requests".


Line range hint 32-32: Remove the space before the closing parenthesis in "HDF5 format )".

- Load dataset (valid only for HDF5 format )
+ Load dataset (valid only for HDF5 format)

Line range hint 37-37: Consider revising "Custom Resources(CRDs)" to "Custom Resources (CRDs)" to maintain proper spacing.


Line range hint 42-42: The sentence should start with an uppercase letter. Consider revising "is used for executing" to "Is used for executing".


Line range hint 64-64: Replace "can not" with "cannot" for grammatical correctness.

- Tune if can not getting the expected performance with default config.
+ Tune if cannot get the expected performance with default config.

Line range hint 65-65: Replace "can not" with "cannot" for grammatical correctness.

- Tune if can not getting the expected performance with default config.
+ Tune if cannot get the expected performance with default config.

docs/performance/continuous-benchmark.md Outdated Show resolved Hide resolved
@kmrmt kmrmt self-requested a review April 25, 2024 07:57
Signed-off-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
kmrmt
kmrmt previously approved these changes Apr 25, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Out of diff range and nitpick comments (4)
docs/performance/continuous-benchmark.md (4)

Line range hint 5-5: Consider rephrasing to maintain continuous tense consistency.

- Continuous Benchmark Tool allows you to get benchmark of Vald cluster in 24/7.
+ Continuous Benchmark Tool allows you to continuously benchmark the Vald cluster.

Line range hint 10-10: Clarify the phrase "Vald version up" for better understanding.

Consider rephrasing to "upgrading to a new version of Vald" for clarity.


Line range hint 17-17: The term "CRUDs request" might be confusing. Consider using "CRUD requests".

- Executes CRUDs request to the target Vald cluster
+ Executes CRUD requests to the target Vald cluster

Line range hint 32-32: Remove the unnecessary space before the closing parenthesis.

- Load dataset (valid only for HDF5 format )
+ Load dataset (valid only for HDF5 format)

Signed-off-by: vankichi <kyukawa315@gmail.com>
Copy link
Collaborator

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@kmrmt kmrmt merged commit 696bfd6 into main Apr 25, 2024
21 checks passed
@kmrmt kmrmt deleted the documentation/docs/update-con-bench-docs branch April 25, 2024 08:10
vdaas-ci pushed a commit that referenced this pull request Apr 25, 2024
* 📝 Update continous benchmark docs

Signed-off-by: vankichi <kyukawa315@gmail.com>

* style: format code with Gofumpt and Prettier

This commit fixes the style issues introduced in e3ab1d2 according to the output
from Gofumpt and Prettier.

Details: #2485

* Update docs/performance/continuous-benchmark.md

Signed-off-by: Kiichiro YUKAWA <kyukawa315@gmail.com>

* 📝 Fix

Signed-off-by: vankichi <kyukawa315@gmail.com>

---------

Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
vankichi added a commit that referenced this pull request Apr 25, 2024
* 📝 Update continous benchmark docs



* style: format code with Gofumpt and Prettier

This commit fixes the style issues introduced in e3ab1d2 according to the output
from Gofumpt and Prettier.

Details: #2485

* Update docs/performance/continuous-benchmark.md



* 📝 Fix



---------

Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
kpango added a commit that referenced this pull request May 8, 2024
fix: git add chart directory for release (#2356) (#2357)
[patch] release v1.7.11 (#2358)
:bookmark: :robot: Release v1.7.11 (#2360)
Change docker scan timeout longer (#2363) (#2364)
refactor code using golangci-lint (#2362) (#2365)
Create SECURITY.md (#2367) (#2368)
add commit hash build image (#2359) (#2371)
update docker build target platform selection rules (#2370) (#2374)
Make agent export index metrics to Pod k8s resource (#2319) (#2372)
backport ci deps others (#2386)
Update workflow to release readreplica chart (#2383) (#2387)
:green_heart: :recycle: Add Con-Bench helm chart to the Vald charts (#2388) (#2389)
Delete unnecessary code for mirror (#2366) (#2391)
change JP logo to EN logo (#2369) (#2392)
Add rotate-all option to rotator (#2305) (#2393)
fix: build error of internal kvs test (#2396) (#2398)
Resolve kvs already closed before last saving (#2390) (#2394)
:robot: Update license headers / Format Go codes and YAML files (#2397) (#2400)
create continous benchmark doc (#2352) (#2395)
fix: disable protobuf dispatch for client (#2401) (#2403)
update deps (#2404) (#2405)
[patch] release v1.7.12 (#2406)
:bookmark: :robot: Release v1.7.12 (#2408)
:pencil: Fix typo of file name (#2413) (#2415)
Fix agent-faiss build failed (#2418) (#2419)
Add tests for index information export (#2412) (#2414)
Fix the logic to determine docker image (#2410) (#2420)
Update build rule for nightly image (#2421) (#2422)
Fix output settings to determine-docker-image-tag action and release branch build tag name (#2423) (#2425)
Add `index-operator` template implementation (#2375) (#2424)
fix: typo of execution rule (#2426) (#2427)
Backport Flush API (#2434)
update deps & add validation for Flush API when agent is Read Only (#2433) (#2436)
docs: add hrichiksite as a contributor for doc (#2441) (#2442)
fix: bugfix version update for docker build (#2445) (#2446)
Fix index job logic to pass DNS A record (#2438) (#2448)
Added snapshot timestamp annotations to read replica agent (#2428) (#2443)
Fix operator-sdk version (#2447) (#2449)
add file name lint (#2417) (#2450)
fix: add extra option for ci-container build (#2451) (#2452)
Add base of benchmark operator dashboard (#2430) (#2453)
Implement index operator logic for read replica rotation (#2444) (#2456)
add inner product distance type for ngt (#2454) (#2458)
Fix e2e for read replica and add e2e for index operator (#2455) (#2459)
Add unit tests for index operator (#2460) (#2461)
Bugfix recreate benchmark job when operator reboot (#2463) (#2464)
Refactor k8s types (#2462) (#2465)
:robot: Automatically update PULL_REQUEST_TEMPLATE and ISSUE_TEMPLATE (#2457) (#2469)
Fix workflow trigger for backport pr creation (#2471) (#2472)
Automatically add backport main label for release-pr (#2473) (#2475)
update deps (#2468) (#2476)
Implement client metrics interceptor for continuous benchmark job (#2477) (#2480)
:chart_with_upwards_trend: Add client metrics panels for continuous benchmark job (#2481) (#2483)
Update continuous benchmark docs (#2485) (#2486)

Signed-off-by: kpango <kpango@vdaas.org>
kpango added a commit that referenced this pull request May 8, 2024
fix: git add chart directory for release (#2356) (#2357)
[patch] release v1.7.11 (#2358)
:bookmark: :robot: Release v1.7.11 (#2360)
Change docker scan timeout longer (#2363) (#2364)
refactor code using golangci-lint (#2362) (#2365)
Create SECURITY.md (#2367) (#2368)
add commit hash build image (#2359) (#2371)
update docker build target platform selection rules (#2370) (#2374)
Make agent export index metrics to Pod k8s resource (#2319) (#2372)
backport ci deps others (#2386)
Update workflow to release readreplica chart (#2383) (#2387)
:green_heart: :recycle: Add Con-Bench helm chart to the Vald charts (#2388) (#2389)
Delete unnecessary code for mirror (#2366) (#2391)
change JP logo to EN logo (#2369) (#2392)
Add rotate-all option to rotator (#2305) (#2393)
fix: build error of internal kvs test (#2396) (#2398)
Resolve kvs already closed before last saving (#2390) (#2394)
:robot: Update license headers / Format Go codes and YAML files (#2397) (#2400)
create continous benchmark doc (#2352) (#2395)
fix: disable protobuf dispatch for client (#2401) (#2403)
update deps (#2404) (#2405)
[patch] release v1.7.12 (#2406)
:bookmark: :robot: Release v1.7.12 (#2408)
:pencil: Fix typo of file name (#2413) (#2415)
Fix agent-faiss build failed (#2418) (#2419)
Add tests for index information export (#2412) (#2414)
Fix the logic to determine docker image (#2410) (#2420)
Update build rule for nightly image (#2421) (#2422)
Fix output settings to determine-docker-image-tag action and release branch build tag name (#2423) (#2425)
Add `index-operator` template implementation (#2375) (#2424)
fix: typo of execution rule (#2426) (#2427)
Backport Flush API (#2434)
update deps & add validation for Flush API when agent is Read Only (#2433) (#2436)
docs: add hrichiksite as a contributor for doc (#2441) (#2442)
fix: bugfix version update for docker build (#2445) (#2446)
Fix index job logic to pass DNS A record (#2438) (#2448)
Added snapshot timestamp annotations to read replica agent (#2428) (#2443)
Fix operator-sdk version (#2447) (#2449)
add file name lint (#2417) (#2450)
fix: add extra option for ci-container build (#2451) (#2452)
Add base of benchmark operator dashboard (#2430) (#2453)
Implement index operator logic for read replica rotation (#2444) (#2456)
add inner product distance type for ngt (#2454) (#2458)
Fix e2e for read replica and add e2e for index operator (#2455) (#2459)
Add unit tests for index operator (#2460) (#2461)
Bugfix recreate benchmark job when operator reboot (#2463) (#2464)
Refactor k8s types (#2462) (#2465)
:robot: Automatically update PULL_REQUEST_TEMPLATE and ISSUE_TEMPLATE (#2457) (#2469)
Fix workflow trigger for backport pr creation (#2471) (#2472)
Automatically add backport main label for release-pr (#2473) (#2475)
update deps (#2468) (#2476)
Implement client metrics interceptor for continuous benchmark job (#2477) (#2480)
:chart_with_upwards_trend: Add client metrics panels for continuous benchmark job (#2481) (#2483)
Update continuous benchmark docs (#2485) (#2486)

Signed-off-by: kpango <kpango@vdaas.org>
kpango added a commit that referenced this pull request May 8, 2024
fix: git add chart directory for release (#2356) (#2357)
[patch] release v1.7.11 (#2358)
:bookmark: :robot: Release v1.7.11 (#2360)
Change docker scan timeout longer (#2363) (#2364)
refactor code using golangci-lint (#2362) (#2365)
Create SECURITY.md (#2367) (#2368)
add commit hash build image (#2359) (#2371)
update docker build target platform selection rules (#2370) (#2374)
Make agent export index metrics to Pod k8s resource (#2319) (#2372)
backport ci deps others (#2386)
Update workflow to release readreplica chart (#2383) (#2387)
:green_heart: :recycle: Add Con-Bench helm chart to the Vald charts (#2388) (#2389)
Delete unnecessary code for mirror (#2366) (#2391)
change JP logo to EN logo (#2369) (#2392)
Add rotate-all option to rotator (#2305) (#2393)
fix: build error of internal kvs test (#2396) (#2398)
Resolve kvs already closed before last saving (#2390) (#2394)
:robot: Update license headers / Format Go codes and YAML files (#2397) (#2400)
create continous benchmark doc (#2352) (#2395)
fix: disable protobuf dispatch for client (#2401) (#2403)
update deps (#2404) (#2405)
[patch] release v1.7.12 (#2406)
:bookmark: :robot: Release v1.7.12 (#2408)
:pencil: Fix typo of file name (#2413) (#2415)
Fix agent-faiss build failed (#2418) (#2419)
Add tests for index information export (#2412) (#2414)
Fix the logic to determine docker image (#2410) (#2420)
Update build rule for nightly image (#2421) (#2422)
Fix output settings to determine-docker-image-tag action and release branch build tag name (#2423) (#2425)
Add `index-operator` template implementation (#2375) (#2424)
fix: typo of execution rule (#2426) (#2427)
Backport Flush API (#2434)
update deps & add validation for Flush API when agent is Read Only (#2433) (#2436)
docs: add hrichiksite as a contributor for doc (#2441) (#2442)
fix: bugfix version update for docker build (#2445) (#2446)
Fix index job logic to pass DNS A record (#2438) (#2448)
Added snapshot timestamp annotations to read replica agent (#2428) (#2443)
Fix operator-sdk version (#2447) (#2449)
add file name lint (#2417) (#2450)
fix: add extra option for ci-container build (#2451) (#2452)
Add base of benchmark operator dashboard (#2430) (#2453)
Implement index operator logic for read replica rotation (#2444) (#2456)
add inner product distance type for ngt (#2454) (#2458)
Fix e2e for read replica and add e2e for index operator (#2455) (#2459)
Add unit tests for index operator (#2460) (#2461)
Bugfix recreate benchmark job when operator reboot (#2463) (#2464)
Refactor k8s types (#2462) (#2465)
:robot: Automatically update PULL_REQUEST_TEMPLATE and ISSUE_TEMPLATE (#2457) (#2469)
Fix workflow trigger for backport pr creation (#2471) (#2472)
Automatically add backport main label for release-pr (#2473) (#2475)
update deps (#2468) (#2476)
Implement client metrics interceptor for continuous benchmark job (#2477) (#2480)
:chart_with_upwards_trend: Add client metrics panels for continuous benchmark job (#2481) (#2483)
Update continuous benchmark docs (#2485) (#2486)

Signed-off-by: kpango <kpango@vdaas.org>
hlts2 added a commit that referenced this pull request May 8, 2024
* fix: git add chart directory for release (#2356)

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* 🔖 🤖 Release v1.7.11 (#2360) (#2361)

* 🔖 🤖 Release v1.7.11



* style: format code with Gofumpt and Prettier

This commit fixes the style issues introduced in 578746e according to the output
from Gofumpt and Prettier.

Details: #2360

---------

Signed-off-by: Vdaas CI <vald@vdaas.org>
Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>

* Change docker scan timeout longer (#2363)

* refactor code using golangci-lint (#2362)

Signed-off-by: kpango <kpango@vdaas.org>

* Create SECURITY.md (#2367)

* Create SECURITY.md

Signed-off-by: Yusuke Kato <kpango@vdaas.org>

* style: format code with Gofumpt and Prettier

This commit fixes the style issues introduced in e8609b0 according to the output
from Gofumpt and Prettier.

Details: #2367

---------

Signed-off-by: Yusuke Kato <kpango@vdaas.org>
Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>

* add commit hash build image (#2359)

Signed-off-by: kpango <kpango@vdaas.org>

* Make agent export index metrics to Pod k8s resource (#2319)

* Add config

* Add clusterRole and serviceAccount for agent

* Add more metrics

* Format

* Add export index info duration configuration

* Refactor internal/k8s

* Move apply function to internal/k8s

* Add more config

* Remove unused import and variable

* Use vald errors

* Add pod name and pod namespace to hack e2e agent

* Apply tagalign

* Revert unnecesarry specification of PodName

* Enable export index info to Kubernetes in agent templates only when the config is enabled

* Fix agent clusterrole name

* Update key name

* Update comments

* Add index count as export metrics

* Ignore gomnd

* Add index count entry to exportMetricsOnCreateIndex function

* Update values schema

* Fix formatter job

* Remove unused defines

* update docker build target platform selection rules (#2370)

Signed-off-by: kpango <kpango@vdaas.org>
Co-authored-by: Yusuke Kadowaki <yusuke.kadowaki.1231@gmail.com>

* improve Backport Pull Request Title & Description Quality (#2373)

Signed-off-by: kpango <kpango@vdaas.org>
Co-authored-by: Kosuke Morimoto <ksk@vdaas.org>

* Update workflow to release readreplica chart (#2383)

* improve Backport Pull Request Title & Description Quality (#2373)

Signed-off-by: kpango <kpango@vdaas.org>
Co-authored-by: Kosuke Morimoto <ksk@vdaas.org>

* Add readreplica chart release

* update k8s/readreplica

* style: format code with Gofumpt and Prettier

This commit fixes the style issues introduced in 70f1dad according to the output
from Gofumpt and Prettier.

Details: #2383

* [bugfix] fix backport github value bypass failure (#2378)

Signed-off-by: kpango <kpango@vdaas.org>

* Revert backport.yaml

---------

Signed-off-by: kpango <kpango@vdaas.org>
Co-authored-by: Yusuke Kato <kpango@vdaas.org>
Co-authored-by: Kosuke Morimoto <ksk@vdaas.org>
Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>

* 💚 ♻️ Add Con-Bench helm chart to the Vald charts (#2388)

Signed-off-by: vankichi <kyukawa315@gmail.com>

* Delete unnecessary code for mirror (#2366)

* fix: delete unnecessary code for mirror

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* fix: make deps/install and format

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* improve Backport Pull Request Title & Description Quality (#2373)

Signed-off-by: kpango <kpango@vdaas.org>
Co-authored-by: Kosuke Morimoto <ksk@vdaas.org>

* fix: naming of variable

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

---------

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: kpango <kpango@vdaas.org>
Co-authored-by: Yusuke Kato <kpango@vdaas.org>
Co-authored-by: Kosuke Morimoto <ksk@vdaas.org>

* change JP logo to EN logo (#2369)

Signed-off-by: kpango <kpango@vdaas.org>
Co-authored-by: taisuou <pqrct237@gmail.com>

* Add rotate-all option to rotator (#2305)

* Add rotate-all option to rotator

* Fix linter warnings

* Make it possible to choose multiple rotation target

* Add tests for parseReplicaID

* Add tests for parseReplicaID

* Hide testify in internal

* style: format code with Gofumpt and Prettier

This commit fixes the style issues introduced in dd84674 according to the output
from Gofumpt and Prettier.

Details: #2305

* Apply format

* Lint

* Lint

---------

Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
Co-authored-by: Yusuke Kato <kpango@vdaas.org>

* Resolve kvs already closed before last saving (#2390)

Signed-off-by: kpango <kpango@vdaas.org>

* create continous benchmark doc (#2352)

* improve Backport Pull Request Title & Description Quality (#2373)

Signed-off-by: kpango <kpango@vdaas.org>
Co-authored-by: Kosuke Morimoto <ksk@vdaas.org>

* 📝 create continous benchmark doc

Signed-off-by: vankichi <kyukawa315@gmail.com>

* style: format code with Gofumpt and Prettier

This commit fixes the style issues introduced in ace001a according to the output
from Gofumpt and Prettier.

Details: #2352

* ♻️ rafactor default params

Signed-off-by: vankichi <kyukawa315@gmail.com>

* style: format code with Gofumpt and Prettier

This commit fixes the style issues introduced in 9880dfc according to the output
from Gofumpt and Prettier.

Details: #2352

* ♻️ Fix format

Signed-off-by: vankichi <kyukawa315@gmail.com>

* Revert "improve Backport Pull Request Title & Description Quality (#2373)"

This reverts commit 4246def.

* ♻️ remove dimension from con-bench

Signed-off-by: vankichi <kyukawa315@gmail.com>

* 📝 Add sample benchmark manifest

Signed-off-by: vankichi <kyukawa315@gmail.com>

* Update docs/performance/continuos-benchmatk.md

Co-authored-by: Yusuke Kato <kpango@vdaas.org>
Signed-off-by: Kiichiro YUKAWA <kyukawa315@gmail.com>

* Update docs/performance/continuos-benchmatk.md

Co-authored-by: Hiroto Funakoshi <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: Kiichiro YUKAWA <kyukawa315@gmail.com>

---------

Signed-off-by: kpango <kpango@vdaas.org>
Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
Co-authored-by: Yusuke Kato <kpango@vdaas.org>
Co-authored-by: Kosuke Morimoto <ksk@vdaas.org>
Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
Co-authored-by: Hiroto Funakoshi <hiroto.funakoshi.hiroto@gmail.com>

* fix: build error of internal kvs test (#2396)

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* 🤖 Update license headers / Format Go codes and YAML files (#2397)

Signed-off-by: Vdaas CI <vald@vdaas.org>
Co-authored-by: Hiroto Funakoshi <hiroto.funakoshi.hiroto@gmail.com>

* fix: disable protobuf dispatch for client (#2401)

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* update deps (#2404)

Signed-off-by: kpango <kpango@vdaas.org>

* 🔖 🤖 Release v1.7.12 (#2408) (#2409)

* 🔖 🤖 Release v1.7.12



* style: format code with Gofumpt and Prettier

This commit fixes the style issues introduced in 5bd8605 according to the output
from Gofumpt and Prettier.

Details: #2408

---------

Signed-off-by: Vdaas CI <vald@vdaas.org>
Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>

* Add tests for index information export (#2412)

* Add tests for index information export

* Add comments

* 📝 Fix typo of file name (#2413)

Signed-off-by: vankichi <kyukawa315@gmail.com>

* Fix agent-faiss build failed (#2418)

* 🐳 Fix agent-faiss build failed

Signed-off-by: vankichi <kyukawa315@gmail.com>

* 🐳 Fix COPY binary

Signed-off-by: vankichi <kyukawa315@gmail.com>

* 🐳 Change COPY binary (use ld-linux-x86-64)

Signed-off-by: vankichi <kyukawa315@gmail.com>

---------

Signed-off-by: vankichi <kyukawa315@gmail.com>

* Fix the logic to determine docker image (#2410)

* fix: update action to get tag list

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* fix: refactor sub command execution

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* fix: use tag list in detect ci container workflow

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* fix: name for detected result

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* fix: invalid variable bug

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* fix: execution error and invalid variable

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* fix: deleted unnecessary comment

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* fix: deleted unnecessary parameters

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* fix: use new determine tag logic in the docker build workflow

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* fix: bugfix extra tags handling and small refactor

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* fix: build tag rule or release branch based on tag list

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* fix: typo

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* fix: indent

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* fix: refactor syntax

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* fix: typo and invalid option error

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* fix: use helm extra option

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* fix: add comment for tag management

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* fix: unsetbug of helm extra option

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* fix: build target condition

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

---------

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* Update build rule for nightly image (#2421)

* fix: update build rule for nightly

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* fix: indent and deleted unnecessary tag

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* fix: update tag name when tag is unknown

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* fix: add secondary tags for build performance

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* fix: argument order

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

---------

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* Add `index-operator` template implementation (#2375)

* improve Backport Pull Request Title & Description Quality (#2373)

Signed-off-by: kpango <kpango@vdaas.org>
Co-authored-by: Kosuke Morimoto <ksk@vdaas.org>

* [bugfix] fix backport github value bypass failure (#2378)

Signed-off-by: kpango <kpango@vdaas.org>

* [bugfix] fix backport github value bypass failure (#2381)

Signed-off-by: kpango <kpango@vdaas.org>

* Add index operator boilerplate

* Add k8s controller

* Add pod and job controllers

* Add annotations in the pod reconciler

* Update auto indexing service configurations

* Update WithOnReconcileFunc signature to include context

* Refactor debugging log

* Refactor reconcile funcs

* add nolint

* remove unused parameters

* lint

* Add dockerfile and build ci

* remove params

* Add index-operator image build command to Makefile

* Add index operator k8s templates

* Update helm schema

* Update readme

* Add internal/k8s as a trigger for images that depends on controller-runtime

* remove comment

* Update pkg/index/operator/service/operator.go

Co-authored-by: Yusuke Kato <kpango@vdaas.org>
Signed-off-by: Yusuke Kadowaki <yusuke.kadowaki.1231@gmail.com>

* Update pkg/index/operator/service/operator.go

Co-authored-by: Yusuke Kato <kpango@vdaas.org>
Signed-off-by: Yusuke Kadowaki <yusuke.kadowaki.1231@gmail.com>

* Refactor

* Add build commands

* Refactor

Co-authored-by: Yusuke Kato <kpango@vdaas.org>

---------

Signed-off-by: kpango <kpango@vdaas.org>
Signed-off-by: Yusuke Kadowaki <yusuke.kadowaki.1231@gmail.com>
Co-authored-by: Yusuke Kato <kpango@vdaas.org>
Co-authored-by: Kosuke Morimoto <ksk@vdaas.org>

* Fix output settings to determine-docker-image-tag action and release branch build tag name (#2423)

* fix: add outut settings for action

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* fix: tag name for release branch build

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* fix: refactor

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

---------

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* fix: typo of execution rule (#2426)

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* Add flush API for deleting all vectors (#2273)

* add flush api

Signed-off-by: aknishid <koco155@gmail.com>

* added flush api

* fix typo

* fix pb.go & fix conflict

Signed-off-by: aknishid <koco155@gmail.com>

* add flush api

* add handler Flush

Signed-off-by: aknishid <koco155@gmail.com>

* add vald.Client flush

* fix filter gateway

Signed-off-by: aknishid <koco155@gmail.com>

* fix handler cnts

Signed-off-by: aknishid <koco155@gmail.com>

* delete unused var

Signed-off-by: aknishid <koco155@gmail.com>

* add author

Signed-off-by: Yamada Takuya <takuya.ymd@gmail.com>

* fix error

Signed-off-by: aknishid <koco155@gmail.com>

* fix flush.go & ngt.go

Signed-off-by: aknishid <koco155@gmail.com>

* add flush to example

Signed-off-by: aknishid <koco155@gmail.com>

* fix gateway lb

Signed-off-by: aknishid <koco155@gmail.com>

* update flush proto

Signed-off-by: aknishid <koco155@gmail.com>

* fix docs api README.md

Signed-off-by: aknishid <koco155@gmail.com>

* Fix flush ctx

Signed-off-by: aknishid <koco155@gmail.com>

* update docs & comment

Signed-off-by: aknishid <koco155@gmail.com>

* after make format

Signed-off-by: aknishid <koco155@gmail.com>

* add e2e

Signed-off-by: aknishid <koco155@gmail.com>

* update example & tutorial

Signed-off-by: aknishid <koco155@gmail.com>

* Update internal/errors/ngt.go

Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>

* fix review

Signed-off-by: aknishid <koco155@gmail.com>

* modify status.md

Signed-off-by: aknishid <koco155@gmail.com>

* add error handling

Signed-off-by: aknishid <koco155@gmail.com>

* update proto

Signed-off-by: aknishid <koco155@gmail.com>

* fix doc

Signed-off-by: aknishid <koco155@gmail.com>

* ♻️ Fix proto

Signed-off-by: vankichi <kyukawa315@gmail.com>

* use atomic bool

Signed-off-by: aknishid <koco155@gmail.com>

* fix proto

Signed-off-by: aknishid <koco155@gmail.com>

* update proto

Signed-off-by: aknishid <koco155@gmail.com>

* fix gateway error

Signed-off-by: aknishid <koco155@gmail.com>

* ✅ 🚧 Avoid e2e failing due to unimplemented handler and Add unimplmented handler method for the future

Signed-off-by: vankichi <kyukawa315@gmail.com>

* Update apis/proto/v1/payload/payload.proto

Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
Signed-off-by: aknishid <38955080+aknishid@users.noreply.github.com>

---------

Signed-off-by: aknishid <koco155@gmail.com>
Signed-off-by: Yamada Takuya <takuya.ymd@gmail.com>
Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: aknishid <38955080+aknishid@users.noreply.github.com>
Co-authored-by: takuyaymd <takuya.ymd@gmail.com>
Co-authored-by: takuyyam <takuyyam@yahoo-corp.jp>
Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
Co-authored-by: Yusuke Kato <kpango@vdaas.org>

* docs: add aknishid as a contributor for code, and maintenance (#2431)

* docs: update README.md [skip ci]

* docs: update .all-contributorsrc [skip ci]

* style: format code with Gofumpt and Prettier

This commit fixes the style issues introduced in abc4c52 according to the output
from Gofumpt and Prettier.

Details: #2431

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Co-authored-by: Yusuke Kato <kpango@vdaas.org>
Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>

* update deps & add validation for Flush API when agent is Read Only (#2433)

Signed-off-by: kpango <kpango@vdaas.org>

* Update README.md (grammer) (#2440)

Signed-off-by: Hrichik Mazumder <57860916+hrichiksite@users.noreply.github.com>

* docs: add hrichiksite as a contributor for doc (#2441)

* docs: update README.md [skip ci]

* docs: update .all-contributorsrc [skip ci]

* style: format code with Gofumpt and Prettier

This commit fixes the style issues introduced in b8054d9 according to the output
from Gofumpt and Prettier.

Details: #2441

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Co-authored-by: Yusuke Kato <kpango@vdaas.org>
Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>

* Added snapshot timestamp annotations to read replica agent (#2428)

* Add lastTimeRotateReplicaTimestampAnnotationsKey constant

* Use ptr package

* Update annotations in ngt.go and rotator.go

* Add labels to Pod struct and update annotations handling***

***Introduce vald package for k8s related constants***

***Implement rotateIfNeeded function to check if read replica rotation is needed

* Refactor

* set sample log level debug

* Use k8s timestamp

* Refactor

* Format

* Add MatchingLabels method to ValdK8sClientMock

* Format

* Fix test

* style: format code with Gofumpt and Prettier

This commit fixes the style issues introduced in 39b66fa according to the output
from Gofumpt and Prettier.

Details: #2428

* Rename constants

Co-authored-by: Yusuke Kato <kpango@vdaas.org>

* Refactor rotateIfNeeded function to use label selector for listing deployments

* style: format code with Gofumpt and Prettier

This commit fixes the style issues introduced in 6ace761 according to the output
from Gofumpt and Prettier.

Details: #2428

* FIx deepsource

* Revert

---------

Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
Co-authored-by: Yusuke Kato <kpango@vdaas.org>

* fix: bugfix version update for docker build (#2445)

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* Fix index job logic to pass DNS A record (#2438)

* fix: choose user given target address in priority

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* fix: deleted unnecessary code

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* fix: add logic to connect the user given target addresses

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* fix: add info log about new connection target

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* fix: indent of configuration data

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* fix: indent bug

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* fix: deepsource warning

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

---------

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* Fix operator-sdk version (#2447)

* fix: down grade operator version

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* fix: upgrade operator-sdk version

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* fix: operator-sdk version

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

---------

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* add file name lint (#2417)

Signed-off-by: kpango <kpango@vdaas.org>

* fix: add extra option for ci-container build (#2451)

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* Add base of benchmark operator dashboard (#2430)

* 📈 Add base of benchmark operator dashboard

Signed-off-by: vankichi <kyukawa315@gmail.com>

* 💚 Fix build benchmark images trigger

Signed-off-by: vankichi <kyukawa315@gmail.com>

* 💚 Add info tag for info metrics

Signed-off-by: vankichi <kyukawa315@gmail.com>

* 📈 showing job image and tags

Signed-off-by: vankichi <kyukawa315@gmail.com>

* 📈 add bench job status

Signed-off-by: vankichi <kyukawa315@gmail.com>

* ♻️ Update dashboard and rename

Signed-off-by: vankichi <kyukawa315@gmail.com>

* ♻️ Fix

Signed-off-by: vankichi <kyukawa315@gmail.com>

* Update internal/observability/metrics/tools/benchmark/benchmark.go

Co-authored-by: Hiroto Funakoshi <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: Kiichiro YUKAWA <kyukawa315@gmail.com>

---------

Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
Co-authored-by: Hiroto Funakoshi <hiroto.funakoshi.hiroto@gmail.com>

* Implement index operator logic for read replica rotation (#2444)

* Remove job reconciler

* Add leader election to index operator

* Add roles for leader election

* Add operator logic for rotation

* style: format code with Gofumpt and Prettier

This commit fixes the style issues introduced in 844cca1 according to the output
from Gofumpt and Prettier.

Details: #2444

* Remove unnecesary change

* Fix build

* nits

* Refactor

* Fix clusterrole

* Move to podv2

* Add job concurrency check

* Refactor

* Refactor

* Fix heavy copying

* Update helm schema

* Fix package doc

* Remove unused code and refactor For() method

* Update target read replica ID in config

* Update internal/k8s/podv2/option.go

Co-authored-by: Hiroto Funakoshi <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: Yusuke Kadowaki <yusuke.kadowaki.1231@gmail.com>

* Refactor

* rename podv2 to v2/pod

* Add client DI

* Fix envkey helper

* Set namespace from values.yaml

* Use annotations to specify the id

* Update schema

* Update sample

* Update values

* Update schema

* Fix spelling

* Fix package name

* Fix read replica e2e

* Add job templates for rotation, creation, saving, and correction

* Update config.go to decode k8s object

* Update sample.yaml for index operator

* Use job template from cfg

* style: format code with Gofumpt and Prettier

This commit fixes the style issues introduced in 584d1f0 according to the output
from Gofumpt and Prettier.

Details: #2444

* Fix tagalign

* Fix config test

* Fix config test

* Disable read replica e2e for now

---------

Signed-off-by: Yusuke Kadowaki <yusuke.kadowaki.1231@gmail.com>
Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
Co-authored-by: Hiroto Funakoshi <hiroto.funakoshi.hiroto@gmail.com>

* add inner product distance type for ngt (#2454)

Signed-off-by: kpango <kpango@vdaas.org>

* Fix e2e for read replica and add e2e for index operator (#2455)

* Fix read replica e2e

* Update default image list in action.yaml

* style: format code with Gofumpt and Prettier

This commit fixes the style issues introduced in 6cdac9f according to the output
from Gofumpt and Prettier.

Details: #2455

---------

Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>

* Add unit tests for index operator (#2460)

* Add prototype tests

* Refactor

* Fix not to use kubeconfig

* 🤖 Automatically update PULL_REQUEST_TEMPLATE and ISSUE_TEMPLATE (#2457)

Signed-off-by: Vdaas CI <vald@vdaas.org>
Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>

* Bugfix recreate benchmark job when operator reboot (#2463)

* 🐛 Fix recreate benchmark job already runnnig when operator rebooted

Signed-off-by: vankichi <kyukawa315@gmail.com>

* 🐛 Fix benchmarkJobReconcile status handling

Signed-off-by: vankichi <kyukawa315@gmail.com>

* ✅ Fix test

Signed-off-by: vankichi <kyukawa315@gmail.com>

* ♻️ Update k8s dir

Signed-off-by: vankichi <kyukawa315@gmail.com>

* ♻️ Fix

Signed-off-by: vankichi <kyukawa315@gmail.com>

---------

Signed-off-by: vankichi <kyukawa315@gmail.com>

* Refactor k8s types (#2462)

* Refactor types

* Refactor hdf5_test.go

* Format

* Refactor

* add extra flags for NGT build phase (#2467)

* Fix workflow trigger for backport pr creation (#2471)

* Automatically add backport main label for release-pr (#2473)

* feat: automatically add backport main label for release-pr

Signed-off-by: Hiroto Funakoshi <hiroto.funakoshi.hiroto@gmail.com>

* fix: deleted unnecessary quotation

Signed-off-by: Hiroto Funakoshi <hiroto.funakoshi.hiroto@gmail.com>

---------

Signed-off-by: Hiroto Funakoshi <hiroto.funakoshi.hiroto@gmail.com>

* update deps (#2468)

* update deps

Signed-off-by: kpango <kpango@vdaas.org>

* fix server_test.go due to the grpc-go updates

Signed-off-by: kpango <kpango@vdaas.org>

---------

Signed-off-by: kpango <kpango@vdaas.org>

* Update README.md (#2479)

Signed-off-by: Yusuke Kato <kpango@vdaas.org>

* Implement client metrics interceptor for continuous benchmark job (#2477)

* ♻️ Mount benchmark-operator-config to vald-benchmark-job Pod

Signed-off-by: vankichi <kyukawa315@gmail.com>

* 📈 add framework for send gRPC client metrics

Signed-off-by: vankichi <kyukawa315@gmail.com>

* style: format code with Gofumpt and Prettier

This commit fixes the style issues introduced in a532b7d according to the output
from Gofumpt and Prettier.

Details: #2477

* 📈 Add client metric interceptor

Signed-off-by: vankichi <kyukawa315@gmail.com>

* ♻️ Change vbor chart for apply general job configuration

Signed-off-by: vankichi <kyukawa315@gmail.com>

* Update pkg/tools/benchmark/job/usecase/benchmarkd.go

Co-authored-by: Hiroto Funakoshi <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: Kiichiro YUKAWA <kyukawa315@gmail.com>

* 🐛 Fix build error and add comment

Signed-off-by: vankichi <kyukawa315@gmail.com>

* ♻️ Fix format

Signed-off-by: vankichi <kyukawa315@gmail.com>

---------

Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
Co-authored-by: Hiroto Funakoshi <hiroto.funakoshi.hiroto@gmail.com>

* implement ngt-rs and its unit test and add GitHub Actions workflows (#2478)

* implement test

* update rust dependencies

* fix

* make format

* add Github Actions workflows

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

---------

Co-authored-by: Yusuke Kato <kpango@vdaas.org>

* 📈 Add client metrics panels for continuous benchmark job (#2481)

Signed-off-by: vankichi <kyukawa315@gmail.com>

* Add rust versions (#2482)

* add rust versions

* fix

* add rust version

* add rust-toolchain.toml

* make format

* Update continuous benchmark docs (#2485)

* 📝 Update continous benchmark docs

Signed-off-by: vankichi <kyukawa315@gmail.com>

* style: format code with Gofumpt and Prettier

This commit fixes the style issues introduced in e3ab1d2 according to the output
from Gofumpt and Prettier.

Details: #2485

* Update docs/performance/continuous-benchmark.md

Signed-off-by: Kiichiro YUKAWA <kyukawa315@gmail.com>

* 📝 Fix

Signed-off-by: vankichi <kyukawa315@gmail.com>

---------

Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>

* update NGT version (#2484)

* fix sed line (#2488)

* 🤖 Automatically update PULL_REQUEST_TEMPLATE and ISSUE_TEMPLATE (#2487)

Signed-off-by: Vdaas CI <vald@vdaas.org>
Co-authored-by: Hiroto Funakoshi <hiroto.funakoshi.hiroto@gmail.com>

* Add efficient search logic for large top-k users (#2491)

* add efficient search logic for large top-k users

Signed-off-by: kpango <kpango@vdaas.org>

* fix bug

Signed-off-by: kpango <kpango@vdaas.org>

---------

Signed-off-by: kpango <kpango@vdaas.org>

---------

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: Vdaas CI <vald@vdaas.org>
Signed-off-by: kpango <kpango@vdaas.org>
Signed-off-by: Yusuke Kato <kpango@vdaas.org>
Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
Signed-off-by: Yusuke Kadowaki <yusuke.kadowaki.1231@gmail.com>
Signed-off-by: aknishid <koco155@gmail.com>
Signed-off-by: Yamada Takuya <takuya.ymd@gmail.com>
Signed-off-by: aknishid <38955080+aknishid@users.noreply.github.com>
Signed-off-by: Hrichik Mazumder <57860916+hrichiksite@users.noreply.github.com>
Signed-off-by: Hiroto Funakoshi <hiroto.funakoshi.hiroto@gmail.com>
Co-authored-by: vdaas-ci <57942646+vdaas-ci@users.noreply.github.com>
Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
Co-authored-by: Yusuke Kadowaki <yusuke.kadowaki.1231@gmail.com>
Co-authored-by: Yusuke Kato <kpango@vdaas.org>
Co-authored-by: Kosuke Morimoto <ksk@vdaas.org>
Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
Co-authored-by: taisho <taisuou@gmail.com>
Co-authored-by: taisuou <pqrct237@gmail.com>
Co-authored-by: aknishid <38955080+aknishid@users.noreply.github.com>
Co-authored-by: takuyaymd <takuya.ymd@gmail.com>
Co-authored-by: takuyyam <takuyyam@yahoo-corp.jp>
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Co-authored-by: Hrichik Mazumder <57860916+hrichiksite@users.noreply.github.com>
kpango added a commit that referenced this pull request Aug 8, 2024
fix: git add chart directory for release (#2356) (#2357)
[patch] release v1.7.11 (#2358)
:bookmark: :robot: Release v1.7.11 (#2360)
Change docker scan timeout longer (#2363) (#2364)
refactor code using golangci-lint (#2362) (#2365)
Create SECURITY.md (#2367) (#2368)
add commit hash build image (#2359) (#2371)
update docker build target platform selection rules (#2370) (#2374)
Make agent export index metrics to Pod k8s resource (#2319) (#2372)
backport ci deps others (#2386)
Update workflow to release readreplica chart (#2383) (#2387)
:green_heart: :recycle: Add Con-Bench helm chart to the Vald charts (#2388) (#2389)
Delete unnecessary code for mirror (#2366) (#2391)
change JP logo to EN logo (#2369) (#2392)
Add rotate-all option to rotator (#2305) (#2393)
fix: build error of internal kvs test (#2396) (#2398)
Resolve kvs already closed before last saving (#2390) (#2394)
:robot: Update license headers / Format Go codes and YAML files (#2397) (#2400)
create continous benchmark doc (#2352) (#2395)
fix: disable protobuf dispatch for client (#2401) (#2403)
update deps (#2404) (#2405)
[patch] release v1.7.12 (#2406)
:bookmark: :robot: Release v1.7.12 (#2408)
:pencil: Fix typo of file name (#2413) (#2415)
Fix agent-faiss build failed (#2418) (#2419)
Add tests for index information export (#2412) (#2414)
Fix the logic to determine docker image (#2410) (#2420)
Update build rule for nightly image (#2421) (#2422)
Fix output settings to determine-docker-image-tag action and release branch build tag name (#2423) (#2425)
Add `index-operator` template implementation (#2375) (#2424)
fix: typo of execution rule (#2426) (#2427)
Backport Flush API (#2434)
update deps & add validation for Flush API when agent is Read Only (#2433) (#2436)
docs: add hrichiksite as a contributor for doc (#2441) (#2442)
fix: bugfix version update for docker build (#2445) (#2446)
Fix index job logic to pass DNS A record (#2438) (#2448)
Added snapshot timestamp annotations to read replica agent (#2428) (#2443)
Fix operator-sdk version (#2447) (#2449)
add file name lint (#2417) (#2450)
fix: add extra option for ci-container build (#2451) (#2452)
Add base of benchmark operator dashboard (#2430) (#2453)
Implement index operator logic for read replica rotation (#2444) (#2456)
add inner product distance type for ngt (#2454) (#2458)
Fix e2e for read replica and add e2e for index operator (#2455) (#2459)
Add unit tests for index operator (#2460) (#2461)
Bugfix recreate benchmark job when operator reboot (#2463) (#2464)
Refactor k8s types (#2462) (#2465)
:robot: Automatically update PULL_REQUEST_TEMPLATE and ISSUE_TEMPLATE (#2457) (#2469)
Fix workflow trigger for backport pr creation (#2471) (#2472)
Automatically add backport main label for release-pr (#2473) (#2475)
update deps (#2468) (#2476)
Implement client metrics interceptor for continuous benchmark job (#2477) (#2480)
:chart_with_upwards_trend: Add client metrics panels for continuous benchmark job (#2481) (#2483)
Update continuous benchmark docs (#2485) (#2486)
Sync release/v1.7 to main (#2495)
add read replica and rotator docs (#2497) (#2499)
add reviewer guideline (#2507) (#2508)
update large top-K ratio handling logic (#2509) (#2511)
Change default image tag from latest to nightly (#2516) (#2518)
Bugfix that caused an error when argument has 3 or more nil arguments (#2517) (#2520)
add faiss in values.yaml & valdrelease.yaml (#2514) (#2519)
capitalize faq (#2512) (#2522)
Backport docs updates to release/v1.7 (#2521)
[CI] Add workflow to synchronize ubuntu base image (#2526) (#2527)
fix: update schedule (#2528) (#2530)
refactor index manager service add index service API to expose index informations (#2525) (#2532)
fix conflict bug (#2537)
fix: make format (#2534) (#2540)
Backport PR #2542, #2538 to release/v1.7 (#2543)
fix: add checkout option (#2545) (#2546)
Implement ngt Statistics API (#2539) (#2547)
Add workflow to check git conflict for backport PR (#2548) (#2550)
[create-pull-request] automated change (#2552) (#2556)
Update dependencies, C++ standard, and improve Dockerfiles for better build systems and localization (#2549) (#2557)
Backport #2559 (#2560)
[BUGFIX] index correction process (#2565) (#2566)
change external docker image reference to ghcr.io registry (#2567) (#2568)
[patch] Release v1.7.13 (#2569)
:bookmark: :robot: Release v1.7.13 (#2570)
add HTTP2 support for http.Client and Vald HTTP Server (#2572) (#2575)

Signed-off-by: kpango <kpango@vdaas.org>
kpango added a commit that referenced this pull request Aug 8, 2024
fix: git add chart directory for release (#2356) (#2357)
[patch] release v1.7.11 (#2358)
:bookmark: :robot: Release v1.7.11 (#2360)
Change docker scan timeout longer (#2363) (#2364)
refactor code using golangci-lint (#2362) (#2365)
Create SECURITY.md (#2367) (#2368)
add commit hash build image (#2359) (#2371)
update docker build target platform selection rules (#2370) (#2374)
Make agent export index metrics to Pod k8s resource (#2319) (#2372)
backport ci deps others (#2386)
Update workflow to release readreplica chart (#2383) (#2387)
:green_heart: :recycle: Add Con-Bench helm chart to the Vald charts (#2388) (#2389)
Delete unnecessary code for mirror (#2366) (#2391)
change JP logo to EN logo (#2369) (#2392)
Add rotate-all option to rotator (#2305) (#2393)
fix: build error of internal kvs test (#2396) (#2398)
Resolve kvs already closed before last saving (#2390) (#2394)
:robot: Update license headers / Format Go codes and YAML files (#2397) (#2400)
create continous benchmark doc (#2352) (#2395)
fix: disable protobuf dispatch for client (#2401) (#2403)
update deps (#2404) (#2405)
[patch] release v1.7.12 (#2406)
:bookmark: :robot: Release v1.7.12 (#2408)
:pencil: Fix typo of file name (#2413) (#2415)
Fix agent-faiss build failed (#2418) (#2419)
Add tests for index information export (#2412) (#2414)
Fix the logic to determine docker image (#2410) (#2420)
Update build rule for nightly image (#2421) (#2422)
Fix output settings to determine-docker-image-tag action and release branch build tag name (#2423) (#2425)
Add `index-operator` template implementation (#2375) (#2424)
fix: typo of execution rule (#2426) (#2427)
Backport Flush API (#2434)
update deps & add validation for Flush API when agent is Read Only (#2433) (#2436)
docs: add hrichiksite as a contributor for doc (#2441) (#2442)
fix: bugfix version update for docker build (#2445) (#2446)
Fix index job logic to pass DNS A record (#2438) (#2448)
Added snapshot timestamp annotations to read replica agent (#2428) (#2443)
Fix operator-sdk version (#2447) (#2449)
add file name lint (#2417) (#2450)
fix: add extra option for ci-container build (#2451) (#2452)
Add base of benchmark operator dashboard (#2430) (#2453)
Implement index operator logic for read replica rotation (#2444) (#2456)
add inner product distance type for ngt (#2454) (#2458)
Fix e2e for read replica and add e2e for index operator (#2455) (#2459)
Add unit tests for index operator (#2460) (#2461)
Bugfix recreate benchmark job when operator reboot (#2463) (#2464)
Refactor k8s types (#2462) (#2465)
:robot: Automatically update PULL_REQUEST_TEMPLATE and ISSUE_TEMPLATE (#2457) (#2469)
Fix workflow trigger for backport pr creation (#2471) (#2472)
Automatically add backport main label for release-pr (#2473) (#2475)
update deps (#2468) (#2476)
Implement client metrics interceptor for continuous benchmark job (#2477) (#2480)
:chart_with_upwards_trend: Add client metrics panels for continuous benchmark job (#2481) (#2483)
Update continuous benchmark docs (#2485) (#2486)
Sync release/v1.7 to main (#2495)
add read replica and rotator docs (#2497) (#2499)
add reviewer guideline (#2507) (#2508)
update large top-K ratio handling logic (#2509) (#2511)
Change default image tag from latest to nightly (#2516) (#2518)
Bugfix that caused an error when argument has 3 or more nil arguments (#2517) (#2520)
add faiss in values.yaml & valdrelease.yaml (#2514) (#2519)
capitalize faq (#2512) (#2522)
Backport docs updates to release/v1.7 (#2521)
[CI] Add workflow to synchronize ubuntu base image (#2526) (#2527)
fix: update schedule (#2528) (#2530)
refactor index manager service add index service API to expose index informations (#2525) (#2532)
fix conflict bug (#2537)
fix: make format (#2534) (#2540)
Backport PR #2542, #2538 to release/v1.7 (#2543)
fix: add checkout option (#2545) (#2546)
Implement ngt Statistics API (#2539) (#2547)
Add workflow to check git conflict for backport PR (#2548) (#2550)
[create-pull-request] automated change (#2552) (#2556)
Update dependencies, C++ standard, and improve Dockerfiles for better build systems and localization (#2549) (#2557)
Backport #2559 (#2560)
[BUGFIX] index correction process (#2565) (#2566)
change external docker image reference to ghcr.io registry (#2567) (#2568)
[patch] Release v1.7.13 (#2569)
:bookmark: :robot: Release v1.7.13 (#2570)
add HTTP2 support for http.Client and Vald HTTP Server (#2572) (#2575)

Signed-off-by: kpango <kpango@vdaas.org>
kpango added a commit that referenced this pull request Aug 8, 2024
fix: git add chart directory for release (#2356) (#2357)
[patch] release v1.7.11 (#2358)
:bookmark: :robot: Release v1.7.11 (#2360)
Change docker scan timeout longer (#2363) (#2364)
refactor code using golangci-lint (#2362) (#2365)
Create SECURITY.md (#2367) (#2368)
add commit hash build image (#2359) (#2371)
update docker build target platform selection rules (#2370) (#2374)
Make agent export index metrics to Pod k8s resource (#2319) (#2372)
backport ci deps others (#2386)
Update workflow to release readreplica chart (#2383) (#2387)
:green_heart: :recycle: Add Con-Bench helm chart to the Vald charts (#2388) (#2389)
Delete unnecessary code for mirror (#2366) (#2391)
change JP logo to EN logo (#2369) (#2392)
Add rotate-all option to rotator (#2305) (#2393)
fix: build error of internal kvs test (#2396) (#2398)
Resolve kvs already closed before last saving (#2390) (#2394)
:robot: Update license headers / Format Go codes and YAML files (#2397) (#2400)
create continous benchmark doc (#2352) (#2395)
fix: disable protobuf dispatch for client (#2401) (#2403)
update deps (#2404) (#2405)
[patch] release v1.7.12 (#2406)
:bookmark: :robot: Release v1.7.12 (#2408)
:pencil: Fix typo of file name (#2413) (#2415)
Fix agent-faiss build failed (#2418) (#2419)
Add tests for index information export (#2412) (#2414)
Fix the logic to determine docker image (#2410) (#2420)
Update build rule for nightly image (#2421) (#2422)
Fix output settings to determine-docker-image-tag action and release branch build tag name (#2423) (#2425)
Add `index-operator` template implementation (#2375) (#2424)
fix: typo of execution rule (#2426) (#2427)
Backport Flush API (#2434)
update deps & add validation for Flush API when agent is Read Only (#2433) (#2436)
docs: add hrichiksite as a contributor for doc (#2441) (#2442)
fix: bugfix version update for docker build (#2445) (#2446)
Fix index job logic to pass DNS A record (#2438) (#2448)
Added snapshot timestamp annotations to read replica agent (#2428) (#2443)
Fix operator-sdk version (#2447) (#2449)
add file name lint (#2417) (#2450)
fix: add extra option for ci-container build (#2451) (#2452)
Add base of benchmark operator dashboard (#2430) (#2453)
Implement index operator logic for read replica rotation (#2444) (#2456)
add inner product distance type for ngt (#2454) (#2458)
Fix e2e for read replica and add e2e for index operator (#2455) (#2459)
Add unit tests for index operator (#2460) (#2461)
Bugfix recreate benchmark job when operator reboot (#2463) (#2464)
Refactor k8s types (#2462) (#2465)
:robot: Automatically update PULL_REQUEST_TEMPLATE and ISSUE_TEMPLATE (#2457) (#2469)
Fix workflow trigger for backport pr creation (#2471) (#2472)
Automatically add backport main label for release-pr (#2473) (#2475)
update deps (#2468) (#2476)
Implement client metrics interceptor for continuous benchmark job (#2477) (#2480)
:chart_with_upwards_trend: Add client metrics panels for continuous benchmark job (#2481) (#2483)
Update continuous benchmark docs (#2485) (#2486)
Sync release/v1.7 to main (#2495)
add read replica and rotator docs (#2497) (#2499)
add reviewer guideline (#2507) (#2508)
update large top-K ratio handling logic (#2509) (#2511)
Change default image tag from latest to nightly (#2516) (#2518)
Bugfix that caused an error when argument has 3 or more nil arguments (#2517) (#2520)
add faiss in values.yaml & valdrelease.yaml (#2514) (#2519)
capitalize faq (#2512) (#2522)
Backport docs updates to release/v1.7 (#2521)
[CI] Add workflow to synchronize ubuntu base image (#2526) (#2527)
fix: update schedule (#2528) (#2530)
refactor index manager service add index service API to expose index informations (#2525) (#2532)
fix conflict bug (#2537)
fix: make format (#2534) (#2540)
Backport PR #2542, #2538 to release/v1.7 (#2543)
fix: add checkout option (#2545) (#2546)
Implement ngt Statistics API (#2539) (#2547)
Add workflow to check git conflict for backport PR (#2548) (#2550)
[create-pull-request] automated change (#2552) (#2556)
Update dependencies, C++ standard, and improve Dockerfiles for better build systems and localization (#2549) (#2557)
Backport #2559 (#2560)
[BUGFIX] index correction process (#2565) (#2566)
change external docker image reference to ghcr.io registry (#2567) (#2568)
[patch] Release v1.7.13 (#2569)
:bookmark: :robot: Release v1.7.13 (#2570)
add HTTP2 support for http.Client and Vald HTTP Server (#2572) (#2575)

Signed-off-by: kpango <kpango@vdaas.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants