Backport to release/v1.7 #2365

vdaas-ci · 2024-02-15T10:23:09Z

Description

Related Issue

Versions

Go Version: 1.22.0
Docker Version: 20.10.8
Kubernetes Version: v1.29.2
NGT Version: 2.1.6

Checklist

I have read the CONTRIBUTING document and completed our CLA agreement.
I have checked open Pull Requests for the similar feature or fixes?

Special notes for your reviewer

Signed-off-by: kpango <kpango@vdaas.org>

cloudflare-workers-and-pages · 2024-02-15T10:23:11Z

Deploying with Cloudflare Pages

Latest commit:	`b9781d2`
Status:	✅ Deploy successful!
Preview URL:	https://fdabe8e2.vald.pages.dev
Branch Preview URL:	https://backport-release-v1-7-refact.vald.pages.dev

View logs

vdaas-ci · 2024-02-15T10:30:12Z

[WARNING:INTCFG] Changes in interal/config may require you to change Helm charts. Please check.

vdaas-ci · 2024-02-15T10:30:21Z

[CHATOPS:HELP] ChatOps commands.

🙆‍♀️ /approve - approve
🍱 /format - format codes and add licenses
✅ /gen-test - generate test codes
🏷️ /label - add labels
🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

golangci

charts/vald/values.go|695 col 1| ST1021: comment on exported type Kvsdb should be of the form "Kvsdb ..." (with optional leading article) (stylecheck)
charts/vald/values.go|704 col 1| ST1021: comment on exported type Lb should be of the form "Lb ..." (with optional leading article) (stylecheck)
charts/vald/values.go|797 col 1| ST1021: comment on exported type Limits should be of the form "Limits ..." (with optional leading article) (stylecheck)
charts/vald/values.go|800 col 1| ST1021: comment on exported type Liveness should be of the form "Liveness ..." (with optional leading article) (stylecheck)
charts/vald/values.go|817 col 1| ST1021: comment on exported type LivenessProbe should be of the form "LivenessProbe ..." (with optional leading article) (stylecheck)
charts/vald/values.go|836 col 1| ST1021: comment on exported type Logging should be of the form "Logging ..." (with optional leading article) (stylecheck)
charts/vald/values.go|848 col 1| ST1021: comment on exported type Manager should be of the form "Manager ..." (with optional leading article) (stylecheck)
charts/vald/values.go|853 col 1| ST1021: comment on exported type Metrics should be of the form "Metrics ..." (with optional leading article) (stylecheck)
charts/vald/values.go|879 col 1| ST1021: comment on exported type NodeAffinity should be of the form "NodeAffinity ..." (with optional leading article) (stylecheck)
charts/vald/values.go|898 col 1| ST1021: comment on exported type NodeSelectorTermsItems should be of the form "NodeSelectorTermsItems ..." (with optional leading article) (stylecheck)
charts/vald/values.go|901 col 1| ST1021: comment on exported type Observability should be of the form "Observability ..." (with optional leading article) (stylecheck)
charts/vald/values.go|912 col 1| ST1021: comment on exported type PersistentVolume should be of the form "PersistentVolume ..." (with optional leading article) (stylecheck)
charts/vald/values.go|936 col 1| ST1021: comment on exported type PodAffinity should be of the form "PodAffinity ..." (with optional leading article) (stylecheck)
charts/vald/values.go|948 col 1| ST1021: comment on exported type PodAntiAffinity should be of the form "PodAntiAffinity ..." (with optional leading article) (stylecheck)
charts/vald/values.go|966 col 1| ST1021: comment on exported type PodPriority should be of the form "PodPriority ..." (with optional leading article) (stylecheck)
charts/vald/values.go|978 col 1| ST1021: comment on exported type Pprof should be of the form "Pprof ..." (with optional leading article) (stylecheck)
charts/vald/values.go|994 col 1| ST1021: comment on exported type PreferredDuringSchedulingIgnoredDuringExecutionItems should be of the form "PreferredDuringSchedulingIgnoredDuringExecutionItems ..." (with optional leading article) (stylecheck)
charts/vald/values.go|997 col 1| ST1021: comment on exported type Prometheus should be of the form "Prometheus ..." (with optional leading article) (stylecheck)
charts/vald/values.go|1018 col 1| ST1021: comment on exported type Readiness should be of the form "Readiness ..." (with optional leading article) (stylecheck)
charts/vald/values.go|1035 col 1| ST1021: comment on exported type ReadinessProbe should be of the form "ReadinessProbe ..." (with optional leading article) (stylecheck)
internal/net/dialer_test.go|268 col 3| directive //nolint:govet,copylocks is unused for linter "govet" (nolintlint)
internal/net/dialer_test.go|271 col 4| directive //nolint:govet,copylocks is unused for linter "govet" (nolintlint)
internal/net/dialer_test.go|274 col 4| directive //nolint:govet,copylocks is unused for linter "govet" (nolintlint)
pkg/index/job/correction/service/options.go|25 col 2| directive //nolint:gomnd is unused for linter "gomnd" (nolintlint)
pkg/index/job/correction/service/options.go|27 col 2| directive //nolint:gomnd is unused for linter "gomnd" (nolintlint)

github-actions · 2024-02-15T10:46:23Z

charts/vald/values.go

@@ -17,14 +17,14 @@ import (
 	"github.com/vdaas/vald/internal/config"
 )

-// Affinity
+// Affinity.


🚫 [golangci] _{reported by reviewdog 🐶}
ST1021: comment on exported type Affinity should be of the form "Affinity ..." (with optional leading article) (stylecheck)

github-actions · 2024-02-15T10:46:23Z

charts/vald/values.go

 type Affinity struct {
 	NodeAffinity    *NodeAffinity    `json:"nodeAffinity,omitempty"`
 	PodAffinity     *PodAffinity     `json:"podAffinity,omitempty"`
 	PodAntiAffinity *PodAntiAffinity `json:"podAntiAffinity,omitempty"`
 }

-// Agent
+// Agent.


🚫 [golangci] _{reported by reviewdog 🐶}
ST1021: comment on exported type Agent should be of the form "Agent ..." (with optional leading article) (stylecheck)

github-actions · 2024-02-15T10:46:23Z

charts/vald/values.go

 type Annotations map[string]string

-// BlobStorage
+// BlobStorage.


🚫 [golangci] _{reported by reviewdog 🐶}
ST1021: comment on exported type BlobStorage should be of the form "BlobStorage ..." (with optional leading article) (stylecheck)

github-actions · 2024-02-15T10:46:24Z

charts/vald/values.go

@@ -135,7 +135,7 @@
 	StorageType string `json:"storage_type,omitempty"`
 }

-// CloudStorage
+// CloudStorage.


🚫 [golangci] _{reported by reviewdog 🐶}
ST1021: comment on exported type CloudStorage should be of the form "CloudStorage ..." (with optional leading article) (stylecheck)

github-actions · 2024-02-15T10:46:24Z

charts/vald/values.go

@@ -161,7 +161,7 @@
 	WriteContentType string `json:"write_content_type,omitempty"`
 }

-// ClusterRole
+// ClusterRole.


🚫 [golangci] _{reported by reviewdog 🐶}
ST1021: comment on exported type ClusterRole should be of the form "ClusterRole ..." (with optional leading article) (stylecheck)

github-actions · 2024-02-15T10:46:25Z

charts/vald/values.go

@@ -591,7 +591,7 @@
 	NodeName string `json:"node_name,omitempty"`
 }

-// Ingress
+// Ingress.


🚫 [golangci] _{reported by reviewdog 🐶}
ST1021: comment on exported type Ingress should be of the form "Ingress ..." (with optional leading article) (stylecheck)

github-actions · 2024-02-15T10:46:25Z

charts/vald/values.go

@@ -629,7 +629,7 @@
 	Vectorizer string `json:"vectorizer,omitempty"`
 }

-// InitContainersItems
+// InitContainersItems.


🚫 [golangci] _{reported by reviewdog 🐶}
ST1021: comment on exported type InitContainersItems should be of the form "InitContainersItems ..." (with optional leading article) (stylecheck)

github-actions · 2024-02-15T10:46:25Z

charts/vald/values.go

@@ -638,10 +638,10 @@
 	SleepDuration int
 }

-// Initializer
+// Initializer.


🚫 [golangci] _{reported by reviewdog 🐶}
ST1021: comment on exported type Initializer should be of the form "Initializer ..." (with optional leading article) (stylecheck)

github-actions · 2024-02-15T10:46:25Z

charts/vald/values.go

 type Initializer struct{}

-// Jaeger
+// Jaeger.


🚫 [golangci] _{reported by reviewdog 🐶}
ST1021: comment on exported type Jaeger should be of the form "Jaeger ..." (with optional leading article) (stylecheck)

github-actions · 2024-02-15T10:46:25Z

charts/vald/values.go

@@ -680,7 +680,7 @@
 	MaxQueueSize int `json:"max_queue_size,omitempty"`
 }

-// Keepalive
+// Keepalive.


🚫 [golangci] _{reported by reviewdog 🐶}
ST1021: comment on exported type Keepalive should be of the form "Keepalive ..." (with optional leading article) (stylecheck)

fix: git add chart directory for release (#2356) (#2357) [patch] release v1.7.11 (#2358) :bookmark: :robot: Release v1.7.11 (#2360) Change docker scan timeout longer (#2363) (#2364) refactor code using golangci-lint (#2362) (#2365) Create SECURITY.md (#2367) (#2368) add commit hash build image (#2359) (#2371) update docker build target platform selection rules (#2370) (#2374) Make agent export index metrics to Pod k8s resource (#2319) (#2372) backport ci deps others (#2386) Update workflow to release readreplica chart (#2383) (#2387) :green_heart: :recycle: Add Con-Bench helm chart to the Vald charts (#2388) (#2389) Delete unnecessary code for mirror (#2366) (#2391) change JP logo to EN logo (#2369) (#2392) Add rotate-all option to rotator (#2305) (#2393) fix: build error of internal kvs test (#2396) (#2398) Resolve kvs already closed before last saving (#2390) (#2394) :robot: Update license headers / Format Go codes and YAML files (#2397) (#2400) create continous benchmark doc (#2352) (#2395) fix: disable protobuf dispatch for client (#2401) (#2403) update deps (#2404) (#2405) [patch] release v1.7.12 (#2406) :bookmark: :robot: Release v1.7.12 (#2408) :pencil: Fix typo of file name (#2413) (#2415) Fix agent-faiss build failed (#2418) (#2419) Add tests for index information export (#2412) (#2414) Fix the logic to determine docker image (#2410) (#2420) Update build rule for nightly image (#2421) (#2422) Fix output settings to determine-docker-image-tag action and release branch build tag name (#2423) (#2425) Add `index-operator` template implementation (#2375) (#2424) fix: typo of execution rule (#2426) (#2427) Backport Flush API (#2434) update deps & add validation for Flush API when agent is Read Only (#2433) (#2436) docs: add hrichiksite as a contributor for doc (#2441) (#2442) fix: bugfix version update for docker build (#2445) (#2446) Fix index job logic to pass DNS A record (#2438) (#2448) Added snapshot timestamp annotations to read replica agent (#2428) (#2443) Fix operator-sdk version (#2447) (#2449) add file name lint (#2417) (#2450) fix: add extra option for ci-container build (#2451) (#2452) Add base of benchmark operator dashboard (#2430) (#2453) Implement index operator logic for read replica rotation (#2444) (#2456) add inner product distance type for ngt (#2454) (#2458) Fix e2e for read replica and add e2e for index operator (#2455) (#2459) Add unit tests for index operator (#2460) (#2461) Bugfix recreate benchmark job when operator reboot (#2463) (#2464) Refactor k8s types (#2462) (#2465) :robot: Automatically update PULL_REQUEST_TEMPLATE and ISSUE_TEMPLATE (#2457) (#2469) Fix workflow trigger for backport pr creation (#2471) (#2472) Automatically add backport main label for release-pr (#2473) (#2475) update deps (#2468) (#2476) Implement client metrics interceptor for continuous benchmark job (#2477) (#2480) :chart_with_upwards_trend: Add client metrics panels for continuous benchmark job (#2481) (#2483) Update continuous benchmark docs (#2485) (#2486) Signed-off-by: kpango <kpango@vdaas.org>

fix: git add chart directory for release (#2356) (#2357) [patch] release v1.7.11 (#2358) :bookmark: :robot: Release v1.7.11 (#2360) Change docker scan timeout longer (#2363) (#2364) refactor code using golangci-lint (#2362) (#2365) Create SECURITY.md (#2367) (#2368) add commit hash build image (#2359) (#2371) update docker build target platform selection rules (#2370) (#2374) Make agent export index metrics to Pod k8s resource (#2319) (#2372) backport ci deps others (#2386) Update workflow to release readreplica chart (#2383) (#2387) :green_heart: :recycle: Add Con-Bench helm chart to the Vald charts (#2388) (#2389) Delete unnecessary code for mirror (#2366) (#2391) change JP logo to EN logo (#2369) (#2392) Add rotate-all option to rotator (#2305) (#2393) fix: build error of internal kvs test (#2396) (#2398) Resolve kvs already closed before last saving (#2390) (#2394) :robot: Update license headers / Format Go codes and YAML files (#2397) (#2400) create continous benchmark doc (#2352) (#2395) fix: disable protobuf dispatch for client (#2401) (#2403) update deps (#2404) (#2405) [patch] release v1.7.12 (#2406) :bookmark: :robot: Release v1.7.12 (#2408) :pencil: Fix typo of file name (#2413) (#2415) Fix agent-faiss build failed (#2418) (#2419) Add tests for index information export (#2412) (#2414) Fix the logic to determine docker image (#2410) (#2420) Update build rule for nightly image (#2421) (#2422) Fix output settings to determine-docker-image-tag action and release branch build tag name (#2423) (#2425) Add `index-operator` template implementation (#2375) (#2424) fix: typo of execution rule (#2426) (#2427) Backport Flush API (#2434) update deps & add validation for Flush API when agent is Read Only (#2433) (#2436) docs: add hrichiksite as a contributor for doc (#2441) (#2442) fix: bugfix version update for docker build (#2445) (#2446) Fix index job logic to pass DNS A record (#2438) (#2448) Added snapshot timestamp annotations to read replica agent (#2428) (#2443) Fix operator-sdk version (#2447) (#2449) add file name lint (#2417) (#2450) fix: add extra option for ci-container build (#2451) (#2452) Add base of benchmark operator dashboard (#2430) (#2453) Implement index operator logic for read replica rotation (#2444) (#2456) add inner product distance type for ngt (#2454) (#2458) Fix e2e for read replica and add e2e for index operator (#2455) (#2459) Add unit tests for index operator (#2460) (#2461) Bugfix recreate benchmark job when operator reboot (#2463) (#2464) Refactor k8s types (#2462) (#2465) :robot: Automatically update PULL_REQUEST_TEMPLATE and ISSUE_TEMPLATE (#2457) (#2469) Fix workflow trigger for backport pr creation (#2471) (#2472) Automatically add backport main label for release-pr (#2473) (#2475) update deps (#2468) (#2476) Implement client metrics interceptor for continuous benchmark job (#2477) (#2480) :chart_with_upwards_trend: Add client metrics panels for continuous benchmark job (#2481) (#2483) Update continuous benchmark docs (#2485) (#2486) Sync release/v1.7 to main (#2495) add read replica and rotator docs (#2497) (#2499) add reviewer guideline (#2507) (#2508) update large top-K ratio handling logic (#2509) (#2511) Change default image tag from latest to nightly (#2516) (#2518) Bugfix that caused an error when argument has 3 or more nil arguments (#2517) (#2520) add faiss in values.yaml & valdrelease.yaml (#2514) (#2519) capitalize faq (#2512) (#2522) Backport docs updates to release/v1.7 (#2521) [CI] Add workflow to synchronize ubuntu base image (#2526) (#2527) fix: update schedule (#2528) (#2530) refactor index manager service add index service API to expose index informations (#2525) (#2532) fix conflict bug (#2537) fix: make format (#2534) (#2540) Backport PR #2542, #2538 to release/v1.7 (#2543) fix: add checkout option (#2545) (#2546) Implement ngt Statistics API (#2539) (#2547) Add workflow to check git conflict for backport PR (#2548) (#2550) [create-pull-request] automated change (#2552) (#2556) Update dependencies, C++ standard, and improve Dockerfiles for better build systems and localization (#2549) (#2557) Backport #2559 (#2560) [BUGFIX] index correction process (#2565) (#2566) change external docker image reference to ghcr.io registry (#2567) (#2568) [patch] Release v1.7.13 (#2569) :bookmark: :robot: Release v1.7.13 (#2570) add HTTP2 support for http.Client and Vald HTTP Server (#2572) (#2575) Signed-off-by: kpango <kpango@vdaas.org>

refactor code using golangci-lint (#2362)

b9781d2

Signed-off-by: kpango <kpango@vdaas.org>

kpango merged commit 7a68d9f into release/v1.7 Feb 15, 2024
117 of 118 checks passed

kpango deleted the backport/release/v1.7/refactor/lint/refactor-by-golangci-lint-autofix branch February 15, 2024 10:24

github-actions bot reviewed Feb 15, 2024

View reviewed changes

vankichi mentioned this pull request Feb 21, 2024

[patch] Release v1.7.12 #2406

Merged

This was referenced Mar 1, 2024

Monthly review time metrics report: 2024-02-01..2024-02-29 ykadowak/actions-test#11

Closed

Monthly review time metrics report: 2024-02-01..2024-02-29 #2429

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Backport to release/v1.7 #2365

Backport to release/v1.7 #2365

vdaas-ci commented Feb 15, 2024

cloudflare-workers-and-pages bot commented Feb 15, 2024 •

edited

Loading

vdaas-ci commented Feb 15, 2024

vdaas-ci commented Feb 15, 2024

github-actions bot left a comment

github-actions bot Feb 15, 2024

github-actions bot Feb 15, 2024

github-actions bot Feb 15, 2024

github-actions bot Feb 15, 2024

github-actions bot Feb 15, 2024

github-actions bot Feb 15, 2024

github-actions bot Feb 15, 2024

github-actions bot Feb 15, 2024

github-actions bot Feb 15, 2024

github-actions bot Feb 15, 2024

Backport to release/v1.7 #2365

Backport to release/v1.7 #2365

Conversation

vdaas-ci commented Feb 15, 2024

Description

Related Issue

Versions

Checklist

Special notes for your reviewer

cloudflare-workers-and-pages bot commented Feb 15, 2024 • edited Loading

Deploying with Cloudflare Pages

vdaas-ci commented Feb 15, 2024

vdaas-ci commented Feb 15, 2024

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Feb 15, 2024

Choose a reason for hiding this comment

github-actions bot Feb 15, 2024

Choose a reason for hiding this comment

github-actions bot Feb 15, 2024

Choose a reason for hiding this comment

github-actions bot Feb 15, 2024

Choose a reason for hiding this comment

github-actions bot Feb 15, 2024

Choose a reason for hiding this comment

github-actions bot Feb 15, 2024

Choose a reason for hiding this comment

github-actions bot Feb 15, 2024

Choose a reason for hiding this comment

github-actions bot Feb 15, 2024

Choose a reason for hiding this comment

github-actions bot Feb 15, 2024

Choose a reason for hiding this comment

github-actions bot Feb 15, 2024

Choose a reason for hiding this comment

cloudflare-workers-and-pages bot commented Feb 15, 2024 •

edited

Loading