Deleted unnecessary event path for docker build

[hlts2]

Description

Do full build at the timing of merging main and release branches.

Related Issue

Versions

• Go Version: 1.22.5
• Rust Version: 1.77.2
• Docker Version: 20.10.8
• Kubernetes Version: v1.30.3
• NGT Version: 2.2.3

Checklist

• I have read the CONTRIBUTING document and completed our CLA agreement.
• I have checked open Pull Requests for the similar feature or fixes?

Special notes for your reviewer

Summary by CodeRabbit

• New Features

  • Simplified GitHub Actions workflows by removing specific path filters for push events, allowing broader triggering of workflows in response to changes across the repository.

• Bug Fixes

  • Adjusted workflow triggering conditions potentially enhancing automation efficiency for CI/CD processes.

• Chores

  • Streamlined workflows to focus on pull request events, reducing complexity in triggering conditions.

[coderabbitai]

Walkthrough

Walkthrough

The recent changes involve the removal of specific path filters from multiple GitHub Actions workflow files. This alteration simplifies the triggering conditions for workflows by allowing them to respond to a broader range of changes without being limited to certain files or directories. As a result, workflows will primarily trigger based on pull request events while reducing the specificity of triggers for push events.

Changes

Files and Summary
Multiple Workflow Files: In .github/workflows/*.yml files, a block of path filters under the push event has been removed, simplifying trigger conditions to allow broader execution based on push events. The pull request triggers remain mostly unchanged, still referencing the action configuration file.

Sequence Diagram(s)

sequenceDiagram
    participant Developer
    participant GitHub
    participant Workflow

    Developer->>GitHub: Push changes
    GitHub->>Workflow: Trigger workflow
    Workflow-->>Developer: Workflow executed

Loading

sequenceDiagram
    participant Developer
    participant GitHub
    participant Workflow

    Developer->>GitHub: Create pull request
    GitHub->>Workflow: Trigger workflow
    Workflow-->>Developer: Workflow executed

Loading

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[vdaas-ci]

[CHATOPS:HELP] ChatOps commands.

• 🙆‍♀️ /approve - approve
• 🍱 /format - format codes and add licenses
• ✅ /gen-test - generate test codes
• 🏷️ /label - add labels
• 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 702e851 and 55a0014.

Files selected for processing (20)

• .github/workflows/dockers-agent-faiss-image.yml (1 hunks)
• .github/workflows/dockers-agent-image.yml (1 hunks)
• .github/workflows/dockers-agent-ngt-image.yml (1 hunks)
• .github/workflows/dockers-agent-sidecar-image.yml (1 hunks)
• .github/workflows/dockers-benchmark-job-image.yml (1 hunks)
• .github/workflows/dockers-benchmark-operator-image.yaml (1 hunks)
• .github/workflows/dockers-ci-container-image.yml (1 hunks)
• .github/workflows/dockers-dev-container-image.yml (1 hunks)
• .github/workflows/dockers-discoverer-k8s-image.yml (1 hunks)
• .github/workflows/dockers-gateway-filter-image.yml (1 hunks)
• .github/workflows/dockers-gateway-lb-image.yml (1 hunks)
• .github/workflows/dockers-gateway-mirror-image.yaml (1 hunks)
• .github/workflows/dockers-helm-operator-image.yml (1 hunks)
• .github/workflows/dockers-index-correction.yml (1 hunks)
• .github/workflows/dockers-index-creation.yml (1 hunks)
• .github/workflows/dockers-index-operator.yml (1 hunks)
• .github/workflows/dockers-index-save.yml (1 hunks)
• .github/workflows/dockers-loadtest-image.yml (1 hunks)
• .github/workflows/dockers-manager-index-image.yml (1 hunks)
• .github/workflows/dockers-readreplica-rotate.yml (1 hunks)

Files skipped from review due to trivial changes (10)

• .github/workflows/dockers-agent-image.yml
• .github/workflows/dockers-agent-sidecar-image.yml
• .github/workflows/dockers-dev-container-image.yml
• .github/workflows/dockers-discoverer-k8s-image.yml
• .github/workflows/dockers-gateway-filter-image.yml
• .github/workflows/dockers-gateway-mirror-image.yaml
• .github/workflows/dockers-helm-operator-image.yml
• .github/workflows/dockers-index-creation.yml
• .github/workflows/dockers-index-operator.yml
• .github/workflows/dockers-index-save.yml

Additional comments not posted (11)

.github/workflows/dockers-ci-container-image.yml (1)

Line range hint 14-32:
Simplified workflow triggers by removing path filters.

The removal of specific path filters under pull_request and pull_request_target sections simplifies the workflow trigger conditions. This change means the workflow will now trigger on any pull request without being limited to certain paths. Ensure that this change aligns with the intended CI/CD process.

.github/workflows/dockers-index-correction.yml (1)

Line range hint 14-33:
Simplified workflow triggers by removing path filters.

The removal of specific path filters under pull_request and pull_request_target sections simplifies the workflow trigger conditions. This change means the workflow will now trigger on any pull request without being limited to certain paths. Ensure that this change aligns with the intended CI/CD process.

.github/workflows/dockers-manager-index-image.yml (1)

Line range hint 14-33:
Simplified workflow triggers by removing path filters.

The removal of specific path filters under pull_request and pull_request_target sections simplifies the workflow trigger conditions. This change means the workflow will now trigger on any pull request without being limited to certain paths. Ensure that this change aligns with the intended CI/CD process.

.github/workflows/dockers-loadtest-image.yml (1)

Line range hint 11-36:
Simplified triggering conditions for the workflow.

The removal of specific path filters under the push event simplifies the workflow's triggering conditions. This change allows the workflow to trigger on a broader range of changes, potentially increasing the workflow's activity.

Ensure that this broader triggering scope aligns with the desired CI/CD process and does not lead to unnecessary workflow executions.

.github/workflows/dockers-readreplica-rotate.yml (1)

Line range hint 11-20:
Simplified triggering conditions for the workflow.

The removal of specific path filters under the push event simplifies the workflow's triggering conditions. This change allows the workflow to trigger on a broader range of changes, potentially increasing the workflow's activity.

Ensure that this broader triggering scope aligns with the desired CI/CD process and does not lead to unnecessary workflow executions.

.github/workflows/dockers-agent-ngt-image.yml (1)

Line range hint 11-36:
Simplified triggering conditions for the workflow.

The removal of specific path filters under the push event simplifies the workflow's triggering conditions. This change allows the workflow to trigger on a broader range of changes, potentially increasing the workflow's activity.

Ensure that this broader triggering scope aligns with the desired CI/CD process and does not lead to unnecessary workflow executions.

.github/workflows/dockers-benchmark-job-image.yml (1)

Line range hint 11-20:
Impact of removing path filters for push event.

The removal of path filters for the push event broadens the scope, causing the workflow to trigger on any push to the specified branches or tags. This change simplifies the workflow configuration but may lead to more frequent builds. Ensure that this behavior is intended.

.github/workflows/dockers-gateway-lb-image.yml (1)

Line range hint 11-21:
Impact of removing path filters for push event.

The removal of path filters for the push event broadens the scope, causing the workflow to trigger on any push to the specified branches or tags. This change simplifies the workflow configuration but may lead to more frequent builds. Ensure that this behavior is intended.

.github/workflows/dockers-agent-faiss-image.yml (1)

Line range hint 11-21:
Impact of removing path filters for push event.

The removal of path filters for the push event broadens the scope, causing the workflow to trigger on any push to the specified branches or tags. This change simplifies the workflow configuration but may lead to more frequent builds. Ensure that this behavior is intended.

.github/workflows/dockers-benchmark-operator-image.yaml (2)

Line range hint 37-70:
Retained paths for pull request events.

The paths that were removed from the on.push.paths section are retained in the pull_request and pull_request_target sections. This ensures that the workflow is still triggered for changes to specific files and directories during pull requests.

However, ensure that this change does not negatively impact the workflow by verifying that all necessary builds are still triggered during pull requests.

Verification successful

---

Retained paths for pull request events.

The paths that were removed from the on.push.paths section are retained in the pull_request and pull_request_target sections. This ensures that the workflow is still triggered for changes to specific files and directories during pull requests.

• .github/workflows/dockers-benchmark-operator-image.yaml retains the necessary paths to trigger the benchmark-operator build job.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify that all necessary builds are still triggered during pull requests after the changes.

# Test: Search for build triggers in the codebase. Expect: Builds are triggered as expected.
rg --type yaml 'trigger: build'

Length of output: 33

---

Script:

#!/bin/bash
# Description: Verify that all necessary builds are still triggered during pull requests after the changes.

# Test: Search for job definitions and their triggers in the YAML workflow files.
rg --type yaml -A 5 'jobs:' .github/workflows/

Length of output: 23822

---

Line range hint 10-36:
Simplified triggering criteria for push events.

The removal of the on.push.paths section simplifies the workflow's triggering criteria. This change aligns with the PR objectives to streamline the build configuration.

However, ensure that this change does not negatively impact the build process by verifying that all necessary builds are still triggered.