Backport PR #2477 to release/v1.7 for Implement client metrics interceptor for continuous benchmark job #2480

vdaas-ci · 2024-04-22T07:25:27Z

Description

This PR contains adding client metrics interceptor and change charts for continuous benchmark tool.

Implement client gRPC metric interceptor
- I have implemented the client metic interceptor at internal/net/grpc/interceptor/client/metic.
Changed vald-benchmark-operator charts

To use the same configs between vald-benchmark-operator and vald-benchmark-job, vald-benhcmark-job Pod uses vald-benchmark-operator's configMap when the container is created.
However, the current operator's chart cannot adapt to this requirement.
So, I have changed the chart and fixed some code under the pkg/tool/benchmark.

Related Issue

Versions

Go Version: 1.22.2
Docker Version: 20.10.8
Kubernetes Version: v1.29.3
NGT Version: 2.2

Checklist

I have read the CONTRIBUTING document and completed our CLA agreement.
I have checked open Pull Requests for the similar feature or fixes?

Special notes for your reviewer

Summary by CodeRabbit

New Features
- Enhanced job configuration in benchmark operator to include detailed client and image settings.
- Introduced new interceptors for metrics and tracing in benchmark jobs.
- Updated Grafana dashboard queries to reflect new job configuration fields.
Bug Fixes
- Fixed logic in setting image pull policies and config map names in Kubernetes job templates.
Refactor
- Reorganized job and observability configurations across multiple components to enhance clarity and maintainability.
- Updated method calls and configurations to use new job image repository and tag fields, improving modularity in benchmark services.
Documentation
- Updated configuration maps and CRD specifications to align with new job structure and settings.

) * ♻️ Mount benchmark-operator-config to vald-benchmark-job Pod Signed-off-by: vankichi <kyukawa315@gmail.com> * 📈 add framework for send gRPC client metrics Signed-off-by: vankichi <kyukawa315@gmail.com> * style: format code with Gofumpt and Prettier This commit fixes the style issues introduced in a532b7d according to the output from Gofumpt and Prettier. Details: #2477 * 📈 Add client metric interceptor Signed-off-by: vankichi <kyukawa315@gmail.com> * ♻️ Change vbor chart for apply general job configuration Signed-off-by: vankichi <kyukawa315@gmail.com> * Update pkg/tools/benchmark/job/usecase/benchmarkd.go Co-authored-by: Hiroto Funakoshi <hiroto.funakoshi.hiroto@gmail.com> Signed-off-by: Kiichiro YUKAWA <kyukawa315@gmail.com> * 🐛 Fix build error and add comment Signed-off-by: vankichi <kyukawa315@gmail.com> * ♻️ Fix format Signed-off-by: vankichi <kyukawa315@gmail.com> --------- Signed-off-by: vankichi <kyukawa315@gmail.com> Signed-off-by: Kiichiro YUKAWA <kyukawa315@gmail.com> Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> Co-authored-by: Hiroto Funakoshi <hiroto.funakoshi.hiroto@gmail.com>

cloudflare-workers-and-pages · 2024-04-22T07:25:29Z

Deploying vald with Cloudflare Pages

Latest commit:	`4d266b8`
Status:	✅ Deploy successful!
Preview URL:	https://adbc1492.vald.pages.dev
Branch Preview URL:	https://backport-release-v1-7-o11y-i.vald.pages.dev

View logs

coderabbitai · 2024-04-22T07:25:49Z

Walkthrough

The updates primarily focus on enhancing the configuration and structuring of job objects across various YAML and Go files in the Vald benchmark operator. These changes introduce more detailed settings for client configurations, image specifications, and observability features, aiming to provide finer control and better resource management within Kubernetes environments.

Changes

Files	Change Summary
`charts/.../crds/valdbenchmarkoperatorrelease.yaml` `k8s/tools/benchmark/operator/crds/valdbenchmarkoperatorrelease.yaml`	Restructured `job` object in `spec` to include `client_config` and `image` with detailed nested properties.
`charts/.../templates/configmap.yaml` `k8s/tools/benchmark/operator/configmap.yaml`	Generalized job configuration and expanded settings in `configmap.yaml`.
`charts/.../values.yaml`	Replaced `job_image` with `job` object including extensive nested configurations.
`cmd/tools/benchmark/job/sample.yaml`	Enhanced `server_config` and `client_config` with new interceptors and observability settings.
`internal/config/benchmark.go` `pkg/tools/benchmark/operator/config/config.go`	Updated structures to support new job and image configurations.
`internal/k8s/vald/benchmark/job/...`	Enhanced job template creation with new fields and methods for environment variables and volume mounts.
`internal/net/grpc/interceptor/client/metric/metric.go` `internal/net/grpc/option.go`	Introduced and integrated metric client interceptors for gRPC.
`k8s/metrics/grafana/dashboards/10-vald-benchmark-operator.yaml`	Updated Grafana dashboard queries to use new `repository` and `tag` fields.
`pkg/tools/benchmark/job/...` `pkg/tools/benchmark/operator/service/...`	Updated job creation logic and observability configurations in service implementations.

🐇✨🌟
In the fields of code, where the snippets lay,
A rabbit hopped, reshaping the fray.
Configs nested, and structs aligned,
With every commit, the features refined.
Cheers to changes, may bugs stay away! 🎉
🌟✨🐇

Recent Review Details

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 68d6e57 and 4d266b8.

Files selected for processing (19)

charts/vald-benchmark-operator/crds/valdbenchmarkoperatorrelease.yaml (1 hunks)
charts/vald-benchmark-operator/templates/configmap.yaml (1 hunks)
charts/vald-benchmark-operator/values.yaml (1 hunks)
cmd/tools/benchmark/job/sample.yaml (7 hunks)
internal/config/benchmark.go (1 hunks)
internal/k8s/vald/benchmark/job/job_template.go (2 hunks)
internal/k8s/vald/benchmark/job/job_template_option.go (1 hunks)
internal/net/grpc/interceptor/client/metric/metric.go (1 hunks)
internal/net/grpc/option.go (2 hunks)
k8s/metrics/grafana/dashboards/10-vald-benchmark-operator.yaml (4 hunks)
k8s/tools/benchmark/operator/configmap.yaml (1 hunks)
k8s/tools/benchmark/operator/crds/valdbenchmarkoperatorrelease.yaml (1 hunks)
pkg/tools/benchmark/job/config/config.go (2 hunks)
pkg/tools/benchmark/job/usecase/benchmarkd.go (3 hunks)
pkg/tools/benchmark/operator/config/config.go (2 hunks)
pkg/tools/benchmark/operator/service/operator.go (4 hunks)
pkg/tools/benchmark/operator/service/operator_test.go (50 hunks)
pkg/tools/benchmark/operator/service/option.go (3 hunks)
pkg/tools/benchmark/operator/usecase/benchmarkd.go (2 hunks)

Additional comments not posted (40)

charts/vald-benchmark-operator/templates/configmap.yaml (1)

41-42: The addition of the job configuration section enhances the flexibility of the benchmark operator. Good use of Helm templating functions.

pkg/tools/benchmark/operator/service/option.go (4)

31-36: The default options are well-defined, ensuring that the benchmark job has sensible defaults.

72-80: Proper implementation of the WithJobImageRepository option. It correctly checks for non-empty strings before assignment.

82-86: The WithJobImageTag function is implemented correctly, following the pattern of checking for a non-empty string.

102-108: The WithConfigMapName option is correctly implemented, enhancing the configurability of the benchmark operator.

internal/net/grpc/interceptor/client/metric/metric.go (1)

40-79: The implementation of the gRPC client metrics interceptor is robust, correctly handling metric creation and recording. Good use of OpenTelemetry for observability.

pkg/tools/benchmark/operator/config/config.go (2)

38-39: The update to the Config struct to include a Job field enhances the configurability of the benchmark operator.

61-64: The NewConfig function is correctly updated to handle the new Job field, ensuring it is properly initialized if not provided.

internal/k8s/vald/benchmark/job/job_template_option.go (2)

55-59: The update to the WithImagePullPolicy option to check for a non-empty string is a good practice, ensuring that only valid policies are set.

62-66: The addition of the WithOperatorConfigMap option enhances the configurability of the Kubernetes job template by allowing a config map name to be set.

internal/k8s/vald/benchmark/job/job_template.go (1)

143-187: The updates to the CreateJobTpl method, including the addition of new environment variables and volume mounts, enhance the configurability of the Kubernetes job template. The inclusion of a config map with specific permissions is well-implemented.

pkg/tools/benchmark/operator/usecase/benchmarkd.go (2)

66-68: The modifications to the function calls for setting up the service with job image details enhance the configurability of the benchmark operator.

102-102: The adjustments to correctly reference job image properties within the observability setup are well-implemented.

k8s/tools/benchmark/operator/configmap.yaml (1)

140-222: The reorganization and expansion of the job section in the configmap.yaml file provide detailed and flexible configuration options for the benchmark operator. This enhances the configurability and functionality of the benchmark tool.

pkg/tools/benchmark/job/usecase/benchmarkd.go (1)

67-84: Initialization of observability and client interceptors looks good.

Please ensure that these interceptors are correctly integrated and tested in the gRPC client setup.

cmd/tools/benchmark/job/sample.yaml (3)

51-52: Addition of Trace and Metric interceptors to the server configuration is appropriate.

Please ensure that these interceptors are functioning as expected during runtime.

162-163: Configuration for metrics export interval and timeout is correctly added.

Please verify that metrics are being exported correctly with these settings.

179-179: Enabling trace under observability is consistent with the objectives to enhance monitoring capabilities.

Please ensure that tracing is working as expected and integrates well with other observability components.

internal/net/grpc/option.go (1)

358-367: Handling of metric interceptors in gRPC client options is implemented correctly.

Consider enhancing the error handling to ensure that interceptor setup failures are more prominently handled, possibly affecting the startup sequence if critical.

internal/config/benchmark.go (2)

237-238: Splitting the Image field into Repository and Tag in BenchmarkJobImageInfo provides better control over image configurations.

Please ensure that these new fields are correctly used in the job configurations and that they integrate well with the deployment processes.

250-254: Addition of OperatorJobConfig struct is appropriate for configuring operator jobs.

Please verify the integration and correct usage of this new configuration structure in the deployment and management of operator jobs.

pkg/tools/benchmark/job/config/config.go (1)

54-60: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [57-78]

Addition of SERVICE_NAME constant and its usage in setting the service name in observability configuration is a good practice for consistency.

Please ensure that this constant is used consistently across the project wherever the service name is needed.

pkg/tools/benchmark/operator/service/operator.go (4)

34-34: Added import for strings package.

This import is necessary for the new functionality in the createJob method where strings are manipulated.

54-55: Added constants Name and ServerName.

These constants are used to standardize the identifiers across the application, improving maintainability and reducing the likelihood of errors due to typos.

63-66: Modified fields in operator struct to include jobImageRepository, jobImageTag, and configMapName.

These changes are aligned with the PR's objectives to enhance configuration management for the benchmarking tools.

477-484: Updated createJob method to use ServerName constant and concatenate jobImageRepository and jobImageTag for container image.

This update ensures that the job creation process is more dynamic and configurable, which is crucial for the scalability and flexibility of the benchmarking operations.

charts/vald-benchmark-operator/crds/valdbenchmarkoperatorrelease.yaml (1)

89-267: Restructured the job object within the spec section to include nested configurations for client_config and image.

This restructuring allows for more granular control over job configurations, which is essential for tailoring the benchmarking process to specific needs.

k8s/tools/benchmark/operator/crds/valdbenchmarkoperatorrelease.yaml (1)

89-267: Restructured the job object within the spec section to include nested properties like client_config, image, and their respective sub-properties.

This comment is a duplicate of the one made in the previous file review, as the changes are identical.

charts/vald-benchmark-operator/values.yaml (1)

40-274: The restructuring of the job configuration in values.yaml is comprehensive and aligns with the PR's objectives to enhance the configurability of the benchmarking tools. The separation of Image into Repository and Tag, and the detailed breakdown of gRPC client configurations (backoff, circuit breaker, call options, dial options, TLS settings) are well-implemented. This should indeed facilitate better management and deployment of benchmark jobs as intended.

However, ensure that these changes are reflected and compatible with the actual application code that consumes these configurations. Any discrepancy between the configuration structure here and the code that parses these configurations could lead to runtime errors or misconfigurations.

k8s/metrics/grafana/dashboards/10-vald-benchmark-operator.yaml (2)

867-867: Ensure the new field "repository" is correctly integrated into the Grafana queries.

Please verify that the "repository" field is correctly populated and reflects the intended data in the Prometheus metrics.

947-947: Ensure the new field "tag" is correctly integrated into the Grafana queries.

Please verify that the "tag" field is correctly populated and reflects the intended data in the Prometheus metrics.

pkg/tools/benchmark/operator/service/operator_test.go (9)

523-524: Renaming jobImage to jobImageRepository and adding jobImageTag aligns with the changes in the main codebase.

560-560: Ensure that the new field jobImageTag is correctly utilized in the test setup.

601-601: The addition of jobImageTag should be reflected in the test scenarios to ensure it is being set and used correctly.

698-698: The test should verify that the jobImageTag is being used correctly, especially in scenarios where the job image might change.

788-788: It's good to see the jobImageTag being included in the test setup. This should help ensure that the image tags are being handled correctly in different scenarios.

827-828: The inclusion of jobImageTag in the jobReconcile function is crucial. Make sure it is being used correctly across all test cases.

852-853: The addition of jobImageTag in the benchJobReconcile function tests is a good practice. This ensures that the tag is considered during the reconciliation process.

1885-1886: The jobImageTag field should be tested thoroughly to ensure it interacts correctly with other components in the scenario reconciliation process.

2694-2695: The tests should include scenarios where the jobImageTag might differ to ensure robustness in handling various configurations.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 2

coderabbitai · 2024-04-22T07:32:57Z

k8s/metrics/grafana/dashboards/10-vald-benchmark-operator.yaml

@@ -880,7 +880,7 @@ data:
                "uid": "prometheus"
              },
              "editorMode": "code",
-              "expr": "label_replace(benchmark_operator_info{exported_kubernetes_namespace=\"$Namespace\", kubernetes_name=~\"$ReplicaSet\", target_pod=~\"$PodName\"}, \"image\", \"$1\", \"image\", \"(.*):.*\")",
+              "expr": "benchmark_operator_info{exported_kubernetes_namespace=\"$Namespace\", kubernetes_name=~\"$ReplicaSet\", target_pod=~\"$PodName\"}",


Update the Prometheus query to reflect the new structure.

- expr: "benchmark_operator_info{exported_kubernetes_namespace=\"$Namespace\", kubernetes_name=~\"$ReplicaSet\", target_pod=~\"$PodName\"}" + expr: "benchmark_operator_info{exported_kubernetes_namespace=\"$Namespace\", kubernetes_name=~\"$ReplicaSet\", target_pod=~\"$PodName\", repository=~\"$Repository\"}"

Ensure that the query now includes the "repository" field to maintain accurate data fetching.

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change

"expr": "benchmark_operator_info{exported_kubernetes_namespace=\"$Namespace\", kubernetes_name=~\"$ReplicaSet\", target_pod=~\"$PodName\"}",

"expr": "benchmark_operator_info{exported_kubernetes_namespace=\"$Namespace\", kubernetes_name=~\"$ReplicaSet\", target_pod=~\"$PodName\", repository=~\"$Repository\"}",

coderabbitai · 2024-04-22T07:32:57Z

k8s/metrics/grafana/dashboards/10-vald-benchmark-operator.yaml

@@ -960,7 +960,7 @@ data:
                "uid": "prometheus"
              },
              "editorMode": "code",
-              "expr": "label_replace(benchmark_operator_info{exported_kubernetes_namespace=\"$Namespace\", kubernetes_name=~\"$ReplicaSet\", target_pod=~\"$PodName\"}, \"image\", \"$1\", \"image\", \".*:(.*)\")",
+              "expr": "benchmark_operator_info{exported_kubernetes_namespace=\"$Namespace\", kubernetes_name=~\"$ReplicaSet\", target_pod=~\"$PodName\"}",


Update the Prometheus query to reflect the new structure.

- expr: "benchmark_operator_info{exported_kubernetes_namespace=\"$Namespace\", kubernetes_name=~\"$ReplicaSet\", target_pod=~\"$PodName\"}" + expr: "benchmark_operator_info{exported_kubernetes_namespace=\"$Namespace\", kubernetes_name=~\"$ReplicaSet\", target_pod=~\"$PodName\", tag=~\"$Tag\"}"

Ensure that the query now includes the "tag" field to maintain accurate data fetching.

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change

"expr": "benchmark_operator_info{exported_kubernetes_namespace=\"$Namespace\", kubernetes_name=~\"$ReplicaSet\", target_pod=~\"$PodName\"}",

"expr": "benchmark_operator_info{exported_kubernetes_namespace=\"$Namespace\", kubernetes_name=~\"$ReplicaSet\", target_pod=~\"$PodName\", tag=~\"$Tag\"}",

vdaas-ci · 2024-04-22T07:34:19Z

[WARNING:INTCFG] Changes in interal/config may require you to change Helm charts. Please check.

vdaas-ci · 2024-04-22T07:34:59Z

[CHATOPS:HELP] ChatOps commands.

🙆‍♀️ /approve - approve
🍱 /format - format codes and add licenses
✅ /gen-test - generate test codes
🏷️ /label - add labels
🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

github-actions · 2024-04-22T07:48:02Z

internal/k8s/vald/benchmark/job/job_template.go

 	svcAccount = "vald-benchmark-operator"
 )

+var mode = int32(420)


🚫 [golangci] _{reported by reviewdog 🐶}
mode is a global variable (gochecknoglobals)

fix: git add chart directory for release (#2356) (#2357) [patch] release v1.7.11 (#2358) :bookmark: :robot: Release v1.7.11 (#2360) Change docker scan timeout longer (#2363) (#2364) refactor code using golangci-lint (#2362) (#2365) Create SECURITY.md (#2367) (#2368) add commit hash build image (#2359) (#2371) update docker build target platform selection rules (#2370) (#2374) Make agent export index metrics to Pod k8s resource (#2319) (#2372) backport ci deps others (#2386) Update workflow to release readreplica chart (#2383) (#2387) :green_heart: :recycle: Add Con-Bench helm chart to the Vald charts (#2388) (#2389) Delete unnecessary code for mirror (#2366) (#2391) change JP logo to EN logo (#2369) (#2392) Add rotate-all option to rotator (#2305) (#2393) fix: build error of internal kvs test (#2396) (#2398) Resolve kvs already closed before last saving (#2390) (#2394) :robot: Update license headers / Format Go codes and YAML files (#2397) (#2400) create continous benchmark doc (#2352) (#2395) fix: disable protobuf dispatch for client (#2401) (#2403) update deps (#2404) (#2405) [patch] release v1.7.12 (#2406) :bookmark: :robot: Release v1.7.12 (#2408) :pencil: Fix typo of file name (#2413) (#2415) Fix agent-faiss build failed (#2418) (#2419) Add tests for index information export (#2412) (#2414) Fix the logic to determine docker image (#2410) (#2420) Update build rule for nightly image (#2421) (#2422) Fix output settings to determine-docker-image-tag action and release branch build tag name (#2423) (#2425) Add `index-operator` template implementation (#2375) (#2424) fix: typo of execution rule (#2426) (#2427) Backport Flush API (#2434) update deps & add validation for Flush API when agent is Read Only (#2433) (#2436) docs: add hrichiksite as a contributor for doc (#2441) (#2442) fix: bugfix version update for docker build (#2445) (#2446) Fix index job logic to pass DNS A record (#2438) (#2448) Added snapshot timestamp annotations to read replica agent (#2428) (#2443) Fix operator-sdk version (#2447) (#2449) add file name lint (#2417) (#2450) fix: add extra option for ci-container build (#2451) (#2452) Add base of benchmark operator dashboard (#2430) (#2453) Implement index operator logic for read replica rotation (#2444) (#2456) add inner product distance type for ngt (#2454) (#2458) Fix e2e for read replica and add e2e for index operator (#2455) (#2459) Add unit tests for index operator (#2460) (#2461) Bugfix recreate benchmark job when operator reboot (#2463) (#2464) Refactor k8s types (#2462) (#2465) :robot: Automatically update PULL_REQUEST_TEMPLATE and ISSUE_TEMPLATE (#2457) (#2469) Fix workflow trigger for backport pr creation (#2471) (#2472) Automatically add backport main label for release-pr (#2473) (#2475) update deps (#2468) (#2476) Implement client metrics interceptor for continuous benchmark job (#2477) (#2480) :chart_with_upwards_trend: Add client metrics panels for continuous benchmark job (#2481) (#2483) Update continuous benchmark docs (#2485) (#2486) Signed-off-by: kpango <kpango@vdaas.org>

fix: git add chart directory for release (#2356) (#2357) [patch] release v1.7.11 (#2358) :bookmark: :robot: Release v1.7.11 (#2360) Change docker scan timeout longer (#2363) (#2364) refactor code using golangci-lint (#2362) (#2365) Create SECURITY.md (#2367) (#2368) add commit hash build image (#2359) (#2371) update docker build target platform selection rules (#2370) (#2374) Make agent export index metrics to Pod k8s resource (#2319) (#2372) backport ci deps others (#2386) Update workflow to release readreplica chart (#2383) (#2387) :green_heart: :recycle: Add Con-Bench helm chart to the Vald charts (#2388) (#2389) Delete unnecessary code for mirror (#2366) (#2391) change JP logo to EN logo (#2369) (#2392) Add rotate-all option to rotator (#2305) (#2393) fix: build error of internal kvs test (#2396) (#2398) Resolve kvs already closed before last saving (#2390) (#2394) :robot: Update license headers / Format Go codes and YAML files (#2397) (#2400) create continous benchmark doc (#2352) (#2395) fix: disable protobuf dispatch for client (#2401) (#2403) update deps (#2404) (#2405) [patch] release v1.7.12 (#2406) :bookmark: :robot: Release v1.7.12 (#2408) :pencil: Fix typo of file name (#2413) (#2415) Fix agent-faiss build failed (#2418) (#2419) Add tests for index information export (#2412) (#2414) Fix the logic to determine docker image (#2410) (#2420) Update build rule for nightly image (#2421) (#2422) Fix output settings to determine-docker-image-tag action and release branch build tag name (#2423) (#2425) Add `index-operator` template implementation (#2375) (#2424) fix: typo of execution rule (#2426) (#2427) Backport Flush API (#2434) update deps & add validation for Flush API when agent is Read Only (#2433) (#2436) docs: add hrichiksite as a contributor for doc (#2441) (#2442) fix: bugfix version update for docker build (#2445) (#2446) Fix index job logic to pass DNS A record (#2438) (#2448) Added snapshot timestamp annotations to read replica agent (#2428) (#2443) Fix operator-sdk version (#2447) (#2449) add file name lint (#2417) (#2450) fix: add extra option for ci-container build (#2451) (#2452) Add base of benchmark operator dashboard (#2430) (#2453) Implement index operator logic for read replica rotation (#2444) (#2456) add inner product distance type for ngt (#2454) (#2458) Fix e2e for read replica and add e2e for index operator (#2455) (#2459) Add unit tests for index operator (#2460) (#2461) Bugfix recreate benchmark job when operator reboot (#2463) (#2464) Refactor k8s types (#2462) (#2465) :robot: Automatically update PULL_REQUEST_TEMPLATE and ISSUE_TEMPLATE (#2457) (#2469) Fix workflow trigger for backport pr creation (#2471) (#2472) Automatically add backport main label for release-pr (#2473) (#2475) update deps (#2468) (#2476) Implement client metrics interceptor for continuous benchmark job (#2477) (#2480) :chart_with_upwards_trend: Add client metrics panels for continuous benchmark job (#2481) (#2483) Update continuous benchmark docs (#2485) (#2486) Sync release/v1.7 to main (#2495) add read replica and rotator docs (#2497) (#2499) add reviewer guideline (#2507) (#2508) update large top-K ratio handling logic (#2509) (#2511) Change default image tag from latest to nightly (#2516) (#2518) Bugfix that caused an error when argument has 3 or more nil arguments (#2517) (#2520) add faiss in values.yaml & valdrelease.yaml (#2514) (#2519) capitalize faq (#2512) (#2522) Backport docs updates to release/v1.7 (#2521) [CI] Add workflow to synchronize ubuntu base image (#2526) (#2527) fix: update schedule (#2528) (#2530) refactor index manager service add index service API to expose index informations (#2525) (#2532) fix conflict bug (#2537) fix: make format (#2534) (#2540) Backport PR #2542, #2538 to release/v1.7 (#2543) fix: add checkout option (#2545) (#2546) Implement ngt Statistics API (#2539) (#2547) Add workflow to check git conflict for backport PR (#2548) (#2550) [create-pull-request] automated change (#2552) (#2556) Update dependencies, C++ standard, and improve Dockerfiles for better build systems and localization (#2549) (#2557) Backport #2559 (#2560) [BUGFIX] index correction process (#2565) (#2566) change external docker image reference to ghcr.io registry (#2567) (#2568) [patch] Release v1.7.13 (#2569) :bookmark: :robot: Release v1.7.13 (#2570) add HTTP2 support for http.Client and Vald HTTP Server (#2572) (#2575) Signed-off-by: kpango <kpango@vdaas.org>

coderabbitai bot reviewed Apr 22, 2024

View reviewed changes

github-actions bot added area/internal area/helm size/XXXL labels Apr 22, 2024

github-actions bot added the priority/low label Apr 22, 2024

github-actions bot reviewed Apr 22, 2024

View reviewed changes

vankichi merged commit 295e796 into release/v1.7 Apr 22, 2024
146 checks passed

vankichi deleted the backport/release/v1.7/o11y/internal-pkg/implement-metrics-for-continuous-benchmark-job branch April 22, 2024 07:51

github-actions bot mentioned this pull request May 1, 2024

Monthly review time metrics report: 2024-04-01..2024-04-30 #2490

Closed

This was referenced Aug 1, 2024

[patch] Release v1.7.3 #2558

Closed

[patch] Release v1.7.13 #2561

Closed

[patch] Release v1.7.13 #2562

Closed

[patch] Release v1.7.13 #2569

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Backport PR #2477 to release/v1.7 for Implement client metrics interceptor for continuous benchmark job #2480

Backport PR #2477 to release/v1.7 for Implement client metrics interceptor for continuous benchmark job #2480

vdaas-ci commented Apr 22, 2024 •

edited by coderabbitai bot

Loading

cloudflare-workers-and-pages bot commented Apr 22, 2024 •

edited

Loading

coderabbitai bot commented Apr 22, 2024 •

edited

Loading

Walkthrough

Changes

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

coderabbitai bot left a comment

coderabbitai bot Apr 22, 2024

coderabbitai bot Apr 22, 2024

vdaas-ci commented Apr 22, 2024

vdaas-ci commented Apr 22, 2024

github-actions bot Apr 22, 2024

	"expr": "benchmark_operator_info{exported_kubernetes_namespace=\"$Namespace\", kubernetes_name=~\"$ReplicaSet\", target_pod=~\"$PodName\"}",
	"expr": "benchmark_operator_info{exported_kubernetes_namespace=\"$Namespace\", kubernetes_name=~\"$ReplicaSet\", target_pod=~\"$PodName\", repository=~\"$Repository\"}",

Backport PR #2477 to release/v1.7 for Implement client metrics interceptor for continuous benchmark job #2480

Backport PR #2477 to release/v1.7 for Implement client metrics interceptor for continuous benchmark job #2480

Conversation

vdaas-ci commented Apr 22, 2024 • edited by coderabbitai bot Loading

Description

Related Issue

Versions

Checklist

Special notes for your reviewer

Summary by CodeRabbit

cloudflare-workers-and-pages bot commented Apr 22, 2024 • edited Loading

Deploying vald with Cloudflare Pages

coderabbitai bot commented Apr 22, 2024 • edited Loading

Walkthrough

Changes

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot Apr 22, 2024

Choose a reason for hiding this comment

coderabbitai bot Apr 22, 2024

Choose a reason for hiding this comment

vdaas-ci commented Apr 22, 2024

vdaas-ci commented Apr 22, 2024

github-actions bot Apr 22, 2024

Choose a reason for hiding this comment

vdaas-ci commented Apr 22, 2024 •

edited by coderabbitai bot

Loading

cloudflare-workers-and-pages bot commented Apr 22, 2024 •

edited

Loading

coderabbitai bot commented Apr 22, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)