-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport PR #2526 to release/v1.7 for [CI] Add workflow to synchronize ubuntu base image #2527
Backport PR #2526 to release/v1.7 for [CI] Add workflow to synchronize ubuntu base image #2527
Conversation
* feat: add sync workflow for ubuntu base image Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: add todo comment Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: docker pull step Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: invalid command Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: add docker tagging Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: invalid config Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: enable arm Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: add tag Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: invalid command Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: add debug job Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: invalid command Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: invalid command Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: invalid command Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: refactor Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: add push image Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: image not found error Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: use docker build action Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: add docker file Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: add docker meta Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: invalid command Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: add build command for buildbase Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: deleted unnecessary workflow Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: file name Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: image name Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: invalid name Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: resolve warning Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: deleted unnecessary file Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: add file to event path Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: add schedule event Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> --------- Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Deploying vald with Cloudflare Pages
|
WalkthroughWalkthroughA new GitHub Actions workflow has been added to automate the building of a Docker image named "buildbase." This workflow is triggered by various conditions, including pushes to specific branches and pull requests. The Makefile and Docker-related build scripts have been updated to support the naming and building of this Docker image, and a new Dockerfile has been introduced to define the image itself. Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant GitHub
participant GitHub Actions
participant Docker Hub
Developer->>GitHub: Push code / Create PR
GitHub-->>GitHub Actions: Trigger workflow
GitHub Actions->>GitHub Actions: Run `dockers-buildbase-image.yml`
GitHub Actions->>Docker Hub: Build and push `buildbase` image
Docker Hub-->>GitHub Actions: Confirmation of image build
GitHub Actions-->>Developer: Notify build success/failure
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
[CHATOPS:HELP] ChatOps commands.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- .github/workflows/dockers-buildbase-image.yml (1 hunks)
- Makefile (1 hunks)
- Makefile.d/docker.mk (1 hunks)
- dockers/buildbase/Dockerfile (1 hunks)
Files skipped from review due to trivial changes (2)
- Makefile
- dockers/buildbase/Dockerfile
Additional comments not posted (3)
.github/workflows/dockers-buildbase-image.yml (2)
42-48
: Confirm the job definition and parameters in the GitHub Actions workflow.The job is correctly using a reusable workflow (
._docker-image.yaml
) with specific parameters set for thebuildbase
target and platforms (linux/amd64,linux/arm64
). This is a good practice for modularity and reusability. Ensure that thesecrets: inherit
setting is appropriate for this context, particularly in terms of security.
17-41
: Review the trigger conditions for the GitHub Actions workflow.The workflow is set to trigger on a schedule, pushes to specific branches and tags, and pull requests. Ensure that these triggers align with the intended use cases for building the Docker image. The exclusion of certain release branch patterns (
!release/v*.*.*
) and inclusion of others (release/v*.*
) should be verified for consistency with the project's versioning strategy.Verification successful
Review the trigger conditions for the GitHub Actions workflow.
The workflow in
.github/workflows/dockers-buildbase-image.yml
is set to trigger on a schedule, pushes to specific branches and tags, and pull requests. The branch and tag patterns align with the intended use cases for building the Docker image. The exclusion of certain release branch patterns (!release/v*.*.*
) and inclusion of others (release/v*.*
) appear consistent with the project's versioning strategy.
.github/workflows/dockers-buildbase-image.yml
: Verified branch and tag patterns.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the consistency of branch patterns in the workflow triggers. # Test: Search for branch patterns in the repository to confirm their usage. rg --type yaml -A 5 $'branches:'Length of output: 31
Script:
#!/bin/bash # Description: Verify the consistency of branch patterns in the workflow triggers. # Test: Search for branch patterns in the repository to confirm their usage. rg --type yaml -A 10 'branches:'Length of output: 32
Script:
#!/bin/bash # Description: Comprehensive search for branch patterns and trigger configurations in YAML files. # Test: Search for branch patterns and other trigger configurations in the repository. rg --type yaml -A 15 'branches:|tags:|paths:'Length of output: 1671
Script:
#!/bin/bash # Description: Search for branch and tag patterns specifically within the .github/workflows directory. # Test: Search for branch and tag patterns in the .github/workflows directory. rg --type yaml -A 15 'branches:|tags:' .github/workflowsLength of output: 51453
Makefile.d/docker.mk (1)
178-187
: Review the new Makefile targets for thebuildbase
Docker image.The new targets
docker/name/buildbase
anddocker/build/buildbase
are correctly defined to handle the naming and building of thebuildbase
Docker image. Ensure that theDOCKERFILE
andIMAGE
variables are appropriately set in the context of the project's Docker strategy. It's also important to confirm that these targets integrate well with existing Docker build processes.
fix: git add chart directory for release (#2356) (#2357) [patch] release v1.7.11 (#2358) :bookmark: :robot: Release v1.7.11 (#2360) Change docker scan timeout longer (#2363) (#2364) refactor code using golangci-lint (#2362) (#2365) Create SECURITY.md (#2367) (#2368) add commit hash build image (#2359) (#2371) update docker build target platform selection rules (#2370) (#2374) Make agent export index metrics to Pod k8s resource (#2319) (#2372) backport ci deps others (#2386) Update workflow to release readreplica chart (#2383) (#2387) :green_heart: :recycle: Add Con-Bench helm chart to the Vald charts (#2388) (#2389) Delete unnecessary code for mirror (#2366) (#2391) change JP logo to EN logo (#2369) (#2392) Add rotate-all option to rotator (#2305) (#2393) fix: build error of internal kvs test (#2396) (#2398) Resolve kvs already closed before last saving (#2390) (#2394) :robot: Update license headers / Format Go codes and YAML files (#2397) (#2400) create continous benchmark doc (#2352) (#2395) fix: disable protobuf dispatch for client (#2401) (#2403) update deps (#2404) (#2405) [patch] release v1.7.12 (#2406) :bookmark: :robot: Release v1.7.12 (#2408) :pencil: Fix typo of file name (#2413) (#2415) Fix agent-faiss build failed (#2418) (#2419) Add tests for index information export (#2412) (#2414) Fix the logic to determine docker image (#2410) (#2420) Update build rule for nightly image (#2421) (#2422) Fix output settings to determine-docker-image-tag action and release branch build tag name (#2423) (#2425) Add `index-operator` template implementation (#2375) (#2424) fix: typo of execution rule (#2426) (#2427) Backport Flush API (#2434) update deps & add validation for Flush API when agent is Read Only (#2433) (#2436) docs: add hrichiksite as a contributor for doc (#2441) (#2442) fix: bugfix version update for docker build (#2445) (#2446) Fix index job logic to pass DNS A record (#2438) (#2448) Added snapshot timestamp annotations to read replica agent (#2428) (#2443) Fix operator-sdk version (#2447) (#2449) add file name lint (#2417) (#2450) fix: add extra option for ci-container build (#2451) (#2452) Add base of benchmark operator dashboard (#2430) (#2453) Implement index operator logic for read replica rotation (#2444) (#2456) add inner product distance type for ngt (#2454) (#2458) Fix e2e for read replica and add e2e for index operator (#2455) (#2459) Add unit tests for index operator (#2460) (#2461) Bugfix recreate benchmark job when operator reboot (#2463) (#2464) Refactor k8s types (#2462) (#2465) :robot: Automatically update PULL_REQUEST_TEMPLATE and ISSUE_TEMPLATE (#2457) (#2469) Fix workflow trigger for backport pr creation (#2471) (#2472) Automatically add backport main label for release-pr (#2473) (#2475) update deps (#2468) (#2476) Implement client metrics interceptor for continuous benchmark job (#2477) (#2480) :chart_with_upwards_trend: Add client metrics panels for continuous benchmark job (#2481) (#2483) Update continuous benchmark docs (#2485) (#2486) Sync release/v1.7 to main (#2495) add read replica and rotator docs (#2497) (#2499) add reviewer guideline (#2507) (#2508) update large top-K ratio handling logic (#2509) (#2511) Change default image tag from latest to nightly (#2516) (#2518) Bugfix that caused an error when argument has 3 or more nil arguments (#2517) (#2520) add faiss in values.yaml & valdrelease.yaml (#2514) (#2519) capitalize faq (#2512) (#2522) Backport docs updates to release/v1.7 (#2521) [CI] Add workflow to synchronize ubuntu base image (#2526) (#2527) fix: update schedule (#2528) (#2530) refactor index manager service add index service API to expose index informations (#2525) (#2532) fix conflict bug (#2537) fix: make format (#2534) (#2540) Backport PR #2542, #2538 to release/v1.7 (#2543) fix: add checkout option (#2545) (#2546) Implement ngt Statistics API (#2539) (#2547) Add workflow to check git conflict for backport PR (#2548) (#2550) [create-pull-request] automated change (#2552) (#2556) Update dependencies, C++ standard, and improve Dockerfiles for better build systems and localization (#2549) (#2557) Backport #2559 (#2560) [BUGFIX] index correction process (#2565) (#2566) change external docker image reference to ghcr.io registry (#2567) (#2568) [patch] Release v1.7.13 (#2569) :bookmark: :robot: Release v1.7.13 (#2570) add HTTP2 support for http.Client and Vald HTTP Server (#2572) (#2575) Signed-off-by: kpango <kpango@vdaas.org>
fix: git add chart directory for release (#2356) (#2357) [patch] release v1.7.11 (#2358) :bookmark: :robot: Release v1.7.11 (#2360) Change docker scan timeout longer (#2363) (#2364) refactor code using golangci-lint (#2362) (#2365) Create SECURITY.md (#2367) (#2368) add commit hash build image (#2359) (#2371) update docker build target platform selection rules (#2370) (#2374) Make agent export index metrics to Pod k8s resource (#2319) (#2372) backport ci deps others (#2386) Update workflow to release readreplica chart (#2383) (#2387) :green_heart: :recycle: Add Con-Bench helm chart to the Vald charts (#2388) (#2389) Delete unnecessary code for mirror (#2366) (#2391) change JP logo to EN logo (#2369) (#2392) Add rotate-all option to rotator (#2305) (#2393) fix: build error of internal kvs test (#2396) (#2398) Resolve kvs already closed before last saving (#2390) (#2394) :robot: Update license headers / Format Go codes and YAML files (#2397) (#2400) create continous benchmark doc (#2352) (#2395) fix: disable protobuf dispatch for client (#2401) (#2403) update deps (#2404) (#2405) [patch] release v1.7.12 (#2406) :bookmark: :robot: Release v1.7.12 (#2408) :pencil: Fix typo of file name (#2413) (#2415) Fix agent-faiss build failed (#2418) (#2419) Add tests for index information export (#2412) (#2414) Fix the logic to determine docker image (#2410) (#2420) Update build rule for nightly image (#2421) (#2422) Fix output settings to determine-docker-image-tag action and release branch build tag name (#2423) (#2425) Add `index-operator` template implementation (#2375) (#2424) fix: typo of execution rule (#2426) (#2427) Backport Flush API (#2434) update deps & add validation for Flush API when agent is Read Only (#2433) (#2436) docs: add hrichiksite as a contributor for doc (#2441) (#2442) fix: bugfix version update for docker build (#2445) (#2446) Fix index job logic to pass DNS A record (#2438) (#2448) Added snapshot timestamp annotations to read replica agent (#2428) (#2443) Fix operator-sdk version (#2447) (#2449) add file name lint (#2417) (#2450) fix: add extra option for ci-container build (#2451) (#2452) Add base of benchmark operator dashboard (#2430) (#2453) Implement index operator logic for read replica rotation (#2444) (#2456) add inner product distance type for ngt (#2454) (#2458) Fix e2e for read replica and add e2e for index operator (#2455) (#2459) Add unit tests for index operator (#2460) (#2461) Bugfix recreate benchmark job when operator reboot (#2463) (#2464) Refactor k8s types (#2462) (#2465) :robot: Automatically update PULL_REQUEST_TEMPLATE and ISSUE_TEMPLATE (#2457) (#2469) Fix workflow trigger for backport pr creation (#2471) (#2472) Automatically add backport main label for release-pr (#2473) (#2475) update deps (#2468) (#2476) Implement client metrics interceptor for continuous benchmark job (#2477) (#2480) :chart_with_upwards_trend: Add client metrics panels for continuous benchmark job (#2481) (#2483) Update continuous benchmark docs (#2485) (#2486) Sync release/v1.7 to main (#2495) add read replica and rotator docs (#2497) (#2499) add reviewer guideline (#2507) (#2508) update large top-K ratio handling logic (#2509) (#2511) Change default image tag from latest to nightly (#2516) (#2518) Bugfix that caused an error when argument has 3 or more nil arguments (#2517) (#2520) add faiss in values.yaml & valdrelease.yaml (#2514) (#2519) capitalize faq (#2512) (#2522) Backport docs updates to release/v1.7 (#2521) [CI] Add workflow to synchronize ubuntu base image (#2526) (#2527) fix: update schedule (#2528) (#2530) refactor index manager service add index service API to expose index informations (#2525) (#2532) fix conflict bug (#2537) fix: make format (#2534) (#2540) Backport PR #2542, #2538 to release/v1.7 (#2543) fix: add checkout option (#2545) (#2546) Implement ngt Statistics API (#2539) (#2547) Add workflow to check git conflict for backport PR (#2548) (#2550) [create-pull-request] automated change (#2552) (#2556) Update dependencies, C++ standard, and improve Dockerfiles for better build systems and localization (#2549) (#2557) Backport #2559 (#2560) [BUGFIX] index correction process (#2565) (#2566) change external docker image reference to ghcr.io registry (#2567) (#2568) [patch] Release v1.7.13 (#2569) :bookmark: :robot: Release v1.7.13 (#2570) add HTTP2 support for http.Client and Vald HTTP Server (#2572) (#2575) Signed-off-by: kpango <kpango@vdaas.org>
fix: git add chart directory for release (#2356) (#2357) [patch] release v1.7.11 (#2358) :bookmark: :robot: Release v1.7.11 (#2360) Change docker scan timeout longer (#2363) (#2364) refactor code using golangci-lint (#2362) (#2365) Create SECURITY.md (#2367) (#2368) add commit hash build image (#2359) (#2371) update docker build target platform selection rules (#2370) (#2374) Make agent export index metrics to Pod k8s resource (#2319) (#2372) backport ci deps others (#2386) Update workflow to release readreplica chart (#2383) (#2387) :green_heart: :recycle: Add Con-Bench helm chart to the Vald charts (#2388) (#2389) Delete unnecessary code for mirror (#2366) (#2391) change JP logo to EN logo (#2369) (#2392) Add rotate-all option to rotator (#2305) (#2393) fix: build error of internal kvs test (#2396) (#2398) Resolve kvs already closed before last saving (#2390) (#2394) :robot: Update license headers / Format Go codes and YAML files (#2397) (#2400) create continous benchmark doc (#2352) (#2395) fix: disable protobuf dispatch for client (#2401) (#2403) update deps (#2404) (#2405) [patch] release v1.7.12 (#2406) :bookmark: :robot: Release v1.7.12 (#2408) :pencil: Fix typo of file name (#2413) (#2415) Fix agent-faiss build failed (#2418) (#2419) Add tests for index information export (#2412) (#2414) Fix the logic to determine docker image (#2410) (#2420) Update build rule for nightly image (#2421) (#2422) Fix output settings to determine-docker-image-tag action and release branch build tag name (#2423) (#2425) Add `index-operator` template implementation (#2375) (#2424) fix: typo of execution rule (#2426) (#2427) Backport Flush API (#2434) update deps & add validation for Flush API when agent is Read Only (#2433) (#2436) docs: add hrichiksite as a contributor for doc (#2441) (#2442) fix: bugfix version update for docker build (#2445) (#2446) Fix index job logic to pass DNS A record (#2438) (#2448) Added snapshot timestamp annotations to read replica agent (#2428) (#2443) Fix operator-sdk version (#2447) (#2449) add file name lint (#2417) (#2450) fix: add extra option for ci-container build (#2451) (#2452) Add base of benchmark operator dashboard (#2430) (#2453) Implement index operator logic for read replica rotation (#2444) (#2456) add inner product distance type for ngt (#2454) (#2458) Fix e2e for read replica and add e2e for index operator (#2455) (#2459) Add unit tests for index operator (#2460) (#2461) Bugfix recreate benchmark job when operator reboot (#2463) (#2464) Refactor k8s types (#2462) (#2465) :robot: Automatically update PULL_REQUEST_TEMPLATE and ISSUE_TEMPLATE (#2457) (#2469) Fix workflow trigger for backport pr creation (#2471) (#2472) Automatically add backport main label for release-pr (#2473) (#2475) update deps (#2468) (#2476) Implement client metrics interceptor for continuous benchmark job (#2477) (#2480) :chart_with_upwards_trend: Add client metrics panels for continuous benchmark job (#2481) (#2483) Update continuous benchmark docs (#2485) (#2486) Sync release/v1.7 to main (#2495) add read replica and rotator docs (#2497) (#2499) add reviewer guideline (#2507) (#2508) update large top-K ratio handling logic (#2509) (#2511) Change default image tag from latest to nightly (#2516) (#2518) Bugfix that caused an error when argument has 3 or more nil arguments (#2517) (#2520) add faiss in values.yaml & valdrelease.yaml (#2514) (#2519) capitalize faq (#2512) (#2522) Backport docs updates to release/v1.7 (#2521) [CI] Add workflow to synchronize ubuntu base image (#2526) (#2527) fix: update schedule (#2528) (#2530) refactor index manager service add index service API to expose index informations (#2525) (#2532) fix conflict bug (#2537) fix: make format (#2534) (#2540) Backport PR #2542, #2538 to release/v1.7 (#2543) fix: add checkout option (#2545) (#2546) Implement ngt Statistics API (#2539) (#2547) Add workflow to check git conflict for backport PR (#2548) (#2550) [create-pull-request] automated change (#2552) (#2556) Update dependencies, C++ standard, and improve Dockerfiles for better build systems and localization (#2549) (#2557) Backport #2559 (#2560) [BUGFIX] index correction process (#2565) (#2566) change external docker image reference to ghcr.io registry (#2567) (#2568) [patch] Release v1.7.13 (#2569) :bookmark: :robot: Release v1.7.13 (#2570) add HTTP2 support for http.Client and Vald HTTP Server (#2572) (#2575) Signed-off-by: kpango <kpango@vdaas.org>
Description
Sometimes we have docker rate limit issues when building locally.
When that problem occurs, I have implemented a way to build using ghcr's base image.
Related Issue
Versions
Checklist
Special notes for your reviewer
Summary by CodeRabbit
New Features
Chores