Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix bug on changelog command #448

Merged
merged 2 commits into from
Jun 8, 2020
Merged

Conversation

rinx
Copy link
Contributor

@rinx rinx commented Jun 8, 2020

Signed-off-by: Rintaro Okamura rintaro.okamura@gmail.com

Description:

Fix bug on /changelog command.

Related Issue:

Nothing.

How Has This Been Tested?:

Nothing.

Environment:

  • Go Version: 1.14.3
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.11.5

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@pull-assistant
Copy link

pull-assistant bot commented Jun 8, 2020

Score: 0.50

Best reviewed: commit by commit


Optimal code review plan (1 warning)

🐛 Fix bug on changelog command

.github/workflows/chatops.yml 50% changes removed in 📝 add link

     📝 add link

Powered by Pull Assistant. Last update 3abf1e1 ... d562b43. Read the comment docs.

@rinx
Copy link
Contributor Author

rinx commented Jun 8, 2020

/rebase

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jun 8, 2020

[REBASE] Rebase triggered by rinx for branch: ci/chatops/fix-changelog-command

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@vdaas-ci vdaas-ci force-pushed the ci/chatops/fix-changelog-command branch from 928d902 to 3abf1e1 Compare June 8, 2020 10:17
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpango kpango merged commit 1ecd515 into master Jun 8, 2020
@kpango kpango deleted the ci/chatops/fix-changelog-command branch June 8, 2020 10:19
@vdaas-ci vdaas-ci mentioned this pull request Jun 8, 2020
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants