-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix internal/log/retry
pacakge
#458
Conversation
Best reviewed: commit by commit
Optimal code review plan
|
Codecov Report
@@ Coverage Diff @@
## master #458 +/- ##
=========================================
- Coverage 7.88% 7.87% -0.01%
=========================================
Files 388 388
Lines 19945 19943 -2
=========================================
- Hits 1573 1571 -2
Misses 18148 18148
Partials 224 224
Continue to review full report at Codecov.
|
/rebase |
[REBASE] Rebase triggered by kevindiu for branch: test/internal/log_retry |
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
fcc2081
to
6b053b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/rebase
/approve
/approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[APPROVED] This PR is approved by vankichi.
Signed-off-by: hlts2 hiroto.funakoshi.hiroto@gmail.com
Description:
I fixed
internal/log/retry
package based on the generated test code.this code's coverage is 100%.
Related Issue:
How Has This Been Tested?:
Environment:
Types of changes:
Changes to Core Features:
Checklist: