-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add options for AWS client #460
Conversation
Best reviewed: commit by commit
Optimal code review plan (2 warnings)
|
[WARNING] Changes in |
feee653
to
0448422
Compare
[WARNING] Changes in |
Codecov Report
@@ Coverage Diff @@
## master #460 +/- ##
=========================================
+ Coverage 7.87% 7.89% +0.01%
=========================================
Files 388 392 +4
Lines 19943 20039 +96
=========================================
+ Hits 1571 1582 +11
- Misses 18148 18222 +74
- Partials 224 235 +11
Continue to review full report at Codecov.
|
0448422
to
a9f0e74
Compare
[WARNING] Changes in |
[WARNING] Changes in |
1 similar comment
[WARNING] Changes in |
/rebase |
[REBASE] Rebase triggered by rinx for branch: feature/agent-sidecar/add-aws-options |
b69a977
to
9cbb127
Compare
[WARNING] Changes in |
[FORMAT] Updating license headers and formatting go codes triggered by rinx. |
[WARNING] Changes in |
/format |
[WARNING] Changes in |
[FORMAT] Updating license headers and formatting go codes triggered by rinx. |
[WARNING] Changes in |
/rebase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[REBASE] Rebase triggered by rinx for branch: feature/agent-sidecar/add-aws-options |
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
Signed-off-by: vdaas-ci <ci@vdaas.org>
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
Signed-off-by: vdaas-ci <ci@vdaas.org>
5c0e8fa
to
600bdff
Compare
[WARNING] Changes in |
Signed-off-by: Rintaro Okamura rintaro.okamura@gmail.com
Description:
Related Issue:
nothing.
How Has This Been Tested?:
nothing.
Environment:
Types of changes:
Changes to Core Features:
Checklist: