-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix failing the test of internal/net/middleware
#469
Conversation
Best reviewed: commit by commit
Optimal code review plan
|
Codecov Report
@@ Coverage Diff @@
## master #469 +/- ##
=========================================
+ Coverage 7.89% 7.92% +0.03%
=========================================
Files 392 392
Lines 20039 20039
=========================================
+ Hits 1582 1589 +7
+ Misses 18222 18217 -5
+ Partials 235 233 -2
Continue to review full report at Codecov.
|
/rebase |
[REBASE] Rebase triggered by hlts2 for branch: test/internal/net_http_middlewares |
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
7af41a9
to
824621c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[APPROVED] This PR is approved by vankichi.
Signed-off-by: hlts2 hiroto.funakoshi.hiroto@gmail.com
Description:
I fixed failing the test of
internal/net/middleware
.Related Issue:
How Has This Been Tested?:
Environment:
Types of changes:
Changes to Core Features:
Checklist: