Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing the test of internal/net/middleware #469

Merged
merged 1 commit into from
Jun 11, 2020

Conversation

hlts2
Copy link
Collaborator

@hlts2 hlts2 commented Jun 11, 2020

Signed-off-by: hlts2 hiroto.funakoshi.hiroto@gmail.com

Description:

I fixed failing the test of internal/net/middleware.

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.14.3
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.11.5

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@hlts2 hlts2 requested a review from kevindiu June 11, 2020 05:37
@hlts2 hlts2 self-assigned this Jun 11, 2020
@pull-assistant
Copy link

pull-assistant bot commented Jun 11, 2020

Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     fix: failing test

Powered by Pull Assistant. Last update 824621c ... 824621c. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 11, 2020

Codecov Report

Merging #469 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #469      +/-   ##
=========================================
+ Coverage    7.89%   7.92%   +0.03%     
=========================================
  Files         392     392              
  Lines       20039   20039              
=========================================
+ Hits         1582    1589       +7     
+ Misses      18222   18217       -5     
+ Partials      235     233       -2     
Impacted Files Coverage Δ
internal/net/http/middleware/timeout.go 100.00% <0.00%> (+22.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5257496...824621c. Read the comment docs.

@hlts2
Copy link
Collaborator Author

hlts2 commented Jun 11, 2020

/rebase

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by hlts2 for branch: test/internal/net_http_middlewares

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@vdaas-ci vdaas-ci force-pushed the test/internal/net_http_middlewares branch from 7af41a9 to 824621c Compare June 11, 2020 07:22
Copy link
Contributor

@kevindiu kevindiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@vankichi vankichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vankichi
Copy link
Contributor

/approve

Copy link
Collaborator

@vdaas-ci vdaas-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[APPROVED] This PR is approved by vankichi.

@vankichi vankichi merged commit 62571b3 into master Jun 11, 2020
@vankichi vankichi deleted the test/internal/net_http_middlewares branch June 11, 2020 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants