Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS region can be specified with empty string #477

Merged

Conversation

rinx
Copy link
Contributor

@rinx rinx commented Jun 16, 2020

Signed-off-by: Rintaro Okamura rintaro.okamura@gmail.com

Description:

AWS region is a required parameter even if it is an empty string.
https://docs.aws.amazon.com/sdk-for-go/api/aws/#Config

In this PR, it can be specified with empty string.

Related Issue:

nothing.

How Has This Been Tested?:

nothing.

Environment:

  • Go Version: 1.14.3
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.11.5

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@codecov
Copy link

codecov bot commented Jun 16, 2020

Codecov Report

Merging #477 into master will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #477   +/-   ##
======================================
  Coverage    7.83%   7.83%           
======================================
  Files         396     396           
  Lines       20322   20320    -2     
======================================
  Hits         1593    1593           
+ Misses      18492   18490    -2     
  Partials      237     237           
Impacted Files Coverage Δ
internal/db/storage/blob/s3/session/session.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32a86e3...d501530. Read the comment docs.

Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpango kpango merged commit 674851f into master Jun 16, 2020
@kpango kpango deleted the refactor/internal-db-storage-s3/can-specify-empty-region branch June 16, 2020 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants