[patch] ✨ Add Stackdriver Monitoring, Tracing and Profiler support #479
Conversation
github-actions
bot
added
area/helm
area/internal
size/XL
type/feature
|
[WARNING:INTCFG] Changes in |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov Report
@@ Coverage Diff @@
## master #479 +/- ##
=========================================
- Coverage 8.07% 8.03% -0.04%
=========================================
Files 396 394 -2
Lines 20320 20419 +99
=========================================
Hits 1640 1640
- Misses 18449 18548 +99
Partials 231 231
Continue to review full report at Codecov.
|
rinx
force-pushed
the
feature/observability/add-stackdriver-metrics-traces
branch
from
3eb16eb
to
0f811d7
Compare
rinx
changed the title
rinx
force-pushed
the
feature/observability/add-stackdriver-metrics-traces
branch
2 times, most recently
from
6adb44b
to
0c3f7ff
Compare
| NumberOfWorkers int `json:"number_of_workers" yaml:"number_of_workers"` | ||
| } | ||
|
|
||
| type StackdriverProfiler struct { |
There was a problem hiding this comment.
[golangci] reported by reviewdog 🐶
struct of size 96 bytes could be of size 88 bytes (maligned)
github-actions
bot
added
size/XXL
team/set
| "go.opencensus.io/trace" | ||
| ) | ||
|
|
||
| type Stackdriver interface { |
There was a problem hiding this comment.
[golangci] reported by reviewdog 🐶
exported type Stackdriver should have comment or be unexported (golint)
| Profiler *StackdriverProfiler `json:"profiler" yaml:"profiler"` | ||
| } | ||
|
|
||
| type StackdriverExporter struct { |
There was a problem hiding this comment.
[golangci] reported by reviewdog 🐶
struct of size 120 bytes could be of size 112 bytes (maligned)
| "google.golang.org/api/option" | ||
| ) | ||
|
|
||
| type Stackdriver interface { |
There was a problem hiding this comment.
[golangci] reported by reviewdog 🐶
exported type Stackdriver should have comment or be unexported (golint)
| } | ||
| ) | ||
|
|
||
| func WithProjectID(pid string) Option { |
There was a problem hiding this comment.
[golangci] reported by reviewdog 🐶
exported function WithProjectID should have comment or be unexported (golint)
| } | ||
| } | ||
|
|
||
| func WithService(name string) Option { |
There was a problem hiding this comment.
[golangci] reported by reviewdog 🐶
exported function WithService should have comment or be unexported (golint)
| } | ||
| } | ||
|
|
||
| func WithServiceVersion(version string) Option { |
There was a problem hiding this comment.
[golangci] reported by reviewdog 🐶
exported function WithServiceVersion should have comment or be unexported (golint)
| } | ||
| } | ||
|
|
||
| func WithDebugLogging(enabled bool) Option { |
There was a problem hiding this comment.
[golangci] reported by reviewdog 🐶
exported function WithDebugLogging should have comment or be unexported (golint)
| } | ||
| } | ||
|
|
||
| func WithMutexProfiling(enabled bool) Option { |
There was a problem hiding this comment.
[golangci] reported by reviewdog 🐶
exported function WithMutexProfiling should have comment or be unexported (golint)
| } | ||
| } | ||
|
|
||
| func WithCPUProfiling(enabled bool) Option { |
There was a problem hiding this comment.
[golangci] reported by reviewdog 🐶
exported function WithCPUProfiling should have comment or be unexported (golint)
| } | ||
| } | ||
|
|
||
| func WithAllocProfiling(enabled bool) Option { |
There was a problem hiding this comment.
[golangci] reported by reviewdog 🐶
exported function WithAllocProfiling should have comment or be unexported (golint)
| } | ||
| } | ||
|
|
||
| func WithHeapProfiling(enabled bool) Option { |
There was a problem hiding this comment.
[golangci] reported by reviewdog 🐶
exported function WithHeapProfiling should have comment or be unexported (golint)
| } | ||
| } | ||
|
|
||
| func WithGoroutineProfiling(enabled bool) Option { |
There was a problem hiding this comment.
[golangci] reported by reviewdog 🐶
exported function WithGoroutineProfiling should have comment or be unexported (golint)
| type Option func(e *exporter) error | ||
|
|
||
| var ( | ||
| defaultOpts = []Option{ |
There was a problem hiding this comment.
[golangci] reported by reviewdog 🐶
defaultOpts is a global variable (gochecknoglobals)
rinx
force-pushed
the
feature/observability/add-stackdriver-metrics-traces
branch
from
bb6a05c
to
0944eb5
Compare
rinx
force-pushed
the
feature/observability/add-stackdriver-metrics-traces
branch
from
6db3513
to
d43117b
Compare
|
[REBASE] Rebase triggered by rinx for branch: feature/observability/add-stackdriver-metrics-traces |
vdaas-ci
force-pushed
the
feature/observability/add-stackdriver-metrics-traces
branch
from
a22ba7e
to
e525a26
Compare
|
[FORMAT] Updating license headers and formatting go codes triggered by rinx. |
| "google.golang.org/api/option" | ||
| ) | ||
|
|
||
| type Option = option.ClientOption |
There was a problem hiding this comment.
[golangci] reported by reviewdog 🐶
exported type Option should have comment or be unexported (golint)
| // WithHTTPClient(client *http.Client) ClientOption | ||
| // WithTokenSource(s oauth2.TokenSource) ClientOption | ||
|
|
||
| func WithAPIKey(apiKey string) Option { |
There was a problem hiding this comment.
[golangci] reported by reviewdog 🐶
exported function WithAPIKey should have comment or be unexported (golint)
| return option.WithAPIKey(apiKey) | ||
| } | ||
|
|
||
| func WithAudiences(audiences ...string) Option { |
There was a problem hiding this comment.
[golangci] reported by reviewdog 🐶
exported function WithAudiences should have comment or be unexported (golint)
| return option.WithAudiences(audiences...) | ||
| } | ||
|
|
||
| func WithCredentialsFile(path string) Option { |
There was a problem hiding this comment.
[golangci] reported by reviewdog 🐶
exported function WithCredentialsFile should have comment or be unexported (golint)
| return option.WithCredentialsFile(path) | ||
| } | ||
|
|
||
| func WithEndpoint(endpoint string) Option { |
There was a problem hiding this comment.
[golangci] reported by reviewdog 🐶
exported function WithEndpoint should have comment or be unexported (golint)
| return option.WithRequestReason(rr) | ||
| } | ||
|
|
||
| func WithScopes(scopes ...string) Option { |
There was a problem hiding this comment.
[golangci] reported by reviewdog 🐶
exported function WithScopes should have comment or be unexported (golint)
| return option.WithScopes(scopes...) | ||
| } | ||
|
|
||
| func WithUserAgent(ua string) Option { |
There was a problem hiding this comment.
[golangci] reported by reviewdog 🐶
exported function WithUserAgent should have comment or be unexported (golint)
| return option.WithUserAgent(ua) | ||
| } | ||
|
|
||
| func WithCredentialsJSON(json string) Option { |
There was a problem hiding this comment.
[golangci] reported by reviewdog 🐶
exported function WithCredentialsJSON should have comment or be unexported (golint)
| return nil | ||
| } | ||
|
|
||
| func WithTelemetry(enabled bool) Option { |
There was a problem hiding this comment.
[golangci] reported by reviewdog 🐶
exported function WithTelemetry should have comment or be unexported (golint)
| return nil | ||
| } | ||
|
|
||
| func WithAuthentication(enabled bool) Option { |
There was a problem hiding this comment.
[golangci] reported by reviewdog 🐶
exported function WithAuthentication should have comment or be unexported (golint)
|
@kpango Fixed. Please check them. /rebase |
|
[REBASE] Rebase triggered by rinx for branch: feature/observability/add-stackdriver-metrics-traces |
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com> :green_heart: Fix detecting internal changes Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
vdaas-ci
force-pushed
the
feature/observability/add-stackdriver-metrics-traces
branch
from
b7fe0ed
to
9699985
Compare
kpango
changed the title
|
/format |
|
[CHANGELOG] Please edit the following lines. |
|
[FORMAT] Updating license headers and formatting go codes triggered by kpango. |
|
[FORMAT] Failed to format. |
Signed-off-by: Rintaro Okamura rintaro.okamura@gmail.com
Description:
Related Issue:
nothing.
How Has This Been Tested?:
nothing.
Environment:
Types of changes:
Changes to Core Features:
Checklist: