Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add delete dataflow in architecture document #591

Merged
merged 11 commits into from
Jul 31, 2020

Conversation

vankichi
Copy link
Contributor

@vankichi vankichi commented Jul 21, 2020

Signed-off-by: vankichi kyukawa315@gmail.com

Description:

I added Vald delete data flow in architecture document and image files.

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.14.4
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.12.0

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@pull-assistant
Copy link

pull-assistant bot commented Jul 21, 2020

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - add changelog comment
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master

docs/overview/architecture.md Outdated Show resolved Hide resolved
docs/overview/architecture.md Outdated Show resolved Hide resolved
@kpango kpango removed their request for review July 28, 2020 07:27
docs/overview/architecture.md Outdated Show resolved Hide resolved
docs/overview/architecture.md Outdated Show resolved Hide resolved
docs/overview/architecture.md Outdated Show resolved Hide resolved
docs/overview/architecture.md Outdated Show resolved Hide resolved
docs/overview/architecture.md Outdated Show resolved Hide resolved
docs/overview/architecture.md Outdated Show resolved Hide resolved
docs/overview/architecture.md Outdated Show resolved Hide resolved
@vankichi vankichi added the team/set SET team label Jul 30, 2020
docs/overview/architecture.md Show resolved Hide resolved
docs/overview/architecture.md Show resolved Hide resolved
docs/overview/architecture.md Outdated Show resolved Hide resolved
docs/overview/architecture.md Outdated Show resolved Hide resolved
@vankichi vankichi marked this pull request as ready for review July 30, 2020 07:57
hlts2
hlts2 previously approved these changes Jul 30, 2020
Copy link
Collaborator

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kevindiu
kevindiu previously approved these changes Jul 30, 2020
Copy link
Contributor

@kevindiu kevindiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. do we need author review?

@vankichi
Copy link
Contributor Author

@kpango @kmrmt @rinx
Could you please review this PR by 8/5(Wed) ?
This PR is about the delete data flow in Vald.

@vankichi vankichi dismissed stale reviews from kevindiu and hlts2 via 01910f3 July 30, 2020 08:27
@kpango
Copy link
Collaborator

kpango commented Jul 30, 2020

LGTM
/rebase
/format
/approve

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by kpango for branch: documentaion/docs/add-delete-flow-in-architecture

@vdaas-ci vdaas-ci force-pushed the documentaion/docs/add-delete-flow-in-architecture branch from 01910f3 to 38ca4bf Compare July 30, 2020 09:29
@vdaas-ci
Copy link
Collaborator

[FORMAT] Updating license headers and formatting go codes triggered by kpango.

vdaas-ci
vdaas-ci previously approved these changes Jul 30, 2020
Copy link
Collaborator

@vdaas-ci vdaas-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[APPROVED] This PR is approved by kpango.

docs/overview/architecture.md Outdated Show resolved Hide resolved
docs/overview/architecture.md Outdated Show resolved Hide resolved
docs/overview/architecture.md Outdated Show resolved Hide resolved
docs/overview/architecture.md Outdated Show resolved Hide resolved
docs/overview/architecture.md Outdated Show resolved Hide resolved
@vankichi
Copy link
Contributor Author

/rebase
/format

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by vankichi for branch: documentaion/docs/add-delete-flow-in-architecture

@vdaas-ci
Copy link
Collaborator

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

@vankichi
Copy link
Contributor Author

/rebase
/format
/approve

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by vankichi for branch: documentaion/docs/add-delete-flow-in-architecture

vankichi and others added 11 commits July 31, 2020 09:06
Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: vankichi <kyukawa315@gmail.com>
Co-authored-by: Kevin Diu <kevin_diu@yahoo.com.hk>
Co-authored-by: Kevin Diu <kevin_diu@yahoo.com.hk>
Co-authored-by: Kevin Diu <kevin_diu@yahoo.com.hk>
Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: vankichi <kyukawa315@gmail.com>
@vdaas-ci vdaas-ci force-pushed the documentaion/docs/add-delete-flow-in-architecture branch from 04abd74 to 81ec37a Compare July 31, 2020 09:06
@vdaas-ci
Copy link
Collaborator

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

Copy link
Collaborator

@vdaas-ci vdaas-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[APPROVED] This PR is approved by vankichi.

@vankichi vankichi merged commit 02b763e into master Jul 31, 2020
@vankichi vankichi deleted the documentaion/docs/add-delete-flow-in-architecture branch July 31, 2020 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants